From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: deskpot@myrealbox.com (Vasily Korytov) Newsgroups: gmane.emacs.bugs Subject: [patch] cperl-mode in 21.2 has faces broken on tty Date: Fri, 17 Jan 2003 05:55:59 +0300 Sender: bug-gnu-emacs-bounces+gnu-bug-gnu-emacs=m.gmane.org@gnu.org Message-ID: <87znq0pjr4.fsf@unix.home> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: main.gmane.org 1042772204 13713 80.91.224.249 (17 Jan 2003 02:56:44 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 17 Jan 2003 02:56:44 +0000 (UTC) Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18ZMgU-0003Yv-00 for ; Fri, 17 Jan 2003 03:56:42 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18ZMgw-0000Yj-00 for gnu-bug-gnu-emacs@m.gmane.org; Thu, 16 Jan 2003 21:57:10 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18ZMg8-00084T-00 for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2003 21:56:20 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18ZMfh-0006mV-00 for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2003 21:55:57 -0500 Original-Received: from ns1.telekom.ru ([194.190.195.83]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18ZMfd-0006Wg-00 for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2003 21:55:49 -0500 Original-Received: from unix.home (h117.217.elnet.msk.ru [194.190.217.117]) by ns1.telekom.ru (8.12.6/8.12.6) with SMTP id h0H2tqOS022833 for ; Fri, 17 Jan 2003 05:55:53 +0300 Original-Received: (qmail 10521 invoked from network); 17 Jan 2003 02:57:22 -0000 Original-Received: from localhost (alias@127.0.0.1) by localhost with QMTP; 17 Jan 2003 02:57:22 -0000 Original-Received: (qmail 10481 invoked by uid 1000); 17 Jan 2003 02:55:59 -0000 Original-To: bug-gnu-emacs@gnu.org X-Attribution: VK X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Bug reports for GNU Emacs, the Swiss army knife of text editors List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: bug-gnu-emacs-bounces+gnu-bug-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.bugs:4226 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:4226 --=-=-= In GNU Emacs 21.2.1 (i686-pc-linux-gnu, X toolkit) of 2003-01-17 on unix.home configured using `configure --without-pop --without-tiff' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: C value of $LC_MONETARY: C value of $LC_NUMERIC: C value of $LC_TIME: C value of $LANG: ru_RU.KOI8-R locale-coding-system: cyrillic-koi8 default-enable-multibyte-characters: t Please describe exactly what actions triggered the bug and the precise symptoms of the bug: cperl-mode from Emacs 21.2 is broken: I can't set faces on a tty by (set-face-* ...), while customize works -- because of a silly (if ...), that, possibly, was actual, whan there was no color on tty and where there was no gnuclient. Happily removed it and sending the patch. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=cperl-mode.el.patch --- cperl-mode.el.orig Tue Nov 20 17:20:12 2001 +++ cperl-mode.el Fri Jan 17 05:51:54 2003 @@ -516,51 +516,49 @@ (repeat symbol))))) :group 'cperl-faces) -(if window-system - (progn - (defvar cperl-dark-background - (cperl-choose-color "navy" "os2blue" "darkgreen")) - (defvar cperl-dark-foreground - (cperl-choose-color "orchid1" "orange")) +(defvar cperl-dark-background + (cperl-choose-color "navy" "os2blue" "darkgreen")) +(defvar cperl-dark-foreground + (cperl-choose-color "orchid1" "orange")) - (defface cperl-nonoverridable-face - `((((class grayscale) (background light)) - (:background "Gray90" :italic t :underline t)) - (((class grayscale) (background dark)) - (:foreground "Gray80" :italic t :underline t :bold t)) - (((class color) (background light)) - (:foreground "chartreuse3")) - (((class color) (background dark)) - (:foreground ,cperl-dark-foreground)) - (t (:bold t :underline t))) - "Font Lock mode face used to highlight array names." - :group 'cperl-faces) +(defface cperl-nonoverridable-face + `((((class grayscale) (background light)) + (:background "Gray90" :italic t :underline t)) + (((class grayscale) (background dark)) + (:foreground "Gray80" :italic t :underline t :bold t)) + (((class color) (background light)) + (:foreground "chartreuse3")) + (((class color) (background dark)) + (:foreground ,cperl-dark-foreground)) + (t (:bold t :underline t))) + "Font Lock mode face used to highlight array names." + :group 'cperl-faces) - (defface cperl-array-face - `((((class grayscale) (background light)) - (:background "Gray90" :bold t)) - (((class grayscale) (background dark)) - (:foreground "Gray80" :bold t)) - (((class color) (background light)) - (:foreground "Blue" :background "lightyellow2" :bold t)) - (((class color) (background dark)) - (:foreground "yellow" :background ,cperl-dark-background :bold t)) - (t (:bold t))) - "Font Lock mode face used to highlight array names." - :group 'cperl-faces) +(defface cperl-array-face + `((((class grayscale) (background light)) + (:background "Gray90" :bold t)) + (((class grayscale) (background dark)) + (:foreground "Gray80" :bold t)) + (((class color) (background light)) + (:foreground "Blue" :background "lightyellow2" :bold t)) + (((class color) (background dark)) + (:foreground "yellow" :background ,cperl-dark-background :bold t)) + (t (:bold t))) + "Font Lock mode face used to highlight array names." + :group 'cperl-faces) - (defface cperl-hash-face - `((((class grayscale) (background light)) - (:background "Gray90" :bold t :italic t)) - (((class grayscale) (background dark)) - (:foreground "Gray80" :bold t :italic t)) - (((class color) (background light)) - (:foreground "Red" :background "lightyellow2" :bold t :italic t)) - (((class color) (background dark)) - (:foreground "Red" :background ,cperl-dark-background :bold t :italic t)) - (t (:bold t :italic t))) - "Font Lock mode face used to highlight hash names." - :group 'cperl-faces))) +(defface cperl-hash-face + `((((class grayscale) (background light)) + (:background "Gray90" :bold t :italic t)) + (((class grayscale) (background dark)) + (:foreground "Gray80" :bold t :italic t)) + (((class color) (background light)) + (:foreground "Red" :background "lightyellow2" :bold t :italic t)) + (((class color) (background dark)) + (:foreground "Red" :background ,cperl-dark-background :bold t :italic t)) + (t (:bold t :italic t))) + "Font Lock mode face used to highlight hash names." + :group 'cperl-faces) --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit _______________________________________________ Bug-gnu-emacs mailing list Bug-gnu-emacs@gnu.org http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs --=-=-=--