[patch] cperl-mode in 21.2 has faces broken on tty

[patch] cperl-mode in 21.2 has faces broken on tty

[Vasily Korytov]

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

In GNU Emacs 21.2.1 (i686-pc-linux-gnu, X toolkit)
 of 2003-01-17 on unix.home
configured using `configure  --without-pop --without-tiff'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: C
  value of $LC_MONETARY: C
  value of $LC_NUMERIC: C
  value of $LC_TIME: C
  value of $LANG: ru_RU.KOI8-R
  locale-coding-system: cyrillic-koi8
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

cperl-mode from Emacs 21.2 is broken: I can't set faces on a tty by
(set-face-* ...), while customize works -- because of a silly (if ...),
that, possibly, was actual, whan there was no color on tty and where
there was no gnuclient.

Happily removed it and sending the patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: cperl-mode.el.patch --]
[-- Type: text/x-patch, Size: 3676 bytes --]

--- cperl-mode.el.orig	Tue Nov 20 17:20:12 2001
+++ cperl-mode.el	Fri Jan 17 05:51:54 2003
@@ -516,51 +516,49 @@
 				   (repeat symbol)))))
   :group 'cperl-faces)
 
-(if window-system
-    (progn
-      (defvar cperl-dark-background
-	(cperl-choose-color "navy" "os2blue" "darkgreen"))
-      (defvar cperl-dark-foreground
-	(cperl-choose-color "orchid1" "orange"))
+(defvar cperl-dark-background
+  (cperl-choose-color "navy" "os2blue" "darkgreen"))
+(defvar cperl-dark-foreground
+  (cperl-choose-color "orchid1" "orange"))
 
-      (defface cperl-nonoverridable-face
-	`((((class grayscale) (background light))
-	   (:background "Gray90" :italic t :underline t))
-	  (((class grayscale) (background dark))
-	   (:foreground "Gray80" :italic t :underline t :bold t))
-	  (((class color) (background light))
-	   (:foreground "chartreuse3"))
-	  (((class color) (background dark))
-	   (:foreground ,cperl-dark-foreground))
-	  (t (:bold t :underline t)))
-	"Font Lock mode face used to highlight array names."
-	:group 'cperl-faces)
+(defface cperl-nonoverridable-face
+  `((((class grayscale) (background light))
+     (:background "Gray90" :italic t :underline t))
+    (((class grayscale) (background dark))
+     (:foreground "Gray80" :italic t :underline t :bold t))
+    (((class color) (background light))
+     (:foreground "chartreuse3"))
+    (((class color) (background dark))
+     (:foreground ,cperl-dark-foreground))
+    (t (:bold t :underline t)))
+  "Font Lock mode face used to highlight array names."
+  :group 'cperl-faces)
 
-      (defface cperl-array-face
-	`((((class grayscale) (background light))
-	   (:background "Gray90" :bold t))
-	  (((class grayscale) (background dark))
-	   (:foreground "Gray80" :bold t))
-	  (((class color) (background light))
-	   (:foreground "Blue" :background "lightyellow2" :bold t))
-	  (((class color) (background dark))
-	   (:foreground "yellow" :background ,cperl-dark-background :bold t))
-	  (t (:bold t)))
-	"Font Lock mode face used to highlight array names."
-	:group 'cperl-faces)
+(defface cperl-array-face
+  `((((class grayscale) (background light))
+     (:background "Gray90" :bold t))
+    (((class grayscale) (background dark))
+     (:foreground "Gray80" :bold t))
+    (((class color) (background light))
+     (:foreground "Blue" :background "lightyellow2" :bold t))
+    (((class color) (background dark))
+     (:foreground "yellow" :background ,cperl-dark-background :bold t))
+    (t (:bold t)))
+  "Font Lock mode face used to highlight array names."
+  :group 'cperl-faces)
 
-      (defface cperl-hash-face
-	`((((class grayscale) (background light))
-	   (:background "Gray90" :bold t :italic t))
-	  (((class grayscale) (background dark))
-	   (:foreground "Gray80" :bold t :italic t))
-	  (((class color) (background light))
-	   (:foreground "Red" :background "lightyellow2" :bold t :italic t))
-	  (((class color) (background dark))
-	   (:foreground "Red" :background ,cperl-dark-background :bold t :italic t))
-	  (t (:bold t :italic t)))
-	"Font Lock mode face used to highlight hash names."
-	:group 'cperl-faces)))
+(defface cperl-hash-face
+  `((((class grayscale) (background light))
+     (:background "Gray90" :bold t :italic t))
+    (((class grayscale) (background dark))
+     (:foreground "Gray80" :bold t :italic t))
+    (((class color) (background light))
+     (:foreground "Red" :background "lightyellow2" :bold t :italic t))
+    (((class color) (background dark))
+     (:foreground "Red" :background ,cperl-dark-background :bold t :italic t))
+    (t (:bold t :italic t)))
+  "Font Lock mode face used to highlight hash names."
+  :group 'cperl-faces)
 
 \f
 

[-- Attachment #3: Type: text/plain, Size: 148 bytes --]

_______________________________________________
Bug-gnu-emacs mailing list
Bug-gnu-emacs@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs