From: Yavor Doganov <yavor@gnu.org>
To: Adrian Robert <adrian.b.robert@gmail.com>,
1335@emacsbugs.donarmstrong.com
Cc: Yavor Doganov <yavor@gnu.org>
Subject: bug#1335: #1335 - Arch-dependant data should not be installed in the app bundle - Emacs bug report logs
Date: Fri, 26 Jun 2009 16:41:50 +0300 [thread overview]
Message-ID: <87zlbvnmch.GNU's_Not_Unix!%yavor@gnu.org> (raw)
In-Reply-To: <5ED0CA60-A3EF-4C7A-81C1-AF9D9EF0DACF@gmail.com>
tags 1335 + patch
thanks
At Mon, 24 Nov 2008 22:29:20 -0500,
Adrian Robert wrote:
> Does this patch not cause an error for you when lines 416-417 in
> Makefile.in (under install-arch-dep target) are executed?
Eek! Not merely an error, the entire working copy is being deleted...
I haven't noticed this because I run "make install" when the tree is
configured with --without-x so these commands are not being run at all
as `ns_appdir' is undefined.
Here's an updated patch, hopefully properly tested this time.
2009-06-26 Yavor Doganov <yavor@gnu.org>
Do not install arch-dependent files in the app bundle if
--disable-ns-self-contained is requested.
* configure.in: Define `exec_prefix' and `libexecdir' relative to
`ns_appbindir' only if configured for a self-contained app.
* Makefile.in (install-arch-dep): Test for the existence of
libexec in the Emacs.app bundle before executing commands.
Index: Makefile.in
===================================================================
RCS file: /sources/emacs/emacs/Makefile.in,v
retrieving revision 1.374
diff -u -r1.374 Makefile.in
--- Makefile.in 4 May 2009 01:13:20 -0000 1.374
+++ Makefile.in 26 Jun 2009 13:34:48 -0000
@@ -429,10 +429,10 @@
if test -d share/emacs ; then dir=share/emacs/*/*; $(MV_DIRS); fi;\
if test -d share/info ; then dir=share/info; $(MV_DIRS) ; fi ; \
rm -fr share ) ; \
- ( cd ${ns_appbindir}/libexec ; dir=emacs/*/*/* ; $(MV_DIRS); \
- rm -fr emacs ) ; \
- ( cd ${ns_appbindir}/bin ; rm -f emacs emacs-23* ; \
- ln -sf ../libexec/* .) ; \
+ ( cd ${ns_appbindir} ; \
+ if test -d libexec; then cd libexec ; dir=emacs/*/*/* ; \
+ $(MV_DIRS); rm -fr emacs; \
+ cd ../bin; rm -f emacs emacs-23* ; ln -sf ../libexec/* . ; fi) ; \
else true ; fi
## http://lists.gnu.org/archive/html/emacs-devel/2007-10/msg01672.html
--- configure.in 19 Jun 2009 17:10:51 -0000 1.598
+++ configure.in 26 Jun 2009 13:35:00 -0000
@@ -1270,10 +1270,10 @@
window_system=nextstep
with_xft=no
# set up packaging dirs
- exec_prefix=${ns_appbindir}
- libexecdir=${ns_appbindir}/libexec
if test "${EN_NS_SELF_CONTAINED}" = yes; then
prefix=${ns_appresdir}
+ exec_prefix=${ns_appbindir}
+ libexecdir=${ns_appbindir}/libexec
fi
fi
CFLAGS="$tmp_CFLAGS"
next prev parent reply other threads:[~2009-06-26 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 3:29 bug#1335: #1335 - Arch-dependant data should not be installed in the app bundle - Emacs bug report logs Adrian Robert
2009-06-26 13:41 ` Yavor Doganov [this message]
2009-06-26 13:50 ` Processed: " Emacs bug Tracking System
2011-11-22 1:59 ` bug#1335: Arch-dependant data should not be installed in the app bundle Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87zlbvnmch.GNU'\''s_Not_Unix'\!'%yavor@gnu.org' \
--to=yavor@gnu.org \
--cc=1335@emacsbugs.donarmstrong.com \
--cc=adrian.b.robert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).