unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#5274: 23.1; doc string of ad-add-advice
@ 2009-12-27 17:29 Drew Adams
  0 siblings, 0 replies; 2+ messages in thread
From: Drew Adams @ 2009-12-27 17:29 UTC (permalink / raw)
  To: bug-gnu-emacs

Doc string:
 
"Add a piece of ADVICE to FUNCTION's list of advices in CLASS.
If FUNCTION already has one or more pieces of advice of the specified
CLASS then POSITION determines where the new piece will go.  The value
of POSITION can either be `first', `last' or a number where 0 corresponds
to `first'.  Numbers outside the range will be mapped to the closest
extreme position.  If there was already a piece of ADVICE with the same
name, then the position argument will be ignored and the old advice
will be overwritten with the new one.
    If the FUNCTION was not advised already, then its advice info will be
initialized.  Redefining a piece of advice whose name is part of the cache-id
will clear the cache."
 
None of the parameters, except POSITION, are described. OK, one can
guess that FUNCTION is a function (but `functionp' or `fboundp'?), but
there is no indication what ADVICE, CLASS, and POSITION are - what
forms they can take.  Might as well say "a piece of FOO" and "list of
foos in THROMBIT".

Each of these parameters needs to be described, just as we do for any
other function's parameters.
 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 








^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#5274: 23.1; doc string of ad-add-advice
       [not found] <ww4omqu81j.fsf@fencepost.gnu.org>
@ 2010-01-16 21:21 ` Chong Yidong
  0 siblings, 0 replies; 2+ messages in thread
From: Chong Yidong @ 2010-01-16 21:21 UTC (permalink / raw)
  To: Drew Adams; +Cc: 5274

> None of the parameters, except POSITION, are described.  Each of these
> parameters needs to be described, just as we do for any other function's
> parameters.

Fixed, thanks.






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-16 21:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <ww4omqu81j.fsf@fencepost.gnu.org>
2010-01-16 21:21 ` bug#5274: 23.1; doc string of ad-add-advice Chong Yidong
2009-12-27 17:29 Drew Adams

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).