From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.bugs Subject: bug#8033: Not the byte compiler; problem lies deeper Date: Mon, 14 Feb 2011 17:08:27 -0500 Message-ID: <87zkpy6zhg.fsf@maru.md5i.com> References: <87lj1jf6h3.fsf@maru.md5i.com> <87oc6e97yu.fsf@maru.md5i.com> <877hd28it5.fsf@maru.md5i.com> <87tyg69tcv.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297723694 20790 80.91.229.12 (14 Feb 2011 22:48:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 14 Feb 2011 22:48:14 +0000 (UTC) Cc: 8033@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 14 23:48:10 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp7DF-0002UL-KC for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Feb 2011 23:48:09 +0100 Original-Received: from localhost ([127.0.0.1]:50433 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pp72C-00058l-6G for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Feb 2011 17:36:44 -0500 Original-Received: from [140.186.70.92] (port=36877 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pp720-00056a-Sq for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2011 17:36:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pp71y-00016A-3R for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2011 17:36:32 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pp71x-000166-VY for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2011 17:36:30 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Pp6Sh-0001Qw-1j; Mon, 14 Feb 2011 17:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Welsh Duggan Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Feb 2011 22:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8033 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8033-submit@debbugs.gnu.org id=B8033.12977207725427 (code B ref 8033); Mon, 14 Feb 2011 22:00:03 +0000 Original-Received: (at 8033) by debbugs.gnu.org; 14 Feb 2011 21:59:32 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp6SB-0001PS-M4 for submit@debbugs.gnu.org; Mon, 14 Feb 2011 16:59:31 -0500 Original-Received: from md5i.com ([75.151.244.229] helo=maru.md5i.com) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp6SA-0001PC-D0 for 8033@debbugs.gnu.org; Mon, 14 Feb 2011 16:59:31 -0500 Original-Received: from md5i by maru.md5i.com with local (Exim 4.72) (envelope-from ) id 1Pp6ap-0006aD-O5; Mon, 14 Feb 2011 17:08:27 -0500 In-Reply-To: <87tyg69tcv.fsf@stupidchicken.com> (Chong Yidong's message of "Mon, 14 Feb 2011 16:52:32 -0500") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 14 Feb 2011 17:00:03 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:44129 Archived-At: Chong Yidong writes: > Michael Welsh Duggan writes: > >> Here is a patch which fixes this problem. >> >> *** src/print.c 2011-02-14 15:39:19 +0000 >> --- src/print.c 2011-02-14 20:24:00 +0000 >> *************** >> *** 1063,1068 **** >> --- 1063,1070 ---- >> /* Generate the fewest number of digits that represent the >> floating point value without losing information. */ >> dtoastr (buf, FLOAT_TO_STRING_BUFSIZE, 0, 0, data); >> + /* Force a decimal point even if integer */ >> + width = 1; >> } >> else /* oink oink */ >> { > > Thanks, but could you explain why printing the float 1.0 as "1" can > cause this problem in Gnus? The code in Gnus passes the actual Lisp > objects around, so the printer shouldn't be involved. Because the byte compiler uses something like `print' in order to create the forms in the elc file, and some "1.0"'s in the `gnus-buffer-configuration' get rendered as "1" in the elc file. Hence, when the .elc file gets loaded instead of the .el file (and why not, it is more recent), you get the bogus integer value instead of the float value. This is also why this issue will not occur for people who have not bootstrapped, since gnus-win.el has not changed. It does not get recompiled, and as a result the elc file left behind by a previous compile still has the "1.0" values in it. -- Michael Welsh Duggan (md5i@md5i.com)