unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: Brendan Miller <catphive@catphive.net>, 9982@debbugs.gnu.org
Subject: bug#9982: Theme faces wrongly applied after background changes.
Date: Sun, 29 Jan 2012 21:28:00 +0800	[thread overview]
Message-ID: <87zkd6bpun.fsf@gnu.org> (raw)
In-Reply-To: <877h0a6a0s.fsf@gnu.org> (Chong Yidong's message of "Sun, 29 Jan 2012 19:08:51 +0800")

Chong Yidong <cyd@gnu.org> writes:

> I installed xfce4 and can now reproduce the bug.  The problem is the
> existence of the `theme-face' property for `default', which is present
> at startup even with emacs -Q.  I don't know where this is coming from
> either, but it rings a dim bell---I'll try to investigate further.

The theme-face is coming from `font-setting-change-default-font' in
dynamic-settings.el:

    (let ((spec (list (list t (face-attr-construct 'default)))))
      (progn
        (put 'default 'customized-face spec)
        (custom-push-theme 'theme-face 'default 'user 'set spec)
        (put 'default 'face-modified nil))))))

As this function is written, it's not going to play nicely with the
Customize or Custom themes code.  It tries to apply the system font
settings by pretending that the user has customized the default face.
The problem is that user customizations override Custom themes.





  reply	other threads:[~2012-01-29 13:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07  2:33 bug#9982: M-x load-theme does not change background color Brendan Miller
2011-11-07 17:46 ` Glenn Morris
2011-11-07 19:55   ` Brendan Miller
2011-11-07 20:29     ` Glenn Morris
2011-11-08  2:01     ` Stefan Monnier
2011-11-08  5:51       ` Brendan Miller
2011-11-08  6:36         ` Eli Zaretskii
2011-11-08  7:38           ` Brendan Miller
2011-11-08  8:24             ` Eli Zaretskii
2011-11-08  8:34               ` Brendan Miller
2011-11-08  8:44                 ` Eli Zaretskii
2011-11-21 19:05             ` Jan Djärv
2011-12-11 13:17             ` Jan Djärv
2011-12-26 15:19               ` bug#9982: Theme faces wrongly applied after background changes Jan Djärv
2012-01-29 11:08                 ` Chong Yidong
2012-01-29 13:28                   ` Chong Yidong [this message]
2012-01-29 14:14                     ` Chong Yidong
2012-01-29 15:22                       ` Jan Djärv
2012-01-29 15:02                     ` Jan Djärv
2012-01-31  8:41                       ` Chong Yidong
2011-11-09  8:18         ` bug#9982: M-x load-theme does not change background color Jan Djärv
     [not found]   ` <mailman.2069.1320695773.15868.bug-gnu-emacs@gnu.org>
2011-11-07 20:09     ` Daimrod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zkd6bpun.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=9982@debbugs.gnu.org \
    --cc=catphive@catphive.net \
    --cc=jan.h.d@swipnet.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).