unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Óscar Fuentes" <ofv@wanadoo.es>
To: 10733@debbugs.gnu.org
Cc: lekktu@gmail.com, "Ota, Takaaki" <Takaaki.Ota@am.sony.com>
Subject: bug#10733: 24.0.93; w32 file truncation
Date: Mon, 06 Feb 2012 17:16:52 +0100	[thread overview]
Message-ID: <87zkcw3pjf.fsf@wanadoo.es> (raw)
In-Reply-To: <874nv45y9f.fsf@wanadoo.es> ("Óscar Fuentes"'s message of "Mon, 06 Feb 2012 06:25:32 +0100")

Óscar Fuentes <ofv@wanadoo.es> writes:

> I bet it is a bug on the CRT (the stat call that retrieves the file
> size, to be precise). Maybe it is a MinGW thing.

No, it is an Emacs thing. `stat' is defined in lib-src/ntlib.c,
overriding the MSVCRT implementation, which accounts for symlinks, while
Emacs' does not.

Before the definition of `stat' on lib-src/ntlib.c there is this
comment:

/* We need this because nt/inc/sys/stat.h defines struct stat that is
   incompatible with the MS run-time libraries.  */

That looks like an understatement. Actually, we need our own stat
function and struct because the `struct stat' that Emacs uses is
incompatible with the one defined in MSVCRT, right?

The obvious fix does not seem difficult, although ugly and
verbose. OTOH, I'll like to remove the Emacs reimplementation of `stat',
but that looks more cumbersome. How much time we have until the release?

BTW, the obvious fix may require some care for not breaking Emacs
support on MS Windows versions prior to XP. We still support Windows 9x,
don't we?





  reply	other threads:[~2012-02-06 16:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-05 22:34 bug#10733: 24.0.93; w32 file truncation Ota, Takaaki
2012-02-05 23:51 ` Juanma Barranquero
2012-02-06  0:16   ` Ota, Takaaki
2012-02-06  4:05     ` Eli Zaretskii
2012-02-06  5:25       ` Óscar Fuentes
2012-02-06 16:16         ` Óscar Fuentes [this message]
2012-02-06 17:21           ` Eli Zaretskii
2012-02-06 17:58             ` Óscar Fuentes
2012-02-06 18:37               ` Eli Zaretskii
2012-02-06 20:19                 ` Ota, Takaaki
2012-02-06 20:23                   ` Lennart Borgman
2012-02-06 21:11                     ` Eli Zaretskii
2012-02-06 21:20                       ` Lennart Borgman
2012-02-06 21:31                         ` Eli Zaretskii
2012-02-06 21:35                           ` Lennart Borgman
2012-02-06 20:24                   ` Lars Ingebrigtsen
2012-02-06 21:09                     ` Eli Zaretskii
2012-02-06 21:08                   ` Eli Zaretskii
2012-02-06 23:27                 ` Óscar Fuentes
2012-02-06 23:43                   ` Ota, Takaaki
2012-02-07  0:07                     ` Óscar Fuentes
2012-02-07  4:02                   ` Eli Zaretskii
2012-02-07  5:22                     ` Óscar Fuentes
2012-02-07 17:35                       ` Eli Zaretskii
2012-08-03 10:59                         ` Eli Zaretskii
2012-02-06 16:55         ` Eli Zaretskii
2012-02-06  0:20   ` Óscar Fuentes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zkcw3pjf.fsf@wanadoo.es \
    --to=ofv@wanadoo.es \
    --cc=10733@debbugs.gnu.org \
    --cc=Takaaki.Ota@am.sony.com \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).