From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.bugs Subject: bug#11199: 24.0.95; killing right-to-left text at eob leads to inconsistent state Date: Mon, 09 Apr 2012 08:18:10 -0400 Message-ID: <87zkal9jzx.fsf@maru.md5i.com> References: <83bon2ad9z.fsf@gnu.org> <8762dacc3w.fsf@maru.md5i.com> <831uny9ekk.fsf@gnu.org> <87ty0uasiq.fsf@maru.md5i.com> <83y5q67z7h.fsf@gnu.org> <87lim6as39.fsf@maru.md5i.com> <83d37h8e4u.fsf@gnu.org> <83aa2l8b0i.fsf@gnu.org> <838vi588ow.fsf@gnu.org> <837gxp86lp.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1333973954 7615 80.91.229.3 (9 Apr 2012 12:19:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 9 Apr 2012 12:19:14 +0000 (UTC) Cc: 11199@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 09 14:19:13 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SHDYu-000438-Uv for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Apr 2012 14:19:13 +0200 Original-Received: from localhost ([::1]:41066 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHDYu-0004XV-93 for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Apr 2012 08:19:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHDYq-0004X7-Jy for bug-gnu-emacs@gnu.org; Mon, 09 Apr 2012 08:19:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SHDYo-0001ZN-NS for bug-gnu-emacs@gnu.org; Mon, 09 Apr 2012 08:19:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHDYo-0001ZB-H6 for bug-gnu-emacs@gnu.org; Mon, 09 Apr 2012 08:19:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SHDZh-0007AC-Im for bug-gnu-emacs@gnu.org; Mon, 09 Apr 2012 08:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Welsh Duggan Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Apr 2012 12:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11199 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11199-submit@debbugs.gnu.org id=B11199.133397395427479 (code B ref 11199); Mon, 09 Apr 2012 12:20:01 +0000 Original-Received: (at 11199) by debbugs.gnu.org; 9 Apr 2012 12:19:14 +0000 Original-Received: from localhost ([127.0.0.1]:46419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHDYv-000799-Ln for submit@debbugs.gnu.org; Mon, 09 Apr 2012 08:19:13 -0400 Original-Received: from md5i.com ([75.151.244.229]:47945 helo=maru.md5i.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHDYs-000791-Rz for 11199@debbugs.gnu.org; Mon, 09 Apr 2012 08:19:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com; s=dkim; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=gb/8HVLDsDsjbFgKc3HyH56SlysXOaYgvNEsTsF6gJM=; b=zC3L4sDJu0GoGTyrIDaOG+HEaJW+20NtjnQkG5UNWPQPwPGjTRRahXUhxlus0IXysX8OWrAYi5spni0hYIhdUAx8lrHxAenwexEO7AqC6X8cswIwkD2g52ItfxBfSO1u; Original-Received: from md5i by maru.md5i.com with local (Exim 4.77) (envelope-from ) id 1SHDXu-0003w4-VV; Mon, 09 Apr 2012 08:18:11 -0400 In-Reply-To: <837gxp86lp.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 09 Apr 2012 14:52:50 +0300") User-Agent: Gnus/5.11002 (No Gnus v0.20) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58636 Archived-At: Eli Zaretskii writes: > Here's the patch to try: > > === modified file 'src/xdisp.c' > --- src/xdisp.c 2012-03-31 19:30:53 +0000 > +++ src/xdisp.c 2012-04-09 11:46:50 +0000 > @@ -16602,7 +16602,15 @@ find_last_unchanged_at_beg_row (struct w > continued. */ > && !(MATRIX_ROW_END_CHARPOS (row) == first_changed_pos > && (row->continued_p > - || row->exact_window_width_line_p))) > + || row->exact_window_width_line_p)) > + /* If ROW->end is beyond ZV, then ROW->end is outdated and > + needs to be recomputed, so don't consider this row as > + unchanged. This happens when the last line was > + bidi-reordered and was killed immediately before this > + redisplay cycle. In that case, ROW->end stores the > + buffer position of the first visual-order character of > + the next row, which is now beyond ZV. */ > + && CHARPOS (row->end.pos) <= ZV) > row_found = row; > > /* Stop if last visible row. */ > I can verify that this patch keeps the original recipe from causing Emacs to crash. Everything looks good for now. -- Michael Welsh Duggan (md5i@md5i.com)