unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Vitalie Spinu <spinuvit@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 12898@debbugs.gnu.org
Subject: bug#12898: 24.2.50.1; Completion is not passed further on in emacs-lisp, org-mode etc.
Date: Tue, 20 Nov 2012 15:47:30 +0100	[thread overview]
Message-ID: <87zk2cz5z1.fsf@gmail.com> (raw)
In-Reply-To: <jwv1ufomm08.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 20 Nov 2012 08:42:56 -0500")

  >> Stefan Monnier <monnier@iro.umontreal.ca>
  >> on Tue, 20 Nov 2012 08:42:56 -0500 wrote:

  >>>> In elisp mode completion-at-point-functions is set to
  >>>> (lisp-completion-at-point t).  If I set it to (t), filename completion
  >>>> works as expected.  So, it's the lisp-completion-at-point that is not
  >>>> handing the completion over.
  SM> Indeed, lisp-completion-at-point should return nil when it determines
  SM> that it cannot provide completion information for the text around point.
  SM> Problem is: how should it determine that?
  >> There is an inbuilt facility (:exclusive 'no).  Why is that not the default?

  SM> Because it only works for prefix-completion, so it's a crutch.

This completely defeats the idea of completion-at-point-functions, and
is makes the completion in emacs-24 pretty much useless at this point.



  SM> The right way to do it is for lisp-completion-at-point function to
  SM> determine whether the data at point should/can be a Lisp name or a file
  SM> name or both (if it's both, it could use the :exclusive crutch, or it
  SM> could combine the completion tables with completion-table-in-turn).

Are you suggesting that every single xxx-mode-completion-function should
do that? That is, check for all possible combination that a symbol at
point might represent? That doesn't look right to me.



Why the final completion is done in completion-at-point and not in
completion--capf-wrapper? This split across two functions asks for
trouble. Wouldn't it be possible to handle everything in
completion--capf-wrapper and call completion-in-region instead of
try-completion in the handling of (:exclusive 'no) part?

    Vitalie





  reply	other threads:[~2012-11-20 14:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 17:14 bug#12898: 24.2.50.1; Completion is not passed further on in emacs-lisp, org-mode etc Vitalie Spinu
2012-11-15 18:40 ` Stefan Monnier
2012-11-20 12:27   ` Vitalie Spinu
2012-11-20 13:42     ` Stefan Monnier
2012-11-20 14:47       ` Vitalie Spinu [this message]
2012-11-20 18:22         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zk2cz5z1.fsf@gmail.com \
    --to=spinuvit@gmail.com \
    --cc=12898@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).