From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#14427: 24.3.50; Highlight symbol at point Date: Mon, 03 Jun 2013 11:54:05 +0300 Organization: JURTA Message-ID: <87zjv7a82a.fsf@mail.jurta.org> References: <87ppwlb6tx.fsf@mail.jurta.org> <87vc5wvnjn.fsf@gmail.com> <87bo7oltg3.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1370249788 23028 80.91.229.3 (3 Jun 2013 08:56:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Jun 2013 08:56:28 +0000 (UTC) Cc: 14427-done@debbugs.gnu.org To: Jambunathan K Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 03 10:56:25 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UjQYy-00069q-Hz for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Jun 2013 10:56:24 +0200 Original-Received: from localhost ([::1]:35960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjQYy-00010f-9J for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Jun 2013 04:56:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjQYr-00010X-3I for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2013 04:56:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjQYm-00074H-Gs for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2013 04:56:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjQYm-000742-EP for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2013 04:56:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UjQaY-00031r-Mn for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2013 04:58:02 -0400 Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jun 2013 08:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 14427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 14427@debbugs.gnu.org, juri@jurta.org, juri@jurta.org Original-Received: via spool by 14427-done@debbugs.gnu.org id=D14427.137024985711530 (code D ref 14427); Mon, 03 Jun 2013 08:58:02 +0000 Original-Received: (at 14427-done) by debbugs.gnu.org; 3 Jun 2013 08:57:37 +0000 Original-Received: from localhost ([127.0.0.1]:48463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjQa8-0002zu-VC for submit@debbugs.gnu.org; Mon, 03 Jun 2013 04:57:37 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:40956 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjQa5-0002zW-7B for 14427-done@debbugs.gnu.org; Mon, 03 Jun 2013 04:57:35 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id D4849258B9E91C; Mon, 3 Jun 2013 01:55:39 -0700 (PDT) In-Reply-To: <87bo7oltg3.fsf@gmail.com> (Jambunathan K.'s message of "Sun, 02 Jun 2013 15:34:28 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74771 Archived-At: >> If you could commit this change, I can start using it right away. Thanks for the reminder, this is installed now. > Small note. I haven't tested the isearch portions of the patch. Isearch integration with hi-lock is far from ideal yet. The limiting factor is that hi-lock is based on font-lock when font-lock is enabled. Otherwise, it is plain search-based. Perhaps we should check in `isearch-highlight-regexp' whether font-lock is active in the current buffer, and when font-lock is disabled then let-bind all relevant search variables like `lax-whitespace', `search-invisible', filters, etc. So search-based hi-lock will be able to highlight correctly the same matches as isearch. This will provide the correct conversion of the search parameters to hi-lock (at least partly for the case when font-lock is disabled and hi-lock is search-based).