From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenjiro NAKAYAMA Newsgroups: gmane.emacs.bugs Subject: bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list. Date: Sat, 14 Dec 2013 23:18:27 +0900 Message-ID: <87zjo3cy8c.fsf@dhcp-193-97.nrt.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1387030823 30056 80.91.229.3 (14 Dec 2013 14:20:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Dec 2013 14:20:23 +0000 (UTC) To: 16144@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 14 15:20:28 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vrq4x-000458-1a for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Dec 2013 15:20:27 +0100 Original-Received: from localhost ([::1]:47492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrq4w-0001bg-8m for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Dec 2013 09:20:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrq4j-0001ZL-HG for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:20:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vrq4Z-0002nD-Hq for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:20:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrq4Z-0002mQ-DU for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:20:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vrq4Y-00052P-Vl for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:20:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Dec 2013 14:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16144 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138703074919292 (code B ref -1); Sat, 14 Dec 2013 14:20:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Dec 2013 14:19:09 +0000 Original-Received: from localhost ([127.0.0.1]:49452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrq3g-000515-O9 for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:19:09 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48627) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrq3e-00050x-IK for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:19:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vrq3V-0002Yw-PU for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:19:06 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:40321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrq3V-0002Ys-MI for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:18:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrq3N-00016H-8B for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:18:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vrq3A-0002Vb-D1 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:18:49 -0500 Original-Received: from mail-pb0-x230.google.com ([2607:f8b0:400e:c01::230]:53762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrq3A-0002VD-6A for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:18:36 -0500 Original-Received: by mail-pb0-f48.google.com with SMTP id md12so3720763pbc.7 for ; Sat, 14 Dec 2013 06:18:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=user-agent:from:to:subject:date:message-id:mime-version :content-type; bh=mPaRVfWMKzYhB6p4H4uAqD8KdqoGdY3IfqObhBK2oMg=; b=MZYl1ynMVriwV+qUWozAq1u4VGhIWxeKxfH2jfYcDDimRD27AuN8yWLn/Q3VnmQ1pg c9uaALspXMzZ6bcpXOKnnc8u0WODU6wsszZ6H1cx1TU6+KRycU85m+fxjvu7B8QWcPTe wCxEzjYmcnZ2j5PAnTUbUsOxtBYsYsp3vjWdNFQC7b8R6Iy12lcq8oQx799oIGemvNnc j1LuHilFim4DNKhkGFToHjB4wyvFmd3v7EfnXdkysWp8O4K6ECAVDoreerwRzXNG8a0r IlXf7CipqzrN1eIM6f3ZhNjok6XQwvRucYFf3RHq1263SarB+pCcwF1GNPylXyNXmMSw ZjQw== X-Received: by 10.66.157.167 with SMTP id wn7mr9537910pab.93.1387030715246; Sat, 14 Dec 2013 06:18:35 -0800 (PST) Original-Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com. [66.187.238.10]) by mx.google.com with ESMTPSA id gf5sm12662610pbc.22.2013.12.14.06.18.32 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Dec 2013 06:18:34 -0800 (PST) User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.2 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81955 Archived-At: I changed bookmark-browse's behavior. This problem gets more serious, if many many windows are opend... * Reproduce the problem. Step1. Open two windows, one is *eww* and the other is not eww. Step2. In the *eww*, open the bookmark list with "B" key. (Now one is *eww*, the other is *eww bookmarks*) Step3. Select one URL in the bookmarklist(eww-bookmark-browse). Step4. Now emacs window is only *eww*. <- #This is the problem. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-bookmark-browse): Don't hide windows with browsing bookmark list. --- lisp/net/eww.el | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 34c6728..c4e948b 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1179,10 +1179,8 @@ Differences in #targets are ignored." (let ((bookmark (get-text-property (line-beginning-position) 'eww-bookmark))) (unless bookmark (error "No bookmark on the current line")) - ;; We wish to leave this window, but if it's the only window here, - ;; just let it remain. - (ignore-errors - (delete-window)) + (eww-bookmark-quit) + (pop-to-buffer "*eww*") (eww-browse-url (plist-get bookmark :url)))) (defun eww-next-bookmark () -- 1.8.3.1