bug#17291: 24.3.90; Doing "make" in elpa branch uses the user's ~/.emacs.d

bug#17291: 24.3.90; Doing "make" in elpa branch uses the user's ~/.emacs.d

[Nicolas Richard]

Hi,

I cloned the elpa repo, ran "make externals" and "make".
It showed me warnings like:

EMACS -f batch-byte-compile packages/ack/ack.el
Warning (emacs): Unable to activate package `use-package'.
Required package `bind-key-1.0' is unavailable

(the exact warning is irrelevant, it's a problem in my own installation)

The reason is that the actual command line (which is unfortunately not
shown on the screen) has -f package-initialize which looks for my own
~/.emacs.d. I suggest the following patch to fix the problem:

	Modified   GNUmakefile
diff --git a/GNUmakefile b/GNUmakefile
index 2b07767..f9deecf 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -131,7 +131,7 @@ elcs := $(call SET-diff, $(naive_elcs), $(patsubst %.el, %.elc, $(nbc_els)))
 %.elc: %.el
 	@echo 'EMACS -f batch-byte-compile $<'
 	@$(EMACS) \
-	    --eval "(setq package-directory-list '(\"$(abspath packages)\"))" \
+	    --eval "(setq package-directory-list nil package-user-dir \"$(abspath packages)\")" \
 	    --eval '(package-initialize)' \
 	    -L $(dir $@) -f batch-byte-compile $<
 
-- 
Nico.

bug#17291: 24.3.90; Doing "make" in elpa branch uses the user's ~/.emacs.d

[Barry OReilly]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

> EMACS -f batch-byte-compile packages/ack/ack.el

> The reason is that the actual command line (which is unfortunately not
> shown on the screen)

I voiced a similar concern before, but Stefan didn't want to change
the output. Showing some but not all flags and arguments gives the
false impression of showing the precise Emacs invocation. I think it
ought to show the full invocation.

[-- Attachment #2: Type: text/html, Size: 456 bytes --]

bug#17291: 24.3.90; Doing "make" in elpa branch uses the user's ~/.emacs.d

[Stefan Monnier]

>> EMACS -f batch-byte-compile packages/ack/ack.el
>> The reason is that the actual command line (which is unfortunately not
>> shown on the screen)
> I voiced a similar concern before, but Stefan didn't want to change
> the output. Showing some but not all flags and arguments gives the
> false impression of showing the precise Emacs invocation. I think it
> ought to show the full invocation.

I'm indeed opposed to showing the whole command because it's too long,
making the output even harder to read (in the "normal" case where
you're looking for byte-compiler errors and warnings).

But it could be improved in 2 ways:
- change the current output so it give less the illusion of being
  a real command.
- provide some option to show the real command.

As for Nicolas's suggestion to "disable" ~/.emacs.d/elpa, I think it
makes sense, since we already use --batch which disables ~/.emacs.
So feel free to install his patch.


        Stefan

bug#17291: 24.3.90; Doing "make" in elpa branch uses the user's ~/.emacs.d

[Barry OReilly]

Applied Nicolas's patch, changed echo messages.