* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message @ 2014-06-10 9:42 David Griffiths 2014-06-10 17:40 ` Eli Zaretskii 2014-06-10 20:40 ` Stefan Monnier 0 siblings, 2 replies; 25+ messages in thread From: David Griffiths @ 2014-06-10 9:42 UTC (permalink / raw) To: 17746 [-- Attachment #1: Type: text/plain, Size: 18998 bytes --] When I try to compose an email, either directly or by pressing 'm' in Gnus, I get the message: `recenter'ing a window that does not display current-buffer. This is using Emacs built from source on June 9th 2014, running on Mac OSX 10.9.3. The message appears to come from a change to add additional validation to src/window.c on June 6th with SHA: 0ce71d38bf295205067fd334e1993906f7fb0ba7 In GNU Emacs 24.4.50.1 (x86_64-apple-darwin10.8.0, NS apple-appkit-1038.36) of 2014-05-31 on grawpy.local Configured using: `configure --with-ns' Configured features: IMAGEMAGICK ACL GNUTLS LIBXML2 ZLIB Important settings: locale-coding-system: utf-8 Major mode: Lisp Interaction Minor modes in effect: display-time-mode: t shell-dirtrack-mode: t recentf-mode: t csv-field-index-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: ESC [ > 0 ; 9 5 ; 0 c ESC x r e p o TAB r t - e m TAB b TAB RET Recent messages: Loading /Users/davidg/.emacs.d/elpa/package.el (source)...done Source file `/Users/davidg/.emacs.d/elpa/inf-ruby-20130820.2222/inf-ruby.el' newer than byte-compiled file Source file `/Users/davidg/.emacs.d/elpa/mediawiki-1.1/mediawiki.el' newer than byte-compiled file ad-handle-definition: `w3m-search' got redefined [2 times] Package pgg-def is obsolete! Package pgg-parse is obsolete! Package pgg is obsolete! For information about GNU Emacs and the GNU system, type <f1> C-a. Making completion list... current-kill: Kill ring is empty Load-path shadows: /Users/davidg/.emacs.d/elpa/jtags-20111208.1922/jtags-extras hides /Users/davidg/.emacs.d/elpa/jtags-extras-0.3.0/jtags-extras /Users/davidg/.emacs.d/elpa/bbdb-vcard-20131216.1632/vcard hides ~/.emacs.d/vm-8.1.1/lisp/vcard /Users/davidg/.emacs.d/elpa/metaweblog-20130707.431/test-metaweblog hides ~/.emacs.d/org2blog/test-metaweblog /Users/davidg/.emacs.d/elpa/org2blog-20130707.323/org2blog hides ~/.emacs.d/org2blog/org2blog /Users/davidg/.emacs.d/elpa/org2blog-20130707.323/org2blog-pkg hides ~/.emacs.d/org2blog/org2blog-pkg /Users/davidg/.emacs.d/elpa/org2blog-20130707.323/org2blog-autoloads hides ~/.emacs.d/org2blog/org2blog-autoloads /Users/davidg/.emacs.d/elpa/metaweblog-20130707.431/metaweblog hides ~/.emacs.d/org2blog/metaweblog /Users/davidg/.emacs.d/elpa/rvm-20140109.319/rvm hides ~/.emacs.d/lisp/rvm /Users/davidg/.emacs.d/elpa/org-20140310/ox hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox /Users/davidg/.emacs.d/elpa/org-20140310/ox-texinfo hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-texinfo /Users/davidg/.emacs.d/elpa/org-20140310/ox-publish hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-publish /Users/davidg/.emacs.d/elpa/org-20140310/ox-org hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-org /Users/davidg/.emacs.d/elpa/org-20140310/ox-odt hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-odt /Users/davidg/.emacs.d/elpa/org-20140310/ox-md hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-md /Users/davidg/.emacs.d/elpa/org-20140310/ox-man hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-man /Users/davidg/.emacs.d/elpa/org-20140310/ox-latex hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-latex /Users/davidg/.emacs.d/elpa/org-20140310/ox-icalendar hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-icalendar /Users/davidg/.emacs.d/elpa/org-20140310/ox-html hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-html /Users/davidg/.emacs.d/elpa/org-20140310/ox-beamer hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-beamer /Users/davidg/.emacs.d/elpa/org-20140310/ox-ascii hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-ascii /Users/davidg/.emacs.d/elpa/org-20140310/org hides /Applications/Emacs.app/Contents/Resources/lisp/org/org /Users/davidg/.emacs.d/elpa/org-20140310/org-w3m hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-w3m /Users/davidg/.emacs.d/elpa/org-20140310/org-version hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-version /Users/davidg/.emacs.d/elpa/org-20140310/org-timer hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-timer /Users/davidg/.emacs.d/elpa/org-20140310/org-table hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-table /Users/davidg/.emacs.d/elpa/org-20140310/org-src hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-src /Users/davidg/.emacs.d/elpa/org-20140310/org-rmail hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-rmail /Users/davidg/.emacs.d/elpa/org-20140310/org-protocol hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-protocol /Users/davidg/.emacs.d/elpa/org-20140310/org-plot hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-plot /Users/davidg/.emacs.d/elpa/org-20140310/org-pcomplete hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-pcomplete /Users/davidg/.emacs.d/elpa/org-20140310/org-mouse hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-mouse /Users/davidg/.emacs.d/elpa/org-20140310/org-mobile hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-mobile /Users/davidg/.emacs.d/elpa/org-20140310/org-mhe hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-mhe /Users/davidg/.emacs.d/elpa/org-20140310/org-macs hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-macs /Users/davidg/.emacs.d/elpa/org-20140310/org-macro hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-macro /Users/davidg/.emacs.d/elpa/org-20140310/org-loaddefs hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-loaddefs /Users/davidg/.emacs.d/elpa/org-20140310/org-list hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-list /Users/davidg/.emacs.d/elpa/org-20140310/org-irc hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-irc /Users/davidg/.emacs.d/elpa/org-20140310/org-install hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-install /Users/davidg/.emacs.d/elpa/org-20140310/org-inlinetask hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-inlinetask /Users/davidg/.emacs.d/elpa/org-20140310/org-info hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-info /Users/davidg/.emacs.d/elpa/org-20140310/org-indent hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-indent /Users/davidg/.emacs.d/elpa/org-20140310/org-id hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-id /Users/davidg/.emacs.d/elpa/org-20140310/org-habit hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-habit /Users/davidg/.emacs.d/elpa/org-20140310/org-gnus hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-gnus /Users/davidg/.emacs.d/elpa/org-20140310/org-footnote hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-footnote /Users/davidg/.emacs.d/elpa/org-20140310/org-feed hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-feed /Users/davidg/.emacs.d/elpa/org-20140310/org-faces hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-faces /Users/davidg/.emacs.d/elpa/org-20140310/org-eshell hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-eshell /Users/davidg/.emacs.d/elpa/org-20140310/org-entities hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-entities /Users/davidg/.emacs.d/elpa/org-20140310/org-element hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-element /Users/davidg/.emacs.d/elpa/org-20140310/org-docview hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-docview /Users/davidg/.emacs.d/elpa/org-20140310/org-datetree hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-datetree /Users/davidg/.emacs.d/elpa/org-20140310/org-ctags hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-ctags /Users/davidg/.emacs.d/elpa/org-20140310/org-crypt hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-crypt /Users/davidg/.emacs.d/elpa/org-20140310/org-compat hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-compat /Users/davidg/.emacs.d/elpa/org-20140310/org-colview hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-colview /Users/davidg/.emacs.d/elpa/org-20140310/org-clock hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-clock /Users/davidg/.emacs.d/elpa/org-20140310/org-capture hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-capture /Users/davidg/.emacs.d/elpa/org-20140310/org-bibtex hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-bibtex /Users/davidg/.emacs.d/elpa/org-20140310/org-bbdb hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-bbdb /Users/davidg/.emacs.d/elpa/org-20140310/org-attach hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-attach /Users/davidg/.emacs.d/elpa/org-20140310/org-archive hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-archive /Users/davidg/.emacs.d/elpa/org-20140310/org-agenda hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-agenda /Users/davidg/.emacs.d/elpa/org-20140310/ob hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob /Users/davidg/.emacs.d/elpa/org-20140310/ob-tangle hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-tangle /Users/davidg/.emacs.d/elpa/org-20140310/ob-table hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-table /Users/davidg/.emacs.d/elpa/org-20140310/ob-sqlite hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-sqlite /Users/davidg/.emacs.d/elpa/org-20140310/ob-sql hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-sql /Users/davidg/.emacs.d/elpa/org-20140310/ob-shen hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-shen /Users/davidg/.emacs.d/elpa/org-20140310/ob-sh hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-sh /Users/davidg/.emacs.d/elpa/org-20140310/ob-screen hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-screen /Users/davidg/.emacs.d/elpa/org-20140310/ob-scheme hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-scheme /Users/davidg/.emacs.d/elpa/org-20140310/ob-scala hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-scala /Users/davidg/.emacs.d/elpa/org-20140310/ob-sass hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-sass /Users/davidg/.emacs.d/elpa/org-20140310/ob-ruby hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-ruby /Users/davidg/.emacs.d/elpa/org-20140310/ob-ref hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-ref /Users/davidg/.emacs.d/elpa/org-20140310/ob-R hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-R /Users/davidg/.emacs.d/elpa/org-20140310/ob-python hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-python /Users/davidg/.emacs.d/elpa/org-20140310/ob-plantuml hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-plantuml /Users/davidg/.emacs.d/elpa/org-20140310/ob-picolisp hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-picolisp /Users/davidg/.emacs.d/elpa/org-20140310/ob-perl hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-perl /Users/davidg/.emacs.d/elpa/org-20140310/ob-org hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-org /Users/davidg/.emacs.d/elpa/org-20140310/ob-octave hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-octave /Users/davidg/.emacs.d/elpa/org-20140310/ob-ocaml hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-ocaml /Users/davidg/.emacs.d/elpa/org-20140310/ob-mscgen hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-mscgen /Users/davidg/.emacs.d/elpa/org-20140310/ob-maxima hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-maxima /Users/davidg/.emacs.d/elpa/org-20140310/ob-matlab hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-matlab /Users/davidg/.emacs.d/elpa/org-20140310/ob-makefile hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-makefile /Users/davidg/.emacs.d/elpa/org-20140310/ob-lob hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-lob /Users/davidg/.emacs.d/elpa/org-20140310/ob-lisp hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-lisp /Users/davidg/.emacs.d/elpa/org-20140310/ob-lilypond hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-lilypond /Users/davidg/.emacs.d/elpa/org-20140310/ob-ledger hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-ledger /Users/davidg/.emacs.d/elpa/org-20140310/ob-latex hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-latex /Users/davidg/.emacs.d/elpa/org-20140310/ob-keys hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-keys /Users/davidg/.emacs.d/elpa/org-20140310/ob-js hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-js /Users/davidg/.emacs.d/elpa/org-20140310/ob-java hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-java /Users/davidg/.emacs.d/elpa/org-20140310/ob-io hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-io /Users/davidg/.emacs.d/elpa/org-20140310/ob-haskell hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-haskell /Users/davidg/.emacs.d/elpa/org-20140310/ob-gnuplot hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-gnuplot /Users/davidg/.emacs.d/elpa/org-20140310/ob-fortran hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-fortran /Users/davidg/.emacs.d/elpa/org-20140310/ob-exp hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-exp /Users/davidg/.emacs.d/elpa/org-20140310/ob-eval hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-eval /Users/davidg/.emacs.d/elpa/org-20140310/ob-emacs-lisp hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-emacs-lisp /Users/davidg/.emacs.d/elpa/org-20140310/ob-dot hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-dot /Users/davidg/.emacs.d/elpa/org-20140310/ob-ditaa hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-ditaa /Users/davidg/.emacs.d/elpa/org-20140310/ob-css hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-css /Users/davidg/.emacs.d/elpa/org-20140310/ob-core hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-core /Users/davidg/.emacs.d/elpa/org-20140310/ob-comint hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-comint /Users/davidg/.emacs.d/elpa/org-20140310/ob-clojure hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-clojure /Users/davidg/.emacs.d/elpa/org-20140310/ob-calc hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-calc /Users/davidg/.emacs.d/elpa/org-20140310/ob-C hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-C /Users/davidg/.emacs.d/elpa/org-20140310/ob-awk hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-awk /Users/davidg/.emacs.d/elpa/org-20140310/ob-asymptote hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-asymptote Features: (shadow face-remap reftex reftex-vars flyspell ispell org-element org-rmail org-mhe org-irc org-info org-gnus org-docview org-bibtex bibtex org-bbdb org-w3m mail-extr emacsbug xterm bbdb-message bbdb bbdb-site time ido w3m-search w3m browse-url doc-view jka-compr image-mode timezone w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util mediawiki mm-url url-http url-auth url-gw alert-autoloads android-mode-autoloads asciidoc-autoloads bbdb-csv-import-autoloads bbdb-vcard-autoloads bbdb-autoloads clippy-autoloads clojure-mode-autoloads dash-autoloads framemove-autoloads helm-autoloads highlight-80+-autoloads hippie-expand-slime-autoloads ido-ubiquitous-autoloads ido-vertical-mode-autoloads jabber-autoloads jtags-autoloads jtags-extras-autoloads magit-autoloads mediawiki-autoloads notmuch-autoloads metaweblog-autoloads org-autoloads pcsv-autoloads pos-tip-autoloads rhtml-mode-autoloads rinari-autoloads jump-autoloads inflections-autoloads findr-autoloads finder-inf ruby-compilation-autoloads inf-ruby-autoloads inf-ruby ruby-mode smie rvm-autoloads scala-mode2-autoloads slime-autoloads twitter-autoloads twittering-mode-autoloads w3-autoloads w3m-autoloads info xml-rpc-autoloads yaml-mode-autoloads package tramp-cache tramp-sh tramp tramp-compat tramp-loaddefs trampver shell recentf tree-widget pop3 ob-ditaa folding-isearch folding vm-autoloads vm-vars vm-version smtpmail sendmail tidy compile edit-server minimap org2blog-autoloads psgml-other sgml-mode psgml template csv-mode sort calfw-ical url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source eieio eieio-core password-cache url-vars mailcap icalendar diary-lib diary-loaddefs calfw-org org-agenda org byte-opt bytecomp byte-compile cconv org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint comint ansi-color ring ob-core ob-eval org-compat org-macs org-loaddefs find-func calfw holidays hol-loaddefs cal-menu calendar cal-loaddefs ps-ccrypt pomodoro rvm markdown-mode cl-macs cl gv thingatpt noutline outline easy-mmode wikipedia-mode derived edmacro kmacro nnir gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source tls utf7 netrc parse-time gnus-spec gnus-int gnus-range message dired format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus gnus-ems wid-edit cl-loaddefs cl-lib nnoo nnheader gnus-util mm-util mail-prsvr mail-utils pgg pgg-parse time-date pgg-def advice help-fns tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) Memory information: ((conses 16 418748 12573) (symbols 48 47014 4) (miscs 40 80 135) (strings 32 128512 14894) (string-bytes 1 4114666) (vectors 16 34186) (vector-slots 8 633560 2636) (floats 8 342 388) (intervals 56 339 0) (buffers 960 13)) [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 486 bytes --] ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-10 9:42 bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message David Griffiths @ 2014-06-10 17:40 ` Eli Zaretskii 2014-06-11 15:09 ` David Griffiths 2014-06-10 20:40 ` Stefan Monnier 1 sibling, 1 reply; 25+ messages in thread From: Eli Zaretskii @ 2014-06-10 17:40 UTC (permalink / raw) To: David Griffiths; +Cc: 17746 > From: David Griffiths <dogriffiths@gmail.com> > Date: Tue, 10 Jun 2014 10:42:13 +0100 > > When I try to compose an email, either directly or by pressing 'm' in > Gnus, I get the message: > > `recenter'ing a window that does not display current-buffer. Set debug-on-error to t and show us a backtrace, please. Thanks. ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-10 17:40 ` Eli Zaretskii @ 2014-06-11 15:09 ` David Griffiths 2014-06-11 15:33 ` Nicolas Richard 0 siblings, 1 reply; 25+ messages in thread From: David Griffiths @ 2014-06-11 15:09 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 17746 [-- Attachment #1: Type: text/plain, Size: 1344 bytes --] Here’s the stack trace after setting debug-on-error true and creating a message with compose-mail: Debugger entered--Lisp error: (error "`recenter'ing a window that does not display current-buffer.") recenter((4)) org-overview() org-set-startup-visibility() org-mode() set-buffer-major-mode(#<buffer *unsent mail*<2>>) window-normalize-buffer-to-switch-to("*unsent mail*<2>") pop-to-buffer("*unsent mail*<2>" (display-buffer-same-window (inhibit-same-window)) nil) pop-to-buffer-same-window("*unsent mail*<2>") message-pop-to-buffer("*unsent mail*<2>" nil) message-mail(nil nil nil nil nil nil nil nil) compose-mail(nil nil nil nil) funcall-interactively(compose-mail nil nil nil nil) call-interactively(compose-mail nil nil) command-execute(compose-mail) I have org-mode as my default major-mode which, looking at the stack trace, may be significant. DG On Tue, Jun 10, 2014 at 6:40 PM, Eli Zaretskii <eliz@gnu.org> wrote: > > From: David Griffiths <dogriffiths@gmail.com> > > Date: Tue, 10 Jun 2014 10:42:13 +0100 > > > > When I try to compose an email, either directly or by pressing 'm' in > > Gnus, I get the message: > > > > `recenter'ing a window that does not display current-buffer. > > Set debug-on-error to t and show us a backtrace, please. > > Thanks. > [-- Attachment #2: Type: text/html, Size: 2047 bytes --] ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-11 15:09 ` David Griffiths @ 2014-06-11 15:33 ` Nicolas Richard 2014-06-11 15:50 ` Bastien 0 siblings, 1 reply; 25+ messages in thread From: Nicolas Richard @ 2014-06-11 15:33 UTC (permalink / raw) To: David Griffiths; +Cc: 17746 David Griffiths <dogriffiths@gmail.com> writes: > Debugger entered--Lisp error: (error "`recenter'ing a window that does > not display current-buffer.") > recenter((4)) > org-overview() So that's a duplicate of #17724. It is fixed in org-mode (upstream) master branch. The easy fix is to use emacs-24 branch :) (otherwise just remove that call to recenter in org-overview). -- Nico. ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-11 15:33 ` Nicolas Richard @ 2014-06-11 15:50 ` Bastien 2014-06-11 16:09 ` Nicolas Richard ` (4 more replies) 0 siblings, 5 replies; 25+ messages in thread From: Bastien @ 2014-06-11 15:50 UTC (permalink / raw) To: Nicolas Richard; +Cc: 17746, David Griffiths Nicolas Richard <theonewiththeevillook@yahoo.fr> writes: > David Griffiths <dogriffiths@gmail.com> writes: >> Debugger entered--Lisp error: (error "`recenter'ing a window that does >> not display current-buffer.") >> recenter((4)) >> org-overview() > > So that's a duplicate of #17724. It is fixed in org-mode (upstream) master > branch. The easy fix is to use emacs-24 branch :) > > (otherwise just remove that call to recenter in org-overview). PS: The change about throwing an error when recentering a window that does not display the current buffer breaks ~37 tests in Org master branch, even with this fix. I need to digg this further. -- Bastien ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-11 15:50 ` Bastien @ 2014-06-11 16:09 ` Nicolas Richard [not found] ` <87zjhjxwaf.fsf@geodiff-mac3.ulb.ac.be> ` (3 subsequent siblings) 4 siblings, 0 replies; 25+ messages in thread From: Nicolas Richard @ 2014-06-11 16:09 UTC (permalink / raw) To: Bastien; +Cc: Nicolas Richard, 17746, David Griffiths Bastien <bzg@altern.org> writes: > PS: The change about throwing an error when recentering a window > that does not display the current buffer breaks ~37 tests in Org > master branch, even with this fix. I need to digg this further. For me, fixing also org-fix-ellipsis-at-bol made all tests run as expected. -- Nico. ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <87zjhjxwaf.fsf@geodiff-mac3.ulb.ac.be>]
* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message [not found] ` <87zjhjxwaf.fsf@geodiff-mac3.ulb.ac.be> @ 2014-06-11 16:25 ` Bastien [not found] ` <878up3xvje.fsf@bzg.ath.cx> 1 sibling, 0 replies; 25+ messages in thread From: Bastien @ 2014-06-11 16:25 UTC (permalink / raw) To: Nicolas Richard; +Cc: 17746, David Griffiths Nicolas Richard <theonewiththeevillook@yahoo.fr> writes: > Bastien <bzg@altern.org> writes: >> PS: The change about throwing an error when recentering a window >> that does not display the current buffer breaks ~37 tests in Org >> master branch, even with this fix. I need to digg this further. > > For me, fixing also org-fix-ellipsis-at-bol made all tests run as > expected. What do you mean by "fixing"? Removing it entirely? -- Bastien ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <878up3xvje.fsf@bzg.ath.cx>]
* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message [not found] ` <878up3xvje.fsf@bzg.ath.cx> @ 2014-06-11 19:11 ` Nicolas Richard 0 siblings, 0 replies; 25+ messages in thread From: Nicolas Richard @ 2014-06-11 19:11 UTC (permalink / raw) To: Bastien; +Cc: Nicolas Richard, 17746, David Griffiths Bastien <bzg@altern.org> writes: > Nicolas Richard <theonewiththeevillook@yahoo.fr> writes: > >> Bastien <bzg@altern.org> writes: >>> PS: The change about throwing an error when recentering a window >>> that does not display the current buffer breaks ~37 tests in Org >>> master branch, even with this fix. I need to digg this further. >> >> For me, fixing also org-fix-ellipsis-at-bol made all tests run as >> expected. > > What do you mean by "fixing"? Removing it entirely? Yes, I admit, I did : (defsubst org-fix-ellipsis-at-bol () nil) But I must have done something wrong or misread the results because now I see some other failures. Moreover, the backtrace that I get from "make test" seems incomplete and it's not obvious to me where the recenter call is made. OTOH I hope that wrapping every call to recenter in a (when (eq (current-buffer) (window-buffer)) (recenter ...)) would fix the tests, no ? -- Nico. ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-11 15:50 ` Bastien 2014-06-11 16:09 ` Nicolas Richard [not found] ` <87zjhjxwaf.fsf@geodiff-mac3.ulb.ac.be> @ 2014-06-11 16:29 ` Eli Zaretskii [not found] ` <837g4nz9xc.fsf@gnu.org> 2014-06-12 1:15 ` bug#17746: [O] " Daimrod 4 siblings, 0 replies; 25+ messages in thread From: Eli Zaretskii @ 2014-06-11 16:29 UTC (permalink / raw) To: Bastien; +Cc: theonewiththeevillook, 17746, dogriffiths > From: Bastien <bzg@altern.org> > Date: Wed, 11 Jun 2014 17:50:02 +0200 > Cc: 17746@debbugs.gnu.org, David Griffiths <dogriffiths@gmail.com> > > PS: The change about throwing an error when recentering a window > that does not display the current buffer breaks ~37 tests in Org > master branch, even with this fix. I need to digg this further. Say thanks to Stefan for flagging all those bugs ;-) ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <837g4nz9xc.fsf@gnu.org>]
* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message [not found] ` <837g4nz9xc.fsf@gnu.org> @ 2014-06-11 18:15 ` Stefan Monnier [not found] ` <jwvha3rco0u.fsf-monnier+emacsbugs@gnu.org> 1 sibling, 0 replies; 25+ messages in thread From: Stefan Monnier @ 2014-06-11 18:15 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Bastien, theonewiththeevillook, 17746, dogriffiths > Say thanks to Stefan for flagging all those bugs ;-) Now that I think about it, I should make `car' signal an error every 100th call, as well. Would flag many bugs (with some false positives, of course, but what's a few false positives among friends?)! Stefan ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <jwvha3rco0u.fsf-monnier+emacsbugs@gnu.org>]
* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message [not found] ` <jwvha3rco0u.fsf-monnier+emacsbugs@gnu.org> @ 2014-06-11 18:38 ` Eli Zaretskii 0 siblings, 0 replies; 25+ messages in thread From: Eli Zaretskii @ 2014-06-11 18:38 UTC (permalink / raw) To: Stefan Monnier; +Cc: bzg, theonewiththeevillook, 17746, dogriffiths > From: Stefan Monnier <monnier@iro.umontreal.ca> > Cc: Bastien <bzg@altern.org>, theonewiththeevillook@yahoo.fr, > 17746@debbugs.gnu.org, dogriffiths@gmail.com > Date: Wed, 11 Jun 2014 14:15:08 -0400 > > > Say thanks to Stefan for flagging all those bugs ;-) > > Now that I think about it, I should make `car' signal an error every > 100th call, as well. Would flag many bugs (with some false positives, > of course, but what's a few false positives among friends?)! Not just 'car', 'cdr' as well, I'd say. ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: [O] bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-11 15:50 ` Bastien ` (3 preceding siblings ...) [not found] ` <837g4nz9xc.fsf@gnu.org> @ 2014-06-12 1:15 ` Daimrod 2014-06-12 2:44 ` Stefan Monnier ` (2 more replies) 4 siblings, 3 replies; 25+ messages in thread From: Daimrod @ 2014-06-12 1:15 UTC (permalink / raw) To: Bastien; +Cc: Nicolas Richard, 17746, David Griffiths [-- Attachment #1: Type: text/plain, Size: 837 bytes --] Bastien <bzg@altern.org> writes: > Nicolas Richard <theonewiththeevillook@yahoo.fr> writes: > >> David Griffiths <dogriffiths@gmail.com> writes: >>> Debugger entered--Lisp error: (error "`recenter'ing a window that does >>> not display current-buffer.") >>> recenter((4)) >>> org-overview() >> >> So that's a duplicate of #17724. It is fixed in org-mode (upstream) master >> branch. The easy fix is to use emacs-24 branch :) >> >> (otherwise just remove that call to recenter in org-overview). > > PS: The change about throwing an error when recentering a window > that does not display the current buffer breaks ~37 tests in Org > master branch, even with this fix. I need to digg this further. Err, what's the rational behind this change? In the meantime I've a simple fix (quickly tested for `org-agenda' which was also broken). [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-Use-org-recenter-as-a-wrapper-around-recenter.patch --] [-- Type: text/x-diff, Size: 9699 bytes --] From 659bc5072253967ee2737f668c8ac035a4b8aa32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= <gregoire.jadi@gmail.com> Date: Thu, 12 Jun 2014 10:14:16 +0900 Subject: [PATCH] Use `org-recenter' as a wrapper around `recenter' * lisp/org.el (org-recenter): New function that behaves exactly like `recenter' except that it sets the `current-buffer' to the buffer displayed by the selected window. (org-fix-ellipsis-at-bol) (org-optimize-window-after-visibility-change) (org-first-headline-recenter) * contrib/lisp/org-index.el (org-index) (org-index--create-new-index) (org-index--do-head) * contrib/lisp/org-toc.el (org-toc-goto) * lisp/org-agenda.el (org-agenda-list) (org-agenda-redo) (org-recenter-heading) (org-agenda-recenter) * lisp/org-bibtex.el (org-execute-file-search-in-bibtex) * lisp/org-clock.el (org-clock-goto) * lisp/org-table.el (org-table-show-reference): Use `org-recenter' instead of `recenter'. --- contrib/lisp/org-index.el | 12 ++++++------ contrib/lisp/org-toc.el | 4 ++-- lisp/org-agenda.el | 12 ++++++------ lisp/org-bibtex.el | 2 +- lisp/org-clock.el | 2 +- lisp/org-table.el | 4 ++-- lisp/org.el | 13 +++++++++---- 7 files changed, 27 insertions(+), 22 deletions(-) diff --git a/contrib/lisp/org-index.el b/contrib/lisp/org-index.el index 64974eb..f77d64d 100644 --- a/contrib/lisp/org-index.el +++ b/contrib/lisp/org-index.el @@ -633,7 +633,7 @@ command \"head\" for reference \"237\". ;; simply go into table (goto-char org-index--below-hline) (show-subtree) - (recenter) + (org-recenter) (if what-adjusted (setq message-text "Nothing to search for; at index table") (setq message-text "At index table"))) @@ -1581,7 +1581,7 @@ retrieves the value of the count-column for reference 12. (org-id-goto id) (org-show-context) (show-subtree) - (recenter 1) + (org-recenter 1) (setq org-index-id id) (if (y-or-n-p "This is your new index table. It is already set for this emacs session. Do you want to save its id to make it available for future emacs sessions too ? ") (progn @@ -1598,7 +1598,7 @@ retrieves the value of the count-column for reference 12. (goto-char org-index--point) (org-show-context) (show-subtree) - (recenter 1) + (org-recenter 1) (delete-other-windows) ;; show new index (select-window (split-window-vertically)) @@ -1606,7 +1606,7 @@ retrieves the value of the count-column for reference 12. (org-id-goto id) (org-show-context) (show-subtree) - (recenter 1) + (org-recenter 1) (error "Please compare your existing index (upper window) and a temporary new one (lower window) to correct the previous error (\"%s\"); the explanations following the new index table should help." reason))))) @@ -1778,12 +1778,12 @@ retrieves the value of the count-column for reference 12. (pop-to-buffer buffer) (goto-char point) (org-reveal t) - (recenter) + (org-recenter) (pop-to-buffer "*org-index-occur*")) (org-pop-to-buffer-same-window buffer) (goto-char point) (org-reveal t) - (recenter))) + (org-recenter))) (setq message-text (format "Did not find '%s'" (or ref link)))))) message-text)) diff --git a/contrib/lisp/org-toc.el b/contrib/lisp/org-toc.el index 255b79e..e06de55 100644 --- a/contrib/lisp/org-toc.el +++ b/contrib/lisp/org-toc.el @@ -294,8 +294,8 @@ If CYCLE is non-nil, cycle the targeted subtree in the Org window." (org-show-entry)) (org-show-context))) (if org-toc-recenter-mode - (if (>= org-toc-recenter 1000) (recenter) - (recenter org-toc-recenter))) + (if (>= org-toc-recenter 1000) (org-recenter) + (org-recenter org-toc-recenter))) (cond ((null jump) (switch-to-buffer-other-window toc-buf)) ((eq jump 'delete) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 5e056b4..02c583b 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -4348,11 +4348,11 @@ items if they have an hour specification like [h]h:mm." (unless (and (pos-visible-in-window-p (point-min)) (pos-visible-in-window-p (point-max))) (goto-char (1- (point-max))) - (recenter -1) + (org-recenter -1) (if (not (pos-visible-in-window-p (or start-pos 1))) (progn (goto-char (or start-pos 1)) - (recenter 1)))) + (org-recenter 1)))) (goto-char (or start-pos 1)) (add-text-properties (point-min) (point-max) `(org-agenda-type agenda @@ -7329,7 +7329,7 @@ in the agenda." (and top-hl-filter (org-agenda-filter-top-headline-apply top-hl-filter)) (and cols (org-called-interactively-p 'any) (org-agenda-columns)) (org-goto-line line) - (recenter window-line))) + (org-recenter window-line))) (defvar org-global-tags-completion-table nil) (defvar org-agenda-filter-form nil) @@ -8373,7 +8373,7 @@ When called with a prefix argument, include all archive files as well." (org-flag-heading nil)))) ; show the next heading (when (outline-invisible-p) (show-entry)) ; display invisible text - (recenter (/ (window-height) 2)) + (org-recenter (/ (window-height) 2)) (org-back-to-heading t) (if (re-search-forward org-complex-heading-regexp nil t) (goto-char (match-beginning 4))) @@ -8697,7 +8697,7 @@ if it was hidden in the outline." (defun org-recenter-heading (n) (save-excursion (org-back-to-heading) - (recenter n))) + (org-recenter n))) (defvar org-agenda-cycle-counter nil) (defun org-agenda-cycle-show (&optional n) @@ -8728,7 +8728,7 @@ docstring of `org-agenda-show-1'." (interactive "P") (let ((win (selected-window))) (org-agenda-goto t) - (recenter arg) + (org-recenter arg) (select-window win))) (defun org-agenda-show-mouse (ev) diff --git a/lisp/org-bibtex.el b/lisp/org-bibtex.el index 3efee73..8bcd04e 100644 --- a/lisp/org-bibtex.el +++ b/lisp/org-bibtex.el @@ -540,7 +540,7 @@ With optional argument OPTIONAL, also prompt for optional fields." (with-current-buffer b (goto-char p) (bibtex-url))) - (recenter 0)) ; Move entry start to beginning of window + (org-recenter 0)) ; Move entry start to beginning of window ;; return t to indicate that the search is done. t)) diff --git a/lisp/org-clock.el b/lisp/org-clock.el index 3c7abd5..9323bd5 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -1702,7 +1702,7 @@ With prefix arg SELECT, offer recently clocked tasks for selection." (org-show-entry) (org-back-to-heading t) (org-cycle-hide-drawers 'children) - (recenter org-clock-goto-before-context) + (org-recenter org-clock-goto-before-context) (org-reveal) (if recent (message "No running clock, this is the most recently clocked task")) diff --git a/lisp/org-table.el b/lisp/org-table.el index 8cd8f8b..8c9e667 100644 --- a/lisp/org-table.el +++ b/lisp/org-table.el @@ -3935,9 +3935,9 @@ With prefix ARG, apply the new formulas to the table." (push org-table-current-begin-pos org-show-positions) (let ((min (apply 'min org-show-positions)) (max (apply 'max org-show-positions))) - (goto-char min) (recenter 0) + (goto-char min) (org-recenter 0) (goto-char max) - (or (pos-visible-in-window-p max) (recenter -1)))) + (or (pos-visible-in-window-p max) (org-recenter -1)))) (select-window win)))) (defun org-table-force-dataline () diff --git a/lisp/org.el b/lisp/org.el index 874440b..b9a81b9 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -5575,7 +5575,7 @@ The following commands are available: :parents (list text-mode-abbrev-table))) (defsubst org-fix-ellipsis-at-bol () - (save-excursion (goto-char (window-start)) (recenter 0))) + (save-excursion (goto-char (window-start)) (org-recenter 0))) (defun org-find-invisible-foreground () (let ((candidates (remove @@ -7059,8 +7059,8 @@ This function is the default value of the hook `org-cycle-hook'." ((eq state 'content) nil) ((eq state 'all) nil) ((eq state 'folded) nil) - ((eq state 'children) (or (org-subtree-end-visible-p) (recenter 1))) - ((eq state 'subtree) (or (org-subtree-end-visible-p) (recenter 1)))))) + ((eq state 'children) (or (org-subtree-end-visible-p) (org-recenter 1))) + ((eq state 'subtree) (or (org-subtree-end-visible-p) (org-recenter 1)))))) (defun org-remove-empty-overlays-at (pos) "Remove outline overlays that do not contain non-white stuff." @@ -7251,7 +7251,7 @@ Optional argument N means put the headline into the Nth line of the window." (goto-char (point-min)) (when (re-search-forward (concat "^\\(" org-outline-regexp "\\)") nil t) (beginning-of-line) - (recenter (prefix-numeric-value N)))) + (org-recenter (prefix-numeric-value N)))) ;;; Saving and restoring visibility @@ -23324,6 +23324,11 @@ package ox-bibtex by Taru Karttunen." (call-interactively 'reftex-citation))) ;;;; Functions extending outline functionality +(defun org-recenter (&optional arg) + "Like `recenter' but ensure that the `current-buffer' is +properly set." + (with-current-buffer (window-buffer) + (recenter arg))) (defun org-beginning-of-line (&optional arg) "Go to the beginning of the current line. If that is invisible, continue -- 1.8.0.2722.gc0242e5 [-- Attachment #3: Type: text/plain, Size: 18 bytes --] -- Daimrod/Greg ^ permalink raw reply related [flat|nested] 25+ messages in thread
* bug#17746: [O] bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-12 1:15 ` bug#17746: [O] " Daimrod @ 2014-06-12 2:44 ` Stefan Monnier [not found] ` <jwva99ic0f9.fsf-monnier+emacsbugs@gnu.org> 2014-06-12 8:16 ` Nicolas Richard 2 siblings, 0 replies; 25+ messages in thread From: Stefan Monnier @ 2014-06-12 2:44 UTC (permalink / raw) To: Daimrod; +Cc: Bastien, Nicolas Richard, 17746, David Griffiths > +(defun org-recenter (&optional arg) > + "Like `recenter' but ensure that the `current-buffer' is > +properly set." > + (with-current-buffer (window-buffer) > + (recenter arg))) This doesn't make much sense: in many case (window-buffer) can be a buffer completely unrelated to Org. Stefan ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <jwva99ic0f9.fsf-monnier+emacsbugs@gnu.org>]
* bug#17746: [O] bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message [not found] ` <jwva99ic0f9.fsf-monnier+emacsbugs@gnu.org> @ 2014-06-12 4:10 ` Daimrod 0 siblings, 0 replies; 25+ messages in thread From: Daimrod @ 2014-06-12 4:10 UTC (permalink / raw) To: Stefan Monnier; +Cc: Bastien, Nicolas Richard, 17746, David Griffiths Stefan Monnier <monnier@iro.umontreal.ca> writes: >> +(defun org-recenter (&optional arg) >> + "Like `recenter' but ensure that the `current-buffer' is >> +properly set." >> + (with-current-buffer (window-buffer) >> + (recenter arg))) > > This doesn't make much sense: in many case (window-buffer) can be > a buffer completely unrelated to Org. Hmm, what was the previous behaviour of `recenter'? (i.e. before it reports an error) Did it just do nothing? Best, -- Daimrod/Greg ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: [O] bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-12 1:15 ` bug#17746: [O] " Daimrod 2014-06-12 2:44 ` Stefan Monnier [not found] ` <jwva99ic0f9.fsf-monnier+emacsbugs@gnu.org> @ 2014-06-12 8:16 ` Nicolas Richard 2014-06-12 8:58 ` Daimrod 2 siblings, 1 reply; 25+ messages in thread From: Nicolas Richard @ 2014-06-12 8:16 UTC (permalink / raw) To: Daimrod; +Cc: Bastien, Nicolas Richard, 17746, David Griffiths Daimrod <daimrod@gmail.com> writes: >> PS: The change about throwing an error when recentering a window >> that does not display the current buffer breaks ~37 tests in Org >> master branch, even with this fix. I need to digg this further. > > Err, what's the rational behind this change? It is meant to catch cases where recenter acts on the wrong window. Think of the cases where (recenter) is called from within a timer or a process filter function. See the discussion entitled > comint-preoutput-filter-functions and flickering redisplay in TTY on emacs devel. -- Nico. ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: [O] bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-12 8:16 ` Nicolas Richard @ 2014-06-12 8:58 ` Daimrod 2014-06-12 9:27 ` Daimrod [not found] ` <874mzqeaug.fsf__22767.2755755068$1402565401$gmane$org@tanger.home> 0 siblings, 2 replies; 25+ messages in thread From: Daimrod @ 2014-06-12 8:58 UTC (permalink / raw) To: Nicolas Richard; +Cc: Bastien, 17746, David Griffiths Nicolas Richard <theonewiththeevillook@yahoo.fr> writes: > Daimrod <daimrod@gmail.com> writes: >>> PS: The change about throwing an error when recentering a window >>> that does not display the current buffer breaks ~37 tests in Org >>> master branch, even with this fix. I need to digg this further. >> >> Err, what's the rational behind this change? > > It is meant to catch cases where recenter acts on the wrong window. > Think of the cases where (recenter) is called from within a timer or a > process filter function. > > See the discussion entitled >> comint-preoutput-filter-functions and flickering redisplay in TTY > on emacs devel. Thanks! -- Daimrod/Greg ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: [O] bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-12 8:58 ` Daimrod @ 2014-06-12 9:27 ` Daimrod 2014-06-12 10:12 ` Daimrod [not found] ` <87zjhicu83.fsf__13466.7772836567$1402568031$gmane$org@tanger.home> [not found] ` <874mzqeaug.fsf__22767.2755755068$1402565401$gmane$org@tanger.home> 1 sibling, 2 replies; 25+ messages in thread From: Daimrod @ 2014-06-12 9:27 UTC (permalink / raw) To: Nicolas Richard; +Cc: Bastien, 17746, David Griffiths Daimrod <daimrod@gmail.com> writes: > Nicolas Richard <theonewiththeevillook@yahoo.fr> writes: > >> Daimrod <daimrod@gmail.com> writes: >>>> PS: The change about throwing an error when recentering a window >>>> that does not display the current buffer breaks ~37 tests in Org >>>> master branch, even with this fix. I need to digg this further. >>> >>> Err, what's the rational behind this change? >> >> It is meant to catch cases where recenter acts on the wrong window. >> Think of the cases where (recenter) is called from within a timer or a >> process filter function. >> >> See the discussion entitled >>> comint-preoutput-filter-functions and flickering redisplay in TTY >> on emacs devel. > > Thanks! Okay, so is there another fix than `(when (eq (current-buffer) (window-buffer)))' or removing the call? If not, why does it raise an error instead of doing nothing silently? Best, -- Daimrod/Greg ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: [O] bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-12 9:27 ` Daimrod @ 2014-06-12 10:12 ` Daimrod [not found] ` <87zjhicu83.fsf__13466.7772836567$1402568031$gmane$org@tanger.home> 1 sibling, 0 replies; 25+ messages in thread From: Daimrod @ 2014-06-12 10:12 UTC (permalink / raw) To: Nicolas Richard; +Cc: Bastien, 17746, David Griffiths Daimrod <daimrod@gmail.com> writes: > Daimrod <daimrod@gmail.com> writes: > >> Nicolas Richard <theonewiththeevillook@yahoo.fr> writes: >> >>> Daimrod <daimrod@gmail.com> writes: >>>>> PS: The change about throwing an error when recentering a window >>>>> that does not display the current buffer breaks ~37 tests in Org >>>>> master branch, even with this fix. I need to digg this further. >>>> >>>> Err, what's the rational behind this change? >>> >>> It is meant to catch cases where recenter acts on the wrong window. >>> Think of the cases where (recenter) is called from within a timer or a >>> process filter function. >>> >>> See the discussion entitled >>>> comint-preoutput-filter-functions and flickering redisplay in TTY >>> on emacs devel. >> >> Thanks! > > Okay, so is there another fix than `(when (eq (current-buffer) > (window-buffer)))' or removing the call? > > If not, why does it raise an error instead of doing nothing silently? I've read the fix in org-mode and I understand that it was a silly question. Please ignore it. Best, -- Daimrod/Greg ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <87zjhicu83.fsf__13466.7772836567$1402568031$gmane$org@tanger.home>]
* bug#17746: bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message [not found] ` <87zjhicu83.fsf__13466.7772836567$1402568031$gmane$org@tanger.home> @ 2014-06-12 13:04 ` Bastien 0 siblings, 0 replies; 25+ messages in thread From: Bastien @ 2014-06-12 13:04 UTC (permalink / raw) To: Daimrod; +Cc: Nicolas Richard, 17746, David Griffiths Daimrod <daimrod@gmail.com> writes: > I've read the fix in org-mode and I understand that it was a silly > question. Please ignore it. Well, the whole thread gave me the guts to dive in and to find, as often, how tiny the challenge was -- so thanks for soft-prodding! -- Bastien ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <874mzqeaug.fsf__22767.2755755068$1402565401$gmane$org@tanger.home>]
* bug#17746: bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message [not found] ` <874mzqeaug.fsf__22767.2755755068$1402565401$gmane$org@tanger.home> @ 2014-06-12 10:06 ` Bastien [not found] ` <87lht2l9vo.fsf__32258.4286136136$1402567739$gmane$org@bzg.ath.cx> 1 sibling, 0 replies; 25+ messages in thread From: Bastien @ 2014-06-12 10:06 UTC (permalink / raw) To: Daimrod; +Cc: Nicolas Richard, 17746, David Griffiths I've now fixed this in the maint and master branch of Org's repository. Firmly waiting for warnings from the CAR and CDR random checks! -- Bastien ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <87lht2l9vo.fsf__32258.4286136136$1402567739$gmane$org@bzg.ath.cx>]
* bug#17746: bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message [not found] ` <87lht2l9vo.fsf__32258.4286136136$1402567739$gmane$org@bzg.ath.cx> @ 2014-06-13 12:58 ` Nicolas Richard [not found] ` <87ioo56k5h.fsf@geodiff-mac3.ulb.ac.be> 1 sibling, 0 replies; 25+ messages in thread From: Nicolas Richard @ 2014-06-13 12:58 UTC (permalink / raw) To: Bastien; +Cc: Nicolas Richard, 17746, David Griffiths Bastien <bzg@gnu.org> writes: > I've now fixed this in the maint and master branch of Org's > repository. Thanks for looking into it. Perhaps this isn't the right place to ask, but I wonder how (save-excursion (set-window-start (selected-window) (window-start))) isn't a noop. -- Nico. ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <87ioo56k5h.fsf@geodiff-mac3.ulb.ac.be>]
* bug#17746: bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message [not found] ` <87ioo56k5h.fsf@geodiff-mac3.ulb.ac.be> @ 2014-06-13 15:29 ` Bastien 2014-06-14 3:28 ` Daimrod 0 siblings, 1 reply; 25+ messages in thread From: Bastien @ 2014-06-13 15:29 UTC (permalink / raw) To: Nicolas Richard; +Cc: 17746, David Griffiths Nicolas Richard <theonewiththeevillook@yahoo.fr> writes: > Perhaps this isn't the right place to ask, but I wonder how > (save-excursion (set-window-start (selected-window) (window-start))) > isn't a noop. Perhaps it is a noop -- The purpose of `org-fix-ellipsis-at-bol' is to remove the ellipsis overlay that outline-mode may leave when navigating through folded regions. At least this was the purpose of the original version, and using recenter did the job. I'll try to reproduce the original bug, see if the new version of `org-fix-ellipsis-at-bol' does the job and if not, why. -- Bastien ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-13 15:29 ` Bastien @ 2014-06-14 3:28 ` Daimrod 2014-06-14 6:46 ` Bastien 0 siblings, 1 reply; 25+ messages in thread From: Daimrod @ 2014-06-14 3:28 UTC (permalink / raw) To: Bastien; +Cc: Nicolas Richard, 17746, David Griffiths Bastien <bzg@gnu.org> writes: > Nicolas Richard <theonewiththeevillook@yahoo.fr> writes: > >> Perhaps this isn't the right place to ask, but I wonder how >> (save-excursion (set-window-start (selected-window) (window-start))) >> isn't a noop. > > Perhaps it is a noop -- The purpose of `org-fix-ellipsis-at-bol' > is to remove the ellipsis overlay that outline-mode may leave > when navigating through folded regions. At least this was the > purpose of the original version, and using recenter did the > job. I'll try to reproduce the original bug, see if the new > version of `org-fix-ellipsis-at-bol' does the job and if not, > why. In `org-fix-ellipsis-at-bol', the change wasn't : (save-excursion (set-window-start (selected-window) (window-start))) but : (save-excursion (set-window-start (selected-window) (point-min))) which is not a noop. But it does the wrong thing with isearch. When isearch is done, that is, when it has found a match and we leave isearch with RET for example. Then it calls `isearch-done' which runs `org-fix-ellipsis-at-bol' because it is in `isearch-mode-end-hook' (I didn't look to find why). Because of this, if the pattern found isn't at the top of the buffer, then the point won't be at the pattern, but at the top of the buffer. Best, -- Daimrod/Greg ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-14 3:28 ` Daimrod @ 2014-06-14 6:46 ` Bastien 0 siblings, 0 replies; 25+ messages in thread From: Bastien @ 2014-06-14 6:46 UTC (permalink / raw) To: Daimrod; +Cc: Nicolas Richard, 17746, David Griffiths Daimrod <daimrod@gmail.com> writes: > In `org-fix-ellipsis-at-bol', the change wasn't > : (save-excursion (set-window-start (selected-window) (window-start))) > > but > : (save-excursion (set-window-start (selected-window) (point-min))) > > which is not a noop. > > But it does the wrong thing with isearch. Yes, it was a silly mistake of mine. > When isearch is done, that is, when it has found a match and we leave > isearch with RET for example. Then it calls `isearch-done' which runs > `org-fix-ellipsis-at-bol' because it is in `isearch-mode-end-hook' (I > didn't look to find why). The bug `org-fix-ellipsis-at-bol' is supposed to fix is this one: sometimes when searching for a string and hitting RET, the beginning of the buffer is hidden and there is a confusing "..." at the top of the window. With the previous version (using `recenter'), those ellipsis were removed by recentering. My bold and kinda superstitious hope was that `set-window-start' would have the same effect, but I need to double-check this. At least we don't have the warning. -- Bastien ^ permalink raw reply [flat|nested] 25+ messages in thread
* bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message 2014-06-10 9:42 bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message David Griffiths 2014-06-10 17:40 ` Eli Zaretskii @ 2014-06-10 20:40 ` Stefan Monnier 1 sibling, 0 replies; 25+ messages in thread From: Stefan Monnier @ 2014-06-10 20:40 UTC (permalink / raw) To: David Griffiths; +Cc: 17746 > This is using Emacs built from source on June 9th 2014, running on Mac > OSX 10.9.3. The message appears to come from a change to add additional > validation to src/window.c on June 6th with SHA: If you're not actively working on Emacs's code, I'd appreciate if you could use the `emacs-24' branch rather than the `trunk', so as to help us debug the upcoming 24.4 release. Stefan ^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2014-06-14 6:46 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-10 9:42 bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message David Griffiths
2014-06-10 17:40 ` Eli Zaretskii
2014-06-11 15:09 ` David Griffiths
2014-06-11 15:33 ` Nicolas Richard
2014-06-11 15:50 ` Bastien
2014-06-11 16:09 ` Nicolas Richard
[not found] ` <87zjhjxwaf.fsf@geodiff-mac3.ulb.ac.be>
2014-06-11 16:25 ` Bastien
[not found] ` <878up3xvje.fsf@bzg.ath.cx>
2014-06-11 19:11 ` Nicolas Richard
2014-06-11 16:29 ` Eli Zaretskii
[not found] ` <837g4nz9xc.fsf@gnu.org>
2014-06-11 18:15 ` Stefan Monnier
[not found] ` <jwvha3rco0u.fsf-monnier+emacsbugs@gnu.org>
2014-06-11 18:38 ` Eli Zaretskii
2014-06-12 1:15 ` bug#17746: [O] " Daimrod
2014-06-12 2:44 ` Stefan Monnier
[not found] ` <jwva99ic0f9.fsf-monnier+emacsbugs@gnu.org>
2014-06-12 4:10 ` Daimrod
2014-06-12 8:16 ` Nicolas Richard
2014-06-12 8:58 ` Daimrod
2014-06-12 9:27 ` Daimrod
2014-06-12 10:12 ` Daimrod
[not found] ` <87zjhicu83.fsf__13466.7772836567$1402568031$gmane$org@tanger.home>
2014-06-12 13:04 ` bug#17746: " Bastien
[not found] ` <874mzqeaug.fsf__22767.2755755068$1402565401$gmane$org@tanger.home>
2014-06-12 10:06 ` Bastien
[not found] ` <87lht2l9vo.fsf__32258.4286136136$1402567739$gmane$org@bzg.ath.cx>
2014-06-13 12:58 ` Nicolas Richard
[not found] ` <87ioo56k5h.fsf@geodiff-mac3.ulb.ac.be>
2014-06-13 15:29 ` Bastien
2014-06-14 3:28 ` Daimrod
2014-06-14 6:46 ` Bastien
2014-06-10 20:40 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).