unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Johan Bockgård" <bojohan@gnu.org>
To: 21535@debbugs.gnu.org
Subject: bug#21535: 25.0.50; vc-follow-symlinks=ask is ineffective for directory links
Date: Tue, 22 Sep 2015 22:00:44 +0200	[thread overview]
Message-ID: <87zj0e9qc3.fsf@gnu.org> (raw)


When `vc-follow-symlinks' is `ask' (the default) Emacs follows links for
files under version control, but fails to ask before doing so when any
parent directory is a symlink.

E.g.
/x/y/link  (asks)
/x/link/z  (doesn't ask)

The following commit changed two occurrences of `file-chase-links' to
`buffer-file-truename' in vc-hooks.el. A third occurrence of
file-chase-links was left alone however, which fools the querying logic
for files where the directory part of the name contains symlinks.


commit 33f95a82e97cac000a98dc5b1100ad7a095e12d3
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Sat Nov 22 05:23:42 2008 +0000

    (vc-follow-link, vc-find-file-hook):
    Use buffer-file-truename to handle symlinks in any part of the filename.





             reply	other threads:[~2015-09-22 20:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 20:00 Johan Bockgård [this message]
2020-12-03 11:01 ` bug#21535: 25.0.50; vc-follow-symlinks=ask is ineffective for directory links Lars Ingebrigtsen
2020-12-06 22:55   ` Glenn Morris
2020-12-07 14:57     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj0e9qc3.fsf@gnu.org \
    --to=bojohan@gnu.org \
    --cc=21535@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).