unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Alex Dunn <dunn.alex@gmail.com>
Cc: 22046@debbugs.gnu.org
Subject: bug#22046: [PATCH] Improve version-to-list parsing
Date: Mon, 30 Nov 2015 08:59:04 +0100	[thread overview]
Message-ID: <87zixvlxyv.fsf@igel.home> (raw)
In-Reply-To: <m2egf83zx1.fsf@snow.i-did-not-set--mail-host-address--so-tickle-me> (Alex Dunn's message of "Sun, 29 Nov 2015 19:54:18 -0800")

Alex Dunn <dunn.alex@gmail.com> writes:

> diff --git a/lisp/subr.el b/lisp/subr.el
> index 74d6aa1..dd3bac6 100644
> --- a/lisp/subr.el
> +++ b/lisp/subr.el
> @@ -4686,14 +4686,14 @@ version-separator
>  
>  
>  (defconst version-regexp-alist
> -  '(("^[-\._+ ]?snapshot$"                                 . -4)
> +  '(("^[-\._+ ]?snapshot"                                 . -4)
>      ;; treat "1.2.3-20050920" and "1.2-3" as snapshot releases
> -    ("^[-\._+]$"                                           . -4)
> +    ("^[-\._+]"                                           . -4)
>      ;; treat "1.2.3-CVS" as snapshot release
> -    ("^[-\._+ ]?\\(cvs\\|git\\|bzr\\|svn\\|hg\\|darcs\\)$" . -4)
> -    ("^[-\._+ ]?alpha$"                                    . -3)
> -    ("^[-\._+ ]?beta$"                                     . -2)
> -    ("^[-\._+ ]?\\(pre\\|rc\\)$"                           . -1))
> +    ("^[-\._+ ]?\\(cvs\\|git\\|bzr\\|svn\\|hg\\|darcs\\)" . -4)
> +    ("^[-\._+ ]?alpha"                                    . -3)
> +    ("^[-\._+ ]?beta"                                     . -2)
> +    ("^[-\._+ ]?\\(pre\\|rc\\)"                           . -1))
>    "Specify association between non-numeric version and its priority.

Is that part of the doc string no longer true?

REGEXP		regexp used to match non-numeric part of a version string.
		It should begin with the `^' anchor and end with a `$' to
		prevent false hits.  Letter-case is ignored while matching
		REGEXP.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."





  reply	other threads:[~2015-11-30  7:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28 22:26 bug#22046: [PATCH] Improve version-to-list parsing Alex Dunn
2015-11-30  0:09 ` Alex Dunn
2015-11-30  3:34   ` Eli Zaretskii
2015-11-30  3:54     ` Alex Dunn
2015-11-30  7:59       ` Andreas Schwab [this message]
2015-11-30 15:50       ` Eli Zaretskii
2015-12-01  2:09         ` Alex Dunn
2015-12-01  3:38           ` Eli Zaretskii
2015-12-02  4:14             ` Alex Dunn
2015-12-05  9:36               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zixvlxyv.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=22046@debbugs.gnu.org \
    --cc=dunn.alex@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).