From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#16949: 24.3; [PATCH] insert-pair now leaves the point where the docstring says it should Date: Wed, 24 Feb 2016 13:54:47 +1100 Message-ID: <87ziuqn7go.fsf@gnus.org> References: <87ob1j4x02.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456282584 13528 80.91.229.3 (24 Feb 2016 02:56:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Feb 2016 02:56:24 +0000 (UTC) Cc: 16949@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 24 03:56:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aYPcZ-0001t0-Mm for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Feb 2016 03:56:11 +0100 Original-Received: from localhost ([::1]:33035 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYPcZ-0008C0-3t for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Feb 2016 21:56:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYPcU-0008BU-VW for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 21:56:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYPcQ-0001fS-Mm for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 21:56:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYPcQ-0001fO-JE for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 21:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aYPcQ-000236-ES for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 21:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2016 02:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16949-submit@debbugs.gnu.org id=B16949.14562825167820 (code B ref 16949); Wed, 24 Feb 2016 02:56:02 +0000 Original-Received: (at 16949) by debbugs.gnu.org; 24 Feb 2016 02:55:16 +0000 Original-Received: from localhost ([127.0.0.1]:41963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYPbg-000222-7W for submit@debbugs.gnu.org; Tue, 23 Feb 2016 21:55:16 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:54326) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYPbe-00021t-Sc for 16949@debbugs.gnu.org; Tue, 23 Feb 2016 21:55:15 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYPbH-0006DM-Pl; Wed, 24 Feb 2016 03:54:52 +0100 In-Reply-To: <87ob1j4x02.fsf@secretsauce.net> (Dima Kogan's message of "Wed, 05 Mar 2014 23:17:01 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aYPbH-0006DM-Pl MailScanner-NULL-Check: 1456887292.92528@p1kflPSvI/TmU4lbe+HT1g X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113635 Archived-At: Dima Kogan writes: > The docstring of insert-pair states that after insertion, the point ends > up after the opening character. This was not true if the pair was > inserted to surround a region. This small patch fixes it. > >>>From 5ae4b68706e4a1c8daa0bb91602a62911c29a9a8 Mon Sep 17 00:00:00 2001 > From: Dima Kogan > Date: Wed, 5 Mar 2014 23:10:57 -0800 > Subject: [PATCH] insert-pair now behaves like its docstring says > > The docstring of insert-pair states that after insertion, the point > ends up after the opening character. This was not true if the pair was > inserted to surround a region > --- > lisp/emacs-lisp/lisp.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/emacs-lisp/lisp.el b/lisp/emacs-lisp/lisp.el > index 0487515..420b205 100644 > --- a/lisp/emacs-lisp/lisp.el > +++ b/lisp/emacs-lisp/lisp.el > @@ -536,7 +536,7 @@ This command assumes point is not in a string or comment." > (if (and transient-mark-mode mark-active) > (progn > (save-excursion (goto-char (region-end)) (insert close)) > - (save-excursion (goto-char (region-beginning)) (insert open))) > + (goto-char (region-beginning)) (insert open)) > (if arg (setq arg (prefix-numeric-value arg)) > (setq arg 0)) > (cond ((> arg 0) (skip-chars-forward " \t")) Thanks; applied to emacs-25. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no