From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#23769: 25.0.95; Mode Line breakage in vc-git Date: Thu, 16 Jun 2016 08:11:50 +0100 Message-ID: <87ziqlzjyh.fsf@russet.org.uk> References: <87a8ioyq9o.fsf@russet.org.uk> <87wplr1z4z.fsf@russet.org.uk> <91e61a46-b3bb-c4d9-cb30-bbfa90135d69@yandex.ru> <877fdqkwki.fsf@russet.org.uk> <9856a1e4-be41-d781-bfbd-22bac360d18b@yandex.ru> <871t3y85oz.fsf@russet.org.uk> <87e22f3a-27d2-338e-05f7-b3ab820dbe5f@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466061214 25284 80.91.229.3 (16 Jun 2016 07:13:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Jun 2016 07:13:34 +0000 (UTC) Cc: 23769@debbugs.gnu.org, Noam Postavsky To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 16 09:13:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDRUI-00028q-3j for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Jun 2016 09:13:14 +0200 Original-Received: from localhost ([::1]:46869 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDRUH-0000x4-3P for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Jun 2016 03:13:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDRUA-0000vx-VY for bug-gnu-emacs@gnu.org; Thu, 16 Jun 2016 03:13:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDRU6-0007MG-Ni for bug-gnu-emacs@gnu.org; Thu, 16 Jun 2016 03:13:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDRU6-0007M6-F7 for bug-gnu-emacs@gnu.org; Thu, 16 Jun 2016 03:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bDRU6-0000ys-8S for bug-gnu-emacs@gnu.org; Thu, 16 Jun 2016 03:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jun 2016 07:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23769-submit@debbugs.gnu.org id=B23769.14660611273708 (code B ref 23769); Thu, 16 Jun 2016 07:13:02 +0000 Original-Received: (at 23769) by debbugs.gnu.org; 16 Jun 2016 07:12:07 +0000 Original-Received: from localhost ([127.0.0.1]:42847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDRT9-0000xg-3T for submit@debbugs.gnu.org; Thu, 16 Jun 2016 03:12:07 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:36106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDRT4-0000x1-8h for 23769@debbugs.gnu.org; Thu, 16 Jun 2016 03:12:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From; bh=yitI1cJaqsW9WRe+da2jJeN/yEVosPj7JZnwSmM0wck=; b=G5EcvNVvs3mtz1KMxF+iiWEMzX Czc63uZSo1rpk8xB0qxzjIRtdm/rZqhdVrd9U2L/57qZ/MNtjT0Gjr5L1FXtuoSvXcR+EjVW8epjU q3w7CZbYQ+LY0OcrVkf9lw+DTDJJcLUXeINpID4aM8GCUXNMiyeskb7bWlSn7Ta6YGJ74F/1GGDN0 sycGM49xxSgJFJUWsd0Q0XxkfUpudlZNPIJQFqJ7jQMkkXxN8B0fWYglEiZGNsIn0XqL0/V+o3gph 0+F+Cw5IXOujAnamPtoh6/il6uVbD93vKQPeaiRHzHkGbEem7rHmU80M3mzwQfNDznDuNLH203pKE Fkcacm4g==; Original-Received: from cpc1-benw10-2-0-cust373.gate.cable.virginm.net ([77.98.219.118]:46706 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bDRSx-0002oG-Vx; Thu, 16 Jun 2016 08:11:52 +0100 In-Reply-To: <87e22f3a-27d2-338e-05f7-b3ab820dbe5f@yandex.ru> (Dmitry Gutov's message of "Thu, 16 Jun 2016 02:20:53 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119618 Archived-At: Dmitry Gutov writes: > On 06/16/2016 01:27 AM, Noam Postavsky wrote: > >> Apparently this "_the_ right way to write hooks that touch the files >> in the work tree." >> >> http://permalink.gmane.org/gmane.comp.version-control.git/136276 > > Is it the same behavior we're talking about? > > The thread says that GIT_DIR is set to '.', not to '.git'. I doubt the former > setting would mesh well with binding default-directory to repository's root > like the patch proposes. According to this: http://longair.net/blog/2011/04/09/missing-git-hooks-documentation/ that's for the post-recieve hook. In this case CWD is the git directory. The logic of this is (I guess) that it works also in a bare repo. pre-commit can only ever run in a non-bare repo since you cannot commit if you don't have a worktree. I suspect emacs will not be affected by this because if anyone did run emacs in post-recieve they would only touch files *inside* the git repo which Emacs would identify as not version-controlled. But, again, it illustrates the point that GIT_DIR can (and is often) set to a relative directory. Phil