unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Markus Triska <triska@metalevel.at>
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: 23871@debbugs.gnu.org
Subject: bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer
Date: Sat, 02 Jul 2016 22:53:37 +0200	[thread overview]
Message-ID: <87zipz223y.fsf@metalevel.at> (raw)
In-Reply-To: <87k2h37pvb.fsf@russet.org.uk> (Phillip Lord's message of "Sat, 02 Jul 2016 21:21:28 +0100")

Hi Phillip,

phillip.lord@russet.org.uk (Phillip Lord) writes:

> I believe the following patch addresses the issue.

This patch causes a regression with the original case I posted in this
report (#23871):

Without your patch, after undo, point is *either*

(1) at the beginning of line 15 OR
(2) at a position that is outside the buffer (point 323 of 322).

Case (1) is the expected behaviour, and case (2) is the issue I reported
and which, just FYI, also still arises with your patch applied.

However, your patch also leads to the new problem that even in cases
where the point is not outside the buffer, it is unexpectedly placed at
the *end* of line 15 instead of at the beginning, where ediprolog-dwim
was invoked before the insertion is undone.

In this sense, the behaviour is worse than before for #23871 with your
patch, because point is never restored to where the interaction started.

All the best!
Markus





  reply	other threads:[~2016-07-02 20:53 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 21:47 bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer Markus Triska
2016-06-30 16:38 ` Eli Zaretskii
2016-06-30 18:00   ` Markus Triska
2016-06-30 18:21     ` Eli Zaretskii
2016-06-30 18:52       ` Eli Zaretskii
2016-06-30 21:45     ` Phillip Lord
2016-07-01  6:31       ` Markus Triska
2016-07-01  7:25         ` Eli Zaretskii
2016-07-01 14:04           ` Phillip Lord
2016-07-01 20:38             ` Markus Triska
2016-07-01 22:12               ` Phillip Lord
2016-07-01 20:49             ` Markus Triska
2016-07-01 22:21               ` Phillip Lord
2016-07-02  5:35                 ` Markus Triska
2016-07-02  7:35                 ` Eli Zaretskii
2016-07-02 20:21                   ` Phillip Lord
2016-07-02 20:53                     ` Markus Triska [this message]
2016-07-03  3:33                       ` Eli Zaretskii
2016-07-03  9:37                       ` Phillip Lord
2016-07-03 10:08                         ` Markus Triska
2016-07-03 12:55                           ` Phillip Lord
2016-07-03 15:30                             ` Eli Zaretskii
2016-07-03 20:21                               ` Phillip Lord
2016-07-03 18:05                             ` Markus Triska
2016-07-03 20:23                               ` Phillip Lord
2016-07-03 22:03                                 ` Markus Triska
2016-07-04 14:38                                   ` Eli Zaretskii
2016-07-05 16:36                                     ` Eli Zaretskii
2016-07-05 19:44                                       ` Phillip Lord
2016-07-05 20:02                                         ` Markus Triska
2016-07-05 19:47                                       ` Markus Triska
2016-07-05 20:00                                         ` Eli Zaretskii
2016-07-03 15:12                           ` Eli Zaretskii
2016-07-03 18:09                             ` Markus Triska
2016-07-03 19:20                               ` Eli Zaretskii
2016-07-03 20:37                             ` Phillip Lord
2016-07-03  3:31                     ` Eli Zaretskii
2016-07-03  9:39                       ` Phillip Lord
2016-07-03 21:33                     ` Stefan Monnier
2016-07-04 20:34                       ` Phillip Lord
2016-07-04 21:32                         ` Stefan Monnier
2016-07-05  8:43                           ` Phillip Lord
2016-07-05 20:32                             ` Markus Triska
2016-07-05 22:00                               ` Stefan Monnier
2016-07-05 22:17                                 ` Phillip Lord
2016-07-05 22:09                               ` Phillip Lord
2016-07-05 23:03                                 ` Markus Triska
2016-07-06 16:02                                   ` Phillip Lord
2016-07-06 17:59                                     ` Markus Triska
2016-08-12 23:03                                 ` npostavs
2016-08-13  8:02                                   ` Markus Triska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zipz223y.fsf@metalevel.at \
    --to=triska@metalevel.at \
    --cc=23871@debbugs.gnu.org \
    --cc=phillip.lord@russet.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).