From: Robert Cochran <robert-emacs@cochranmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 23988@debbugs.gnu.org
Subject: bug#23988: [PATCH] Remove FIXME to alias fboundp to symbol-function
Date: Fri, 15 Jul 2016 12:50:02 -0700 [thread overview]
Message-ID: <87zipik7f9.fsf@cochranmail.com> (raw)
In-Reply-To: <83lh1374ry.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 15 Jul 2016 10:13:21 +0300")
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> How about adding a comment there that summarizes the discussion in
> that bug? Perhaps someone will come up with a clever idea to overcome
> the difficulties.
That's a good point. I have attached a new patch that summarizes the
discussion.
Thanks,
~Robert Cochran
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch that details discussion of the fboundp FIXME --]
[-- Type: text/x-patch, Size: 1374 bytes --]
From 60921ce566429711c7366ab6663fa37ee97b9190 Mon Sep 17 00:00:00 2001
From: Robert Cochran <robert-git@cochranmail.com>
Date: Fri, 15 Jul 2016 12:45:56 -0700
Subject: [PATCH] Expand FIXME near definition of fboundp
This expansion of the FIXME is so that future developers are aware of
the potential problems of aliasing fboundp to symbol-function without
taking backwards compatibility into account.
* src/data.c (fboundp): Note potential backwards compatibility issues in
FIXME.
---
src/data.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/data.c b/src/data.c
index 71da916..9846006 100644
--- a/src/data.c
+++ b/src/data.c
@@ -629,7 +629,12 @@ global value outside of any lexical scope. */)
return (EQ (valcontents, Qunbound) ? Qnil : Qt);
}
-/* FIXME: Make it an alias for function-symbol! */
+/* FIXME: It has been previously suggested to make this function an
+ alias for symbol-function, but upon discussion at Debbug#23957,
+ there is a risk breaking backward compatiblity, as some users of
+ fboundp may expect `t' in particular, rather than any true
+ value. An alias is still welcome so long as the compatibility
+ issues are addressed. */
DEFUN ("fboundp", Ffboundp, Sfboundp, 1, 1, 0,
doc: /* Return t if SYMBOL's function definition is not void. */)
(register Lisp_Object symbol)
--
2.7.4
next prev parent reply other threads:[~2016-07-15 19:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 22:49 bug#23988: [PATCH] Remove FIXME to alias fboundp to symbol-function Robert Cochran
2016-07-15 7:13 ` Eli Zaretskii
2016-07-15 19:50 ` Robert Cochran [this message]
2016-07-16 6:56 ` Eli Zaretskii
2016-07-17 1:44 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zipik7f9.fsf@cochranmail.com \
--to=robert-emacs@cochranmail.com \
--cc=23988@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).