From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: David Engster Newsgroups: gmane.emacs.bugs Subject: bug#25556: 26.0.50.1; Requiring uncompiled eieio issues obsoletion warnings Date: Sun, 29 Jan 2017 22:23:34 +0100 Message-ID: <87zii98srt.fsf@engster.org> References: <878tpw1bml.fsf@engster.org> <83wpdfzmcg.fsf@gnu.org> <87ziibzigh.fsf@engster.org> <87o9yrs1bq.fsf@users.sourceforge.net> <87h94izy1j.fsf@engster.org> <87bmupsur8.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485725061 18895 195.159.176.226 (29 Jan 2017 21:24:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jan 2017 21:24:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 25556@debbugs.gnu.org, Stefan Monnier To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 29 22:24:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXwxJ-0004V5-TY for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2017 22:24:14 +0100 Original-Received: from localhost ([::1]:56821 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXwxK-00036t-NJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2017 16:24:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXwxB-00035m-N8 for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 16:24:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXwx8-00080P-Jb for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 16:24:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52266) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXwx8-00080J-DG for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 16:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cXwx8-000820-7o for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 16:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: David Engster Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2017 21:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25556 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25556-submit@debbugs.gnu.org id=B25556.148572502430848 (code B ref 25556); Sun, 29 Jan 2017 21:24:02 +0000 Original-Received: (at 25556) by debbugs.gnu.org; 29 Jan 2017 21:23:44 +0000 Original-Received: from localhost ([127.0.0.1]:50465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXwwq-00081U-5O for submit@debbugs.gnu.org; Sun, 29 Jan 2017 16:23:44 -0500 Original-Received: from randomsample.de ([5.45.97.173]:35288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXwwo-00081L-5i for 25556@debbugs.gnu.org; Sun, 29 Jan 2017 16:23:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=uPHcMgMnWF6H1v1TipBFh8l4J4/SRp8WzMJT9pJBB1Y=; b=iK/1ndBsYUvQVDFmcQk/WQAzmPeRx3FGNAZVMb1aLNCdNdmX4z/E5ZablrjeJ3oKHV/toLKJRg6HmM9BN8hTwCJs9cWDgeBUfXvDsmh/Svggur8kUTSOF60asr5c3VPq; Original-Received: from ip4d16b353.dynamic.kabel-deutschland.de ([77.22.179.83] helo=isaac) by randomsample.de with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1cXwwl-0006mw-1m; Sun, 29 Jan 2017 22:23:39 +0100 In-Reply-To: <87bmupsur8.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sun, 29 Jan 2017 11:20:27 -0500") Mail-Copies-To: never X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128770 Archived-At: 'npostavs' writes: > David Engster writes: > >>> >>> I'm not sure about `eieio-object-name-string', but the message about >>> `destructor' is because cl-defgeneric makes the declaration handling >>> code run before the function defining code, so the symbol is declared >>> obsolete before it's defined and the definition itself triggers the >>> obsolete warning. The patch below moves it around and stops the >>> `destructor' warning: >> >> Thanks for looking into to it, your patch works fine for me. Can this be >> applied? > > I pushed to master [1: 9bf9463]. > > 1: 2017-01-29 11:16:06 -0500 9bf94639b8f674d2c7894df35f26f09d0ecc67f5 > Don't warn about obsolete defgenerics when defining them Thanks! Regarding eieio-object-name-string, the issue is indeed that it is first defined via cl-defgeneric with an obsolete declaration, which in turn means that any (uncompiled) cl-defmethod will issue an obsoletion warning (so in this case twice: for eieio and eieio-named in eieio-base.el). So couldn't we just simply remove the cl-defgeneric for eieio-object-name-string, and use make-obsolete instead? Stefan, what do you think? -David