From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#27405: 25.2; Make eshell-next-prompt more reliable Date: Sat, 17 Jun 2017 18:13:44 -0400 Message-ID: <87zid6qn3b.fsf@users.sourceforge.net> References: <20170617090813.GA889@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1497737593 16678 195.159.176.226 (17 Jun 2017 22:13:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Jun 2017 22:13:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 27405@debbugs.gnu.org To: Pierre Neidhardt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 18 00:13:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMLxt-00048H-1a for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Jun 2017 00:13:09 +0200 Original-Received: from localhost ([::1]:36360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMLxy-0003Tb-3T for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Jun 2017 18:13:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMLxs-0003Sa-8b for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 18:13:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMLxm-0006wW-9N for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 18:13:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMLxm-0006wS-5b for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 18:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dMLxm-0002Ec-03 for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 18:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2017 22:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27405 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27405-submit@debbugs.gnu.org id=B27405.14977375358538 (code B ref 27405); Sat, 17 Jun 2017 22:13:01 +0000 Original-Received: (at 27405) by debbugs.gnu.org; 17 Jun 2017 22:12:15 +0000 Original-Received: from localhost ([127.0.0.1]:53763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMLx1-0002DY-2F for submit@debbugs.gnu.org; Sat, 17 Jun 2017 18:12:15 -0400 Original-Received: from mail-io0-f171.google.com ([209.85.223.171]:34489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMLwy-0002DE-QY; Sat, 17 Jun 2017 18:12:13 -0400 Original-Received: by mail-io0-f171.google.com with SMTP id i7so46745978ioe.1; Sat, 17 Jun 2017 15:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=o5PVCXH8nniRbsac7vyDR8rW0MQQccHbSUVhXWOOWyw=; b=bvjBrHAJbHU+3dBiScV8FadJrVGt36qycW+EsNm32TaVWSYkCQnICcH15ufiWQJrL6 3hzlDQ4XwxPnGT9OHyP3Z8htPfrlJ3rlOQeRlw3KyVvKPlONKXSIo155yUWLWJhwBDrW RcNS1ggu34Ae9mNUTRe52tQ7cUqioh/E4zOIYrm4h0yJvmmBwbm6encopClih4ipSMm4 8ED39TpArieZHdpSsVXAp6YxhNw9ptoP08V1jrQkOr4Jq6R6DP921/mBINhBMZKPxhXs RMmEDvb65PcqSEplVczlB+aKLNvCm9HTTKILKLSJ37lzKfvqQxyj1JcQ+KX7vreeum/7 3UDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=o5PVCXH8nniRbsac7vyDR8rW0MQQccHbSUVhXWOOWyw=; b=SAR3SDHL8ZZVXFLEHBel1PNJa4C+z6Om3JV/DAwIxUMA+4oxI7r64kOxmVuSsgIiGW m7lLs67Ui5gW7msUjE+tAcCj25nVIxFb9kG3NVzvlWnoSQuTC0h2ctXqH+zbLU94Tujy 4qKJUGkcxS0fKEtNwxfADQ0DpNjw8BCenR9YvVq8WA9hYbh6vhM8gUMayGJ/aEAMKKbv bA6JuEwwc0TKUHSfG2XCemf3Xw5tsdltpm1hsD0ws9Dignmq8iaKbctAnRLite+qhD/9 dCdZWRc20TVIaeJyUw/vV8NHgjfTOOS63LlBVtf6//bmZypgK7dOM2CkYNiN6RRR8bCE hSZg== X-Gm-Message-State: AKS2vOwFXii4xpKLUOfGnxWIYHe014c39u8ipt2QOuiKI022tP58LrHv ssClwXaYSGF03tKc X-Received: by 10.107.157.76 with SMTP id g73mr12587060ioe.119.1497737527111; Sat, 17 Jun 2017 15:12:07 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id u186sm4289805ita.3.2017.06.17.15.12.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Jun 2017 15:12:06 -0700 (PDT) In-Reply-To: <20170617090813.GA889@gmail.com> (Pierre Neidhardt's message of "Sat, 17 Jun 2017 10:08:13 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133712 Archived-At: severity 27405 minor tags 27405 + confirmed quit Pierre Neidhardt writes: > Current definition of `eshell-next-prompt' merely skips a > paragraph. This won't produce the right result as soon the output > contains a paragraph separator (typically an empty line). > > I have been using the following redefinition for a while and it works much > better for me: Seems reasonable. > (defun eshell-next-prompt (n) > "Move to end of Nth next prompt in the buffer. > See `eshell-prompt-regexp'." > (interactive "p") > (re-search-forward eshell-prompt-regexp nil t n) > (when eshell-highlight-prompt > (while (not (get-text-property (line-beginning-position) 'read-only) ) > (re-search-forward eshell-prompt-regexp nil t n))) > (eshell-skip-prompt)) > > (defun eshell-previous-prompt (n) > "Move to end of Nth previous prompt in the buffer. > See `eshell-prompt-regexp'." > (interactive "p") > (backward-char) > (eshell-next-prompt (- n)))) What's the backward-char for?