From: npostavs@users.sourceforge.net
To: Alex Branham <branham@utexas.edu>
Cc: 27341@debbugs.gnu.org
Subject: bug#27341: updated patch to fix docstring
Date: Sun, 02 Jul 2017 14:32:50 -0400 [thread overview]
Message-ID: <87zicmk7u5.fsf@users.sourceforge.net> (raw)
In-Reply-To: <878tkdy37e.fsf@utexas.edu> (Alex Branham's message of "Tue, 27 Jun 2017 15:23:17 +0200")
Alex Branham <branham@utexas.edu> writes:
> On Fri 30 Jun 2017 at 00:54, npostavs@users.sourceforge.net wrote:
>
>> Could you add a ChangeLog entry to the commit message as described in
>> CONTRIBUTE, please?
>
> Yes, I have done so. Let me know if it's not right.
Looks good, thanks.
>> Doc strings shouldn't be indented like that, and there should be a
>> double space between sentences.
>
> Fixed.
You missed the double spacing before the "Else,".
> Actually, we need to check (use-region-p) anyway in case the mark
> hasn't been activated yet in the buffer:
Hmm, I just tried this and it doesn't quite do the job. I believe the
problem is that the (interactive "r") form throws an error when the mark
hasn't been activated yet. To handle this case correctly you need to
replace the "r" with some lisp code that produces the argument list.
next prev parent reply other threads:[~2017-07-02 18:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 11:21 bug#27341: eww-search-words should prompt if region inactive Alex Branham
2017-06-13 9:24 ` bug#27341: updated patch to fix docstring Alex Branham
2017-06-25 14:29 ` npostavs
2017-06-26 14:00 ` Alex Branham
2017-06-26 23:50 ` npostavs
2017-06-27 5:32 ` Alex Branham
2017-06-27 13:23 ` Alex Branham
2017-06-30 0:54 ` npostavs
2017-06-30 6:25 ` Alex Branham
2017-07-02 18:32 ` npostavs [this message]
2017-07-02 18:45 ` Alex Branham
2017-07-02 19:13 ` npostavs
2017-07-02 19:25 ` Alex Branham
2017-07-02 20:23 ` npostavs
2017-06-27 14:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zicmk7u5.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=27341@debbugs.gnu.org \
--cc=branham@utexas.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).