From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Olaf Rogalsky Newsgroups: gmane.emacs.bugs Subject: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings Date: Wed, 01 Nov 2017 14:45:32 +0100 Message-ID: <87zi869koz.fsf@t-online.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1509544035 5357 195.159.176.226 (1 Nov 2017 13:47:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 1 Nov 2017 13:47:15 +0000 (UTC) To: 29104@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 01 14:47:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9tMG-0000LE-Oi for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Nov 2017 14:47:04 +0100 Original-Received: from localhost ([::1]:55944 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9tMN-0004iB-P4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Nov 2017 09:47:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9tMI-0004hp-0L for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2017 09:47:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9tME-0006FP-Uj for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2017 09:47:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36444) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9tME-0006FD-RH for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2017 09:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e9tME-0005bd-Go for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2017 09:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Olaf Rogalsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Nov 2017 13:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.150954396521481 (code B ref -1); Wed, 01 Nov 2017 13:47:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Nov 2017 13:46:05 +0000 Original-Received: from localhost ([127.0.0.1]:45125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9tLJ-0005aP-I4 for submit@debbugs.gnu.org; Wed, 01 Nov 2017 09:46:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9tLI-0005Zh-Fw for submit@debbugs.gnu.org; Wed, 01 Nov 2017 09:46:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9tLC-0004wB-4P for submit@debbugs.gnu.org; Wed, 01 Nov 2017 09:45:59 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:58946) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9tLC-0004vq-27 for submit@debbugs.gnu.org; Wed, 01 Nov 2017 09:45:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9tLA-0004af-Ux for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2017 09:45:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9tL7-0004p4-To for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2017 09:45:57 -0400 Original-Received: from mailout11.t-online.de ([194.25.134.85]:60336) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9tL7-0004nO-Lv for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2017 09:45:53 -0400 Original-Received: from fwd26.aul.t-online.de (fwd26.aul.t-online.de [172.20.26.131]) by mailout11.t-online.de (Postfix) with SMTP id B8BAE4249F53 for ; Wed, 1 Nov 2017 14:45:50 +0100 (CET) Original-Received: from blaubaer (E2uzUeZLwhZATZTdMxvJg7gvcPxXLD+Ffb+qTKuHbkwIkqftbd6F5vXGdTOYKuKZtN@[84.57.184.143]) by fwd26.t-online.de with (TLSv1.2:DHE-RSA-AES256-SHA256 encrypted) esmtp id 1e9tKz-40Rxh20; Wed, 1 Nov 2017 14:45:45 +0100 X-ID: E2uzUeZLwhZATZTdMxvJg7gvcPxXLD+Ffb+qTKuHbkwIkqftbd6F5vXGdTOYKuKZtN X-TOI-MSGID: fcdab738-b6a1-4e21-a03c-3a5f6af1f585 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139316 Archived-At: 1. emacs -Q -nw 2. M-x xterm-mouse-mode RET 3. mouse-1 click on the `*scratch*' string of the modeline. 4. Nothing happens. Expected behaviour would be, to change to the next bu= ffer `*Messages*'. This seems to be a bug in `keyboard.c:read_key_sequence'. After reading the first characters of the xterm click event, they are remapped with `keyremap_step' at line 9605 using the `input-decode-map'. The result of this is a mouse-1 event structure, which carries the correct click position. Unfortunately, this position isn't used, but instead, at line 9035, the position of the variable `first_event' is used. The following patch sets `first_event' (after a key translation / remapping) to the remapped event. diff --git a/src/keyboard.c b/src/keyboard.c index ee353d2b07..acb9c6be95 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -9607,6 +9607,8 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize= , Lisp_Object prompt, if (done) { mock_input =3D diff + max (t, mock_input); + first_event =3D mock_input > 0 ? keybuf[0] : Qnil; + goto replay_sequence; } } @@ -9647,6 +9649,7 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize= , Lisp_Object prompt, /* Adjust the input-decode-map counters. */ indec.end +=3D diff; indec.start +=3D diff; + first_event =3D mock_input > 0 ? keybuf[0] : Qnil; =20 goto replay_sequence; } @@ -9669,6 +9672,7 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize= , Lisp_Object prompt, indec.start +=3D diff; fkey.end +=3D diff; fkey.start +=3D diff; + first_event =3D mock_input > 0 ? keybuf[0] : Qnil; =20 goto replay_sequence; } --=20 Olaf Rogalsky Schw=C3=B6rhausgasse 5 89073 Ulm Germany