From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#26049: 25.2; Extra lines not added to comment Date: Mon, 06 Nov 2017 19:07:07 -0500 Message-ID: <87zi7z54us.fsf@users.sourceforge.net> References: <29145.1489153275@localhost> <87r31i2i5a.fsf@users.sourceforge.net> <7171.1490705541@localhost> <87h92c3jl8.fsf@users.sourceforge.net> <20705.1490770493@localhost> <17405.1506152497@localhost> <877ewpo50c.fsf@users.sourceforge.net> <7456.1509963262@localhost> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1510013292 19520 195.159.176.226 (7 Nov 2017 00:08:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 7 Nov 2017 00:08:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 26049@debbugs.gnu.org To: Antonin Houska Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 07 01:08:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBrQz-0004pI-Mp for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Nov 2017 01:08:05 +0100 Original-Received: from localhost ([::1]:50777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBrR6-0004Nm-Qs for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Nov 2017 19:08:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBrR0-0004Ml-Rp for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 19:08:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBrQw-0000c1-QP for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 19:08:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46220) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBrQw-0000bE-Lt for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 19:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eBrQw-0000sJ-7c for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 19:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Nov 2017 00:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26049 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 26049-submit@debbugs.gnu.org id=B26049.15100132383309 (code B ref 26049); Tue, 07 Nov 2017 00:08:02 +0000 Original-Received: (at 26049) by debbugs.gnu.org; 7 Nov 2017 00:07:18 +0000 Original-Received: from localhost ([127.0.0.1]:54901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBrQE-0000rE-6M for submit@debbugs.gnu.org; Mon, 06 Nov 2017 19:07:18 -0500 Original-Received: from mail-io0-f169.google.com ([209.85.223.169]:46238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBrQB-0000qw-Cm; Mon, 06 Nov 2017 19:07:16 -0500 Original-Received: by mail-io0-f169.google.com with SMTP id 101so297043ioj.3; Mon, 06 Nov 2017 16:07:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DCR0dIdvyVzzI1Nzy0K+qr0u6YkTzjacxoudVQD5kl0=; b=Pm77UAhSWTq/hp/HuIEZwzmAlAQAMdbvREHvigNG1BEIxvRLAf71ET7X6zH3VaVLw7 7vKji7AyjMAUkfjnNBkJ5D5BHZy6KNiBdxnrqOvJLUnsQySc1uXVOI8Nzi/CozIx+LcN VQrWz2zSfh/eu+dxoTrBccoULux580N7Xmj38EFK1aeT1HG80tr7LZ7PeVa0LZ5HsmXj It5+EFGVugmaRoP4CljhCx52JaxR5CxPdkUwt/JOIJcbZZCdH3SEpVdUVu7Ltykjz9/d K1f0UK79ZyCMYEEfUY3aeADwn0xQzWxwB/FTQIjrtytJQMumZNBraJ62Y0PD84/DHyMI Dx4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=DCR0dIdvyVzzI1Nzy0K+qr0u6YkTzjacxoudVQD5kl0=; b=FFVBnDVptY4zU4U1Um+Jxu/8VFqOeoGJ0el1vymwaFg+5iSvGN3r5GGuQ+XZXQ4jR5 FQ0zvnezpTUFWxKwJi8lBR2xwYFMh/G6PALYER4Suc6p3gaLtoKbUJ6czKekZWKGQkx0 XNFXTdhB3VH5je36rBUpKFfq8Lb9NifbgscNJn0QPCdFNflYOePr8MWxL7cgzspiPVrD P1ABLLMhncoyeG/XEJosBRCyLfIEE9BKOmKXSns+GzIF2E8GFYrhU4DKqpzd1EOD5ucr qT51uT4Xvz2vwAli9aLdLa5gIInTHqCUq2YxUXHM/fCOkSRJa9UA/Hne8KWd0oUqiIe6 9gPg== X-Gm-Message-State: AJaThX6YG2m5iceomm3n118VFY6hXluRkXL/6yOZH9xkmy93THSe3Op6 X6R/+10oOheGRRACvgSvnVc/uA== X-Google-Smtp-Source: ABhQp+StPmq0VH32x+LOVaHYX08jGaSgW+jFltUHPA1E1pwZbxCDpi5hn0I4CKP+KUJEF/6P1vULNA== X-Received: by 10.107.58.67 with SMTP id h64mr22054665ioa.112.1510013229524; Mon, 06 Nov 2017 16:07:09 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m141sm111669itm.12.2017.11.06.16.07.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Nov 2017 16:07:08 -0800 (PST) In-Reply-To: <7456.1509963262@localhost> (Antonin Houska's message of "Mon, 06 Nov 2017 11:14:22 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139537 Archived-At: tags 26049 fixed close 26049 26.1 quit Antonin Houska writes: > Subject: [PATCH] Handle single-line comments correctly (Bug#26049) > > * lisp/newcomment.el: the comment text had to contain at least one > line break for the ending extra line to be added. The behavior seems > more consistent if the end of the comment text is also considered a > line break. > > While fixing this, also removed trailing white space from the comment > initial line (/*). > > Copyright-paperwork-exempt: yes Thanks, I rephrased/reformatted the message a bit and pushed to emacs-26. [1: db949166ec]: 2017-11-06 19:01:19 -0500 Handle single-line comments correctly (Bug#26049) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=db949166ecb9aeaa15aa41369a55b3ea6ceaa3b0