From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#30280: async-shell-command-display-buffer doesn't work anymore Date: Wed, 31 Jan 2018 23:44:43 +0200 Organization: LINKOV.NET Message-ID: <87zi4tu2ic.fsf@mail.linkov.net> References: <87a7wxd1g9.fsf@mail.linkov.net> <83607kinmx.fsf@gnu.org> <877erz41re.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1517435803 13732 195.159.176.226 (31 Jan 2018 21:56:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 31 Jan 2018 21:56:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 30280@debbugs.gnu.org, Reuben Thomas To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 31 22:56:38 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eh0MV-0001eG-GP for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jan 2018 22:56:11 +0100 Original-Received: from localhost ([::1]:34205 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eh0OW-0007cV-FV for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jan 2018 16:58:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eh0OM-0007bE-9c for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 16:58:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eh0OJ-0006fj-0b for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 16:58:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43669) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eh0OI-0006fS-MI for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 16:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eh0OI-0007BN-FD for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 16:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Jan 2018 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30280 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30280-submit@debbugs.gnu.org id=B30280.151743582427515 (code B ref 30280); Wed, 31 Jan 2018 21:58:02 +0000 Original-Received: (at 30280) by debbugs.gnu.org; 31 Jan 2018 21:57:04 +0000 Original-Received: from localhost ([127.0.0.1]:51561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eh0NM-00079j-2P for submit@debbugs.gnu.org; Wed, 31 Jan 2018 16:57:04 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:35184 helo=homiemail-a20.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eh0NL-00079W-56 for 30280@debbugs.gnu.org; Wed, 31 Jan 2018 16:57:03 -0500 Original-Received: from homiemail-a20.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTP id 9BA6B7EC06F; Wed, 31 Jan 2018 13:57:02 -0800 (PST) Original-Received: from localhost.linkov.net (m91-129-107-8.cust.tele2.ee [91.129.107.8]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTPSA id 32FB27EC063; Wed, 31 Jan 2018 13:57:00 -0800 (PST) In-Reply-To: <877erz41re.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 30 Jan 2018 18:53:09 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142754 Archived-At: > I attach a patch which addresses both bugs. Its solution for (a) is to > make the advice disposable, i.e. it removes itself from the process > filter after it has fulfilled its purpose of displaying the output > buffer. A syntactically simpler implementation of this could use a > plain boolean switch instead of removing the advice, but IMO the latter > is semantically more sound (and possibly more performant in subsequent > invocations of the process filter, though this should be irrelevant). > > WDYT? Thanks, I confirm this is the right thing to do and your patch fixes the reported issue. > P.S. Would patch(es) for aesthetic changes to the rest of shell-command > (such as removing redundant variables, inverting the condition of the > massive if-then-else to reduce indentation, etc.) be welcome? If so, > where should I send them? Such changes are always welcome as patches separate from the actual fixes, i.e. when not amalgamating bug fixes and code beautification/refactoring in the same patch.