From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome Date: Fri, 15 Jun 2018 06:41:27 -0400 Message-ID: <87zhzwuyaw.fsf@gmail.com> References: <83d0wt2wgi.fsf@gnu.org> <83bmcd2r08.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529059211 5663 195.159.176.226 (15 Jun 2018 10:40:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 15 Jun 2018 10:40:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31828@debbugs.gnu.org, Kelvin White , Kaushal Modi To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 15 12:40:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTm9G-0001Me-Ln for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jun 2018 12:40:06 +0200 Original-Received: from localhost ([::1]:45766 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTmBN-0001wJ-Oc for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jun 2018 06:42:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTmBD-0001tK-Py for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 06:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTmB8-0000xx-W4 for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 06:42:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41064) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTmB8-0000xi-SS for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 06:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fTmB8-0007ar-Ey for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 06:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jun 2018 10:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31828 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31828-submit@debbugs.gnu.org id=B31828.152905929829156 (code B ref 31828); Fri, 15 Jun 2018 10:42:02 +0000 Original-Received: (at 31828) by debbugs.gnu.org; 15 Jun 2018 10:41:38 +0000 Original-Received: from localhost ([127.0.0.1]:48960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTmAj-0007aC-Sc for submit@debbugs.gnu.org; Fri, 15 Jun 2018 06:41:38 -0400 Original-Received: from mail-io0-f175.google.com ([209.85.223.175]:37065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTmAh-0007Zy-CZ for 31828@debbugs.gnu.org; Fri, 15 Jun 2018 06:41:36 -0400 Original-Received: by mail-io0-f175.google.com with SMTP id s26-v6so10299917ioj.4 for <31828@debbugs.gnu.org>; Fri, 15 Jun 2018 03:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eAusNoAeltcbSWAQB//m1u1uF+A6JXrSneEj5DZT85s=; b=mLphFHZkOkTEfKBwLmy2MvLkCfGO4xxqlsHVG08M5R+fSEWPRQNXgD/L6Bena8zB1M 5xNg0xGdidn4dZA9izqduHQ62nOFLz5aQOIqWsD2GYo+f97TIDvb4mWrECazfVIDYn6L 5wflyfZDJr2L89XdSN/bUgyHTiF6PEgwtcB/59dP7c+6vlyf6pBc4bNZ8Zhn5ENvGZg7 X6/xaWN7LgoR6Meghb3RmorTWAiuvpvaIgziO37barhRuy0Z5X1oKSCwMtWJTlbU3QNh BfyyUuFsn2qDWDGFDmX9/7VP00XCRjRz3EzJJAcT/0TjgeVDcR3WQlp4isOkyt95dUoz cjGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=eAusNoAeltcbSWAQB//m1u1uF+A6JXrSneEj5DZT85s=; b=lgXDN/RCdAx6ncZi7OvZM8YoyWvFGZvnKvH/eHPlWk4ZiDfanGcQCtmXsEWGDDhZI+ RMUYpQ9Bq6vZOZD+vQPFMjqpUTT9NOiozYTi48yHd5z7Hkd3nqYV2f3y+H18T8fiFp67 Iyqz6v+RsJU7e4QldMY/dxhHU1Z1AsT8iSTKP3zX5+2XkgkIBGMRH2paJiFbRkT5qajz vgFtkjM5aKPTCCPVRlbW1kpMhjgsFmT3iWFanSjUCvoWFLCwUkrS7AqfKoUMVTlNoKcB CB2I6ZrIFmJ0T4DQ4b34uNuzh7TOSmXQLv5mnlXcain68e+2GLuqwFgQvXaml4E015q7 R9vQ== X-Gm-Message-State: APt69E1aUMDLR4EioMzb/QF1E4vBCwvr1DoTXWH0jlLLT6qyAzSEmLRI DWo0hRFTbs8aa/IbrDIvHHs= X-Google-Smtp-Source: ADUXVKIrDp1ZsK5TxldzPxMnbyIleuci2Q2KTPzpSX7qYh+er82EiSLZYL6mgX/DMbXcXm6b0DU3Pg== X-Received: by 2002:a6b:6f05:: with SMTP id k5-v6mr1012864ioc.55.1529059289753; Fri, 15 Jun 2018 03:41:29 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id r12-v6sm1558966iob.35.2018.06.15.03.41.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Jun 2018 03:41:28 -0700 (PDT) In-Reply-To: <83bmcd2r08.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Jun 2018 20:54:15 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147450 Archived-At: Eli Zaretskii writes: >> From: Kaushal Modi >> Date: Thu, 14 Jun 2018 11:59:27 -0400 >> Cc: 31828@debbugs.gnu.org >> >> Then looking up in lisp/net/browse-url.el, I saw that all browse-url-* functions had an autoload except for >> browse-url-chrome. > > No, not all of them. Looks like the only other one missing an autoload is browse-url-epiphany. >> So it looked like a clear oversight. Is that correct? > > I don't think it's an oversight. Chrome is proprietary software. If that's the reason, shouldn't it be removed completely (and people who want to use Chrome could just set browse-url-chromium-program to "chrome" instead)? I've cc'd the author of the commit which added it. [1: 05a630484f]: 2016-01-24 14:47:28 -0500 browse-url.el: Add 'google-chrome' to supported browsers. https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=05a630484fd652f67ce06679fb3f890f5fdd65ea