From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31828@debbugs.gnu.org, Kelvin White <kwhite@gnu.org>,
Kaushal Modi <kaushal.modi@gmail.com>
Subject: bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome
Date: Fri, 15 Jun 2018 06:41:27 -0400 [thread overview]
Message-ID: <87zhzwuyaw.fsf@gmail.com> (raw)
In-Reply-To: <83bmcd2r08.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Jun 2018 20:54:15 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Kaushal Modi <kaushal.modi@gmail.com>
>> Date: Thu, 14 Jun 2018 11:59:27 -0400
>> Cc: 31828@debbugs.gnu.org
>>
>> Then looking up in lisp/net/browse-url.el, I saw that all browse-url-* functions had an autoload except for
>> browse-url-chrome.
>
> No, not all of them.
Looks like the only other one missing an autoload is
browse-url-epiphany.
>> So it looked like a clear oversight. Is that correct?
>
> I don't think it's an oversight. Chrome is proprietary software.
If that's the reason, shouldn't it be removed completely (and people who
want to use Chrome could just set browse-url-chromium-program to
"chrome" instead)? I've cc'd the author of the commit which added it.
[1: 05a630484f]: 2016-01-24 14:47:28 -0500
browse-url.el: Add 'google-chrome' to supported browsers.
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=05a630484fd652f67ce06679fb3f890f5fdd65ea
next prev parent reply other threads:[~2018-06-15 10:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 15:43 bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome Kaushal Modi
2018-06-14 15:56 ` Eli Zaretskii
2018-06-14 15:59 ` Kaushal Modi
2018-06-14 17:54 ` Eli Zaretskii
2018-06-14 17:59 ` Kaushal Modi
2018-06-15 10:41 ` Noam Postavsky [this message]
2019-05-15 4:27 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhzwuyaw.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31828@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=kwhite@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).