From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30190: 27.0.50; term run in line mode shows user passwords Date: Mon, 23 Jul 2018 08:22:21 -0400 Message-ID: <87zhyi3zwi.fsf@gmail.com> References: <87r2qjh0fs.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87zhyo6qkb.fsf@gmail.com> <877eln5de9.fsf@gmail.com> <83lga3w1o6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1532348556 14889 195.159.176.226 (23 Jul 2018 12:22:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 23 Jul 2018 12:22:36 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 30190@debbugs.gnu.org, monnier@IRO.UMontreal.CA, tino.calancha@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 23 14:22:31 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhZrC-0003lp-N9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Jul 2018 14:22:30 +0200 Original-Received: from localhost ([::1]:34345 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhZtJ-0002I8-Ki for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Jul 2018 08:24:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhZrm-0001XY-T5 for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2018 08:23:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhZri-00089V-ON for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2018 08:23:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48132) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhZri-00089L-KZ for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2018 08:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fhZri-00006B-Em for bug-gnu-emacs@gnu.org; Mon, 23 Jul 2018 08:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jul 2018 12:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed security Original-Received: via spool by 30190-submit@debbugs.gnu.org id=B30190.1532348554319 (code B ref 30190); Mon, 23 Jul 2018 12:23:02 +0000 Original-Received: (at 30190) by debbugs.gnu.org; 23 Jul 2018 12:22:34 +0000 Original-Received: from localhost ([127.0.0.1]:53150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhZrG-00004z-IH for submit@debbugs.gnu.org; Mon, 23 Jul 2018 08:22:34 -0400 Original-Received: from mail-io0-f178.google.com ([209.85.223.178]:45781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhZrC-0008WE-3x; Mon, 23 Jul 2018 08:22:30 -0400 Original-Received: by mail-io0-f178.google.com with SMTP id k16-v6so337325iom.12; Mon, 23 Jul 2018 05:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ED8mu3drv0fM48qo5xm1xkFuy2Pq9N5GOrSvXYM68Rw=; b=W1HyGWVvR7XARS3O2pgPMDHrNjLD6t9s5vbcMHHAiZAzCNLilpT1GDJ9Y6GRgvle5l FcP6tYzReFdzL3kvyfXV4ZriiM/kA3zRN0NZe1RgxNe0RLRLG5kLknpN/ZPpjlzI6ob9 IIpCejYKBJ8mgrKr2ygyxf7LW/LmqWYgLu6o/XCZQnYmaOOoTE0NM5rHxsmi+Ydn2+q8 FisoMXJQVRXDWStC8gqKQmsnANETIFXKZRdMM/m8b1gGCcem0P79U7BHEGcxDdRJ/Z/l hEjyxNJRhn/fo+RioKfAZFycYQv3JxyCbbKAL4VTwrrY0WiVra/j0OBblUk112c3llm4 aICg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ED8mu3drv0fM48qo5xm1xkFuy2Pq9N5GOrSvXYM68Rw=; b=NoB2Ut5D2DgqL9zOOLAfGYTbrj5ubUYDRL/YX4IefUG7WAdF12ntjI08wUV8WphD/w nLIkr1p2vLmaNLiA2cps50JqUNWg8WpDO/h1DaO9zrUczIdF5H9yCda4H0rCQJm1O7Jv ifm/MbEoGnNjEmOqNZs46Q2IcaE57e8wGf7rgiij2ju3k54pKGddBV9iDDTfVPvN2ubO nJSUa4YkoiAouELRFqsak/MBhYL41U3NP1S7h2mu1nwbV9ge1rA6PCxdlIJ7PMFADAOa dwNbfg4HLE7ZfMim2EKfWGzizGqSzznAjJeZzt+UuJt1l4PMZruBNNe3cVb14FITshcn LxkA== X-Gm-Message-State: AOUpUlE7WoCoORlhZk4TDir1AKHvO9/sWOKiPLm6/lXISHD9V4YdEqrW hqA2XqpijPCqSWjlE8H2OfxvOEM/ X-Google-Smtp-Source: AAOMgpe9pxXMXmdGurfeGXAeoL/CG+gWpIc4ghdw0chdbx80ahBlIKamx9bMBi5Sah1HpxUbl86rCw== X-Received: by 2002:a6b:28c2:: with SMTP id o185-v6mr9518843ioo.109.1532348544434; Mon, 23 Jul 2018 05:22:24 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w5-v6sm2808774ioc.58.2018.07.23.05.22.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 05:22:23 -0700 (PDT) In-Reply-To: <83lga3w1o6.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Jul 2018 21:44:25 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148854 Archived-At: tags 30190 fixed close 30190 26.2 quit Eli Zaretskii writes: >> From: Noam Postavsky >> Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Tino Calancha >> Date: Sun, 22 Jul 2018 14:33:18 -0400 >> >> Stefan Monnier writes: >> >> >> - (setq str (term-read-noecho "Non-echoed text: " t))) >> >> + (setq str (read-passwd "Non-echoed text: "))) >> > >> > I believe this remove the last use of term-read-noecho, so I think we >> > can then get rid of it (or at least mark it obsolete). >> >> Makes sense. I guess the obsoletion should go to master? >> >> Eli, is the patch in #131 okay for emacs-26? >> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30190#131 > > Yes, thanks. Pushed to emacs-26. [1: 2b70b54739]: 2018-07-23 08:20:07 -0400 Prevent line-mode term from showing user passwords https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2b70b54739a8a422aff85f0183fb69eb339c35d4