unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Raimon Grau <raimon@konghq.com>
To: Ivan Shmakov <ivan@siamics.net>, 32372@debbugs.gnu.org
Cc: Noam Postavsky <npostavs@gmail.com>
Subject: bug#32372: [PATCH] Add "uuid" to thing-at-point.el
Date: Thu, 09 Aug 2018 19:50:07 +0100	[thread overview]
Message-ID: <87zhxvwf1c.fsf@konghq.com> (raw)
In-Reply-To: <87bmab2yu1.fsf@violet.siamics.net>

Ivan Shmakov <ivan@siamics.net> writes:

> 	While either ‘and’ or ‘if’ can be used here, to exactly the same
> 	effect, the indentation above is one for ‘if’; ‘and’ should instead
> 	look like:
>
>            (and (thing-at-point-looking-at thing-at-point-uuid-regexp 36)
>                 (cons (match-beginning 0) (match-end 0)))
>
> 	I think in this case it’s marginally better to keep indentation
> 	and replace ‘and’ with ‘if’ than the other way around.

What about `when'? Is it ok to use it?

One branch 'if' look funny to me but I don't see many (any?) `when' in the emacs
codebase.

Thanks,

Raimon Grau





  reply	other threads:[~2018-08-09 18:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-05 23:11 bug#32372: [PATCH] Add "uuid" to thing-at-point.el Raimon Grau
2018-08-05 23:24 ` Raimon Grau
2018-08-06  2:31   ` Noam Postavsky
2018-08-06  9:47     ` Basil L. Contovounesios
2018-08-06  9:48     ` Raimon Grau
2018-08-06 19:16       ` Noam Postavsky
2018-08-07  7:48         ` Raimon Grau
2018-08-07 13:17           ` Ivan Shmakov
2018-08-07 17:45             ` Basil L. Contovounesios
2018-08-09 16:03             ` Raimon Grau
2018-08-09 18:12               ` Ivan Shmakov
2018-08-09 18:50                 ` Raimon Grau [this message]
2018-08-09 22:20                   ` Basil L. Contovounesios
2018-08-10  6:37                     ` Ivan Shmakov
2018-08-11 11:37                       ` Raimon Grau
2018-08-13 11:49                         ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhxvwf1c.fsf@konghq.com \
    --to=raimon@konghq.com \
    --cc=32372@debbugs.gnu.org \
    --cc=ivan@siamics.net \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).