From: Noam Postavsky <npostavs@gmail.com>
To: Pierre Lorenzon <devel@pollock-nageoire.net>
Cc: 32564@debbugs.gnu.org, cedet-devel@lists.sourceforge.net
Subject: bug#32564: 27.0.50; cedet/ede/pconf.el
Date: Fri, 31 Aug 2018 22:16:30 -0400 [thread overview]
Message-ID: <87zhx2q7wh.fsf@gmail.com> (raw)
In-Reply-To: <20180829.052832.975294280971149056.devel@pollock-nageoire.net> (Pierre Lorenzon's message of "Wed, 29 Aug 2018 05:28:32 +0200 (CEST)")
Pierre Lorenzon <devel@pollock-nageoire.net> writes:
> Bug in pconf.el has not been fixed yet. Here is a diff
> indicating what has to be done. I have to do it each time I
> upgrade my git copy of emacs otherwise C-c . C in ede mode
> crashes.
> @@ -135,7 +135,7 @@
> (with-current-buffer "*compilation*"
> (goto-char (point-max))
>
> - (when (not (string= mode-line-process ":exit [0]"))
> + (when (not (string= (car mode-line-process) ":exit [0]"))
> (error "Configure failed!"))
>
> ;; The Makefile is now recreated by configure?
>
> Diff finished. Wed Aug 29 05:09:19 2018
>
>
>>>> -- End Diff
>
>
> The problem is that this code do not take care of the fact that
> type of variable `mode-line-process' has been changed from
> string to list.
Wouldn't it be better to, e.g., add a function to
compilation-finish-functions so that pconf would stop depending on the
exact modeline format used by compile.el?
next prev parent reply other threads:[~2018-09-01 2:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 3:28 bug#32564: 27.0.50; cedet/ede/pconf.el Pierre Lorenzon
2018-09-01 2:16 ` Noam Postavsky [this message]
2018-09-01 3:38 ` Pierre Lorenzon
2018-09-17 0:39 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhx2q7wh.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=32564@debbugs.gnu.org \
--cc=cedet-devel@lists.sourceforge.net \
--cc=devel@pollock-nageoire.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).