From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32672: 27.0.50; image resize on window resizing Date: Sun, 23 Sep 2018 01:15:06 +0300 Organization: LINKOV.NET Message-ID: <87zhw9xjpx.fsf@mail.linkov.net> References: <87pnxmyjgt.fsf@mail.linkov.net> <87ftyfoakb.fsf@mail.linkov.net> <5B98B33D.7000605@gmx.at> <871s9ycnjl.fsf@mail.linkov.net> <5B9A15DA.5000403@gmx.at> <87efdxnfww.fsf@mail.linkov.net> <5B9B7253.5060808@gmx.at> <87pnxexr2m.fsf@mail.linkov.net> <5B9E1E0E.7070805@gmx.at> <87h8ip2eby.fsf@mail.linkov.net> <5B9F4DBD.5020009@gmx.at> <877ejjzr9s.fsf@mail.linkov.net> <5BA20763.8070305@gmx.at> <875zz1t6y1.fsf@mail.linkov.net> <5BA34D7E.4030509@gmx.at> <87fty3sp6a.fsf@mail.linkov.net> <5BA490E5.5090506@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1537664163 26443 195.159.176.226 (23 Sep 2018 00:56:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Sep 2018 00:56:03 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 32672@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 23 02:55:59 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3sgo-0006lH-Fx for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Sep 2018 02:55:58 +0200 Original-Received: from localhost ([::1]:37471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3siv-0004rK-6v for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Sep 2018 20:58:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3sYp-0000iM-3z for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2018 20:47:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3rhK-0006MB-6O for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2018 19:52:29 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45790) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g3rhJ-0006Kw-Px for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2018 19:52:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g3qcA-0000eD-0B for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2018 18:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Sep 2018 22:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32672 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32672-submit@debbugs.gnu.org id=B32672.15376561412414 (code B ref 32672); Sat, 22 Sep 2018 22:43:01 +0000 Original-Received: (at 32672) by debbugs.gnu.org; 22 Sep 2018 22:42:21 +0000 Original-Received: from localhost ([127.0.0.1]:50013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3qbV-0000cr-Bj for submit@debbugs.gnu.org; Sat, 22 Sep 2018 18:42:21 -0400 Original-Received: from pop.dreamhost.com ([64.90.62.162]:34576 helo=pdx1-sub0-mail-a31.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3qbT-0000cj-E4 for 32672@debbugs.gnu.org; Sat, 22 Sep 2018 18:42:20 -0400 Original-Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id 2EAFF7F382; Sat, 22 Sep 2018 15:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=sLNgik6nJyg0nXYfwRBbYQCs+64=; b= WkA/68w0gbw2S0AqFLesZhQWnNFGzDknGdBI2J7K4xd2hty5SZAVCL8cwjtkWO68 BygEjc0f06+8RbGkTw7r1Ql4EGA3Q9o8MbQ6edRVvnIvPXmvXq9yrVse1ByaDT0n vLBO1cpXH6ljB7ewB+SFlxPCmVHWVPrQiBwmPnSlAJk= Original-Received: from localhost.linkov.net (m91-129-111-128.cust.tele2.ee [91.129.111.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id 483877F381; Sat, 22 Sep 2018 15:42:14 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a31 X-DH-BACKEND: pdx1-sub0-mail-a31 In-Reply-To: <5BA490E5.5090506@gmx.at> (martin rudalics's message of "Fri, 21 Sep 2018 08:34:13 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150553 Archived-At: >> (add-hook 'change-major-mode-hook 'image-toggle-display-text nil t) >> (add-hook 'after-revert-hook 'image-after-revert-hook nil t) >> + (add-hook 'window-size-change-functions (debounce 'image-size-window-change 1) nil t) >> + (add-hook 'buffer-list-update-hook 'image-size-buffer-change nil t) > > Shouldn't you debounce the call to 'image-size-buffer-change' as well? > After all, the buffer list seems to change more often than the size of > windows. When I tried debounce for buffer-list-update-hook, it used the last call in sequence: 1 ... current: *scratch* ... window-buffer: *scratch* 2 ... current: *scratch* ... window-buffer: *info* that was unsuitable for the logic of 'image-size-buffer-change'. So maybe instead of 'debounce', we need to implement and use 'throttle' or at least implement the 'immediate' option that uses the first call: https://css-tricks.com/debouncing-throttling-explained-examples/ > In either case you probably want me to install the > 'buffer-list-update-hook' changes. Correct? Yes, please install it, if you see no more regressions.