From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs,gmane.emacs.devel Subject: bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691) Date: Mon, 17 Dec 2018 13:38:33 +0100 Message-ID: <87zht45nw6.fsf@gmx.de> References: <20181216233936.208568-1-phst__21526.1563113474$1545003551$gmane$org@google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1545050233 30466 195.159.176.226 (17 Dec 2018 12:37:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2018 12:37:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Philipp Stephani , 28691@debbugs.gnu.org, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 17 13:37:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYs8y-0007nV-4O for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2018 13:37:08 +0100 Original-Received: from localhost ([::1]:46429 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYsB3-0003KW-P6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2018 07:39:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYsAr-0003Id-Iy for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 07:39:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYsAo-0000cT-Ao for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 07:39:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46702) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gYsAo-0000cN-6V for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 07:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gYsAn-0002US-VR for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 07:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Dec 2018 12:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28691 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28691-submit@debbugs.gnu.org id=B28691.15450503279550 (code B ref 28691); Mon, 17 Dec 2018 12:39:01 +0000 Original-Received: (at 28691) by debbugs.gnu.org; 17 Dec 2018 12:38:47 +0000 Original-Received: from localhost ([127.0.0.1]:50960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYsAY-0002Ty-M2 for submit@debbugs.gnu.org; Mon, 17 Dec 2018 07:38:46 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:52929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYsAW-0002Tk-PI for 28691@debbugs.gnu.org; Mon, 17 Dec 2018 07:38:45 -0500 Original-Received: from detlef.gmx.de ([212.86.54.89]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M6874-1hMpIE1zWk-00y7Op; Mon, 17 Dec 2018 13:38:36 +0100 In-Reply-To: <20181216233936.208568-1-phst__21526.1563113474$1545003551$gmane$org@google.com> (Philipp Stephani's message of "Mon, 17 Dec 2018 00:39:36 +0100") X-Provags-ID: V03:K1:EtxxBZ5vDM8VWYZDnyQW0/9SZnomyO6oW2yB13afiNXTA5smcJg 19nsq5NdVTIDt0MYR5wQOjRHV0FLg4Iolcp6aU87aGcA96EfyS/gttj5H+CVfQedswfoz1I Xd36XpqeOBhcvRxRI7YMVFawxZw9UQZk7joZxzragFJCxLCA4nvYSJtIRePPOvv7TW/DDJf uyw+hnuxnXa4Q8Ow5m6jQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:vJ81hFTj8qo=:r27qdwLu9WJEyk+UfApMSO +ucifdUojPACDGUCePQyzzrVrMZsGFn38LhR9MWJJ5NXQs+lFcXzpVtQvWFgVwxPnv2yIhaE3 Rh418Mx5o1EPtEntfeDeqm0K7xwN//w7lsKMpVu/eSKa1X26f+sytm/sJh6IkdxkN986XNRF/ ClUsQGaeIGVWDZModwc9nLEFn5uSSAKPcm2rNnZvpAJAxowDWeKMP6ekn9vhJAtT15nvt1AvD d9bMQ68da+HtLumZXnhKOPNXm6y1IkjM+IvRNyyiZ57ApxbSdlSYGyh14/RkuvNy279SVocfP Va2vGJCYnZdZfEGRJYLBjokitU89tDyQawaDQ/QtEjrlenyYsKtmYFtj8zja4Lr87LRwyCimB giO6gm9uJ4t3qmUNAyGGeey9DKqlfEfv/kcxfCXtUOs5nAC7PYNaun9w8CdUO5bhQQrEEvhc8 DP9UwZV9E0oSxGb+Yhzp2r+/Dy8kezAOYjDasHnMNZR6gcu2zuygLGjO4DMua1+g8AiOAUh+q xSalfJyYKqkq7Mb9SJhW1lJcoRV/mZYn2fHYFv1OAHcDGZz+Rj5h6SLTiSD18I8payQECHOIo VWqI+6m7HHFD6TqBmbKHXKCSOZXLHZqF/W8wKKydg1GkBS7/f8otdo19zl0XyDIOxvhsxV6GH qJwmeaDyP8pcLMg7cGmEkUP8GJ2O5bqMcpIrbqgkMeqFWgrBRwGx3AbLAuisbYQw3jY5lunNm WTRjnUsdkAk4aUFa8nGtI5ZvYRIbdcC5SWbx+cB03HsTxujV0oYIUTwaYHDC49aXzj7PUQOC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153511 gmane.emacs.devel:231873 Archived-At: Philipp Stephani writes: Hi Philipp, > +:file-handler FILE-HANDLER -- If FILE-HANDLER is non-nil, then search > +for a file name handler for `default-directory'. What happens, if no file name handler is found? Should there be a local process then, or should this be ignored (returning nil)? > +(ert-deftest make-process/file-handler () > + "Check that the =E2=80=98:file-handler=E2=80=99 argument of =E2=80=98m= ake-process=E2=80=99 > +works as expected." > + (let ((file-handler-calls 0)) > + (cl-flet ((file-handler > + (&rest args) > + (should (equal default-directory "test-handler:/dir/")) > + (should (equal args '(make-process :name "name" > + :command ("/bin/true") > + :file-handler t))) > + (cl-incf file-handler-calls) > + 'fake-process)) > + (let ((file-name-handler-alist > + (cons (cons (rx bos "test-handler:") #'file-handler) > + file-name-handler-alist)) > + (default-directory "test-handler:/dir/")) > + (should (eq (make-process :name "name" > + :command '("/bin/true") > + :file-handler t) > + 'fake-process)) > + (should (=3D file-handler-calls 1)))))) I would make a second test, that calling `make-process' w/o the `:file-handler' argument returns the plain process #. The third test is for using non-nil `:file-handler', w/o finding one. This returns either a local process, or nil (see remark above). I also miss documentation in the Elisp manual, nodes "Magic File Names" and "Asynchronous Processes". And of course, the implementation of a file name handler is missing in tramp-adb.el, tramp-sh.el and tramp-smb.el. Best regards, Michael.