From: Deus Max <deusmax@gmx.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 34973@debbugs.gnu.org
Subject: bug#34973: 27.0.50; gnus-summary-move-article fails due to remhash
Date: Mon, 25 Mar 2019 02:09:02 +0200 [thread overview]
Message-ID: <87zhpju869.fsf@aia00054aia.gr> (raw)
In-Reply-To: <875zs82ukz.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 24 Mar 2019 14:52:28 +0000")
On Sun, Mar 24 2019, Basil L. Contovounesios wrote:
> tags 34973 patch
> quit
>
>
>
> Deus Max <deusmax@gmx.com> writes:
>
>> Reading the manual
>> (https://www.gnu.org/software/emacs/manual/html_node/elisp/Hash-Access.html#Hash-Access)
>> on remhash, it says: "In Emacs Lisp, remhash always returns nil.", so I
>> modified the calling function gnus-dup-unsuppress-article in gnus-dup.el, as follows:
>>
>> 157c157,159
>> < (remhash id gnus-dup-hashtb))))
>> ---
>>> (if (hash-table-p gnus-dup-hashtb)
>>> (remhash id gnus-dup-hashtb)
>>> nil))))
>>
>> This patch seems to have fixed the problem and now
>> gnus-summary-move-article works fine. !
>> the value of gnus-dup-hashtb was nil, for the problem runs.
>
> The return value of gnus-dup-unsuppress-article doesn't matter, only
> that remhash not be passed a nil gnus-dup-hashtb.
>
> In other words, gnus-dup-unsuppress-article should either not be called
> or should handle the case when it is called before gnus-dup-open has
> initialised gnus-dup-hashtb.
>
> I attach a patch which follows the apparent gnus-sum.el convention of
> guarding calls to gnus-dup.el functions based on the value of
> gnus-suppress-duplicates.
>
Of course, much better.
Thank you.
> This fixes the immediate issue at hand, but I think there may still be a
> problem when gnus-suppress-duplicates is enabled at a later time. I
> think that deserves a separate bug report, though.
>
> Thanks,
next prev parent reply other threads:[~2019-03-25 0:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 13:00 bug#34973: 27.0.50; gnus-summary-move-article fails due to remhash Deus Max
2019-03-24 14:52 ` Basil L. Contovounesios
2019-03-24 17:12 ` Eric Abrahamsen
2019-03-25 0:09 ` Deus Max [this message]
2019-03-24 15:00 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhpju869.fsf@aia00054aia.gr \
--to=deusmax@gmx.com \
--cc=34973@debbugs.gnu.org \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).