unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Peter Milliken <peter.milliken@gmail.com>
Cc: 33441@debbugs.gnu.org, eggert@cs.ucla.edu
Subject: bug#33441: reading and printing Lisp Objects - what changed from 25.3.1 to 26.1?
Date: Tue, 02 Apr 2019 09:29:53 -0400	[thread overview]
Message-ID: <87zhp8fsby.fsf@gmail.com> (raw)
In-Reply-To: <CAA0nDNs6J0ot8xsM4xQeHg8Jhk90+3TzEsAtsrAn-c51h2Sn4Q@mail.gmail.com> (Peter Milliken's message of "Tue, 2 Apr 2019 13:51:31 +1100")

Peter Milliken <peter.milliken@gmail.com> writes:

> (cl-defmethod dump-language-to-file ((obj else-repository) name to-file)
>   (let ((language-to-dump (access-language else-Language-Repository name))
>         (write-marker nil)
>         (language-output-buffer nil)
>         (print-circle t))  <-------------------- new line

> I tried this and the read code still throws an error when reading the
> objects back from the file.

I tried it here; this time the error isn't from reading, but from
add-element "Attempting to add an illegal object to language".  So this
means it really is the same problem as in bug#29220: that newly read
objects don't have the right type.

A quick demo:

    (require 'eieio)

    (defclass foo ()
      ())

    (let ((print-circle t)
          (foo-obj (make-instance 'foo)))
      (cl-assert (foo-p foo-obj))
      ;; This assertion fails!
      (cl-assert (foo-p (read (prin1-to-string foo-obj)))))





      reply	other threads:[~2019-04-02 13:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20  7:21 bug#33441: reading and printing Lisp Objects - what changed from 25.3.1 to 26.1? Peter Milliken
2018-11-20 20:56 ` Paul Eggert
2018-11-20 21:02   ` Noam Postavsky
2018-11-20 21:09     ` Peter Milliken
2018-11-20 21:17       ` Paul Eggert
2018-11-20 21:19       ` Noam Postavsky
2018-11-21  1:52         ` Peter Milliken
2018-11-21  3:27           ` Basil L. Contovounesios
2018-11-21  3:46           ` Eli Zaretskii
2018-11-21  4:21             ` Peter Milliken
2018-11-23  7:12               ` Paul Eggert
2019-04-01 23:55               ` Noam Postavsky
2019-04-02  2:51                 ` Peter Milliken
2019-04-02 13:29                   ` Noam Postavsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhp8fsby.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=33441@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=peter.milliken@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).