unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#34993: 27.0.50; Repeated call to custom-add-option in esh-mode.el
@ 2019-03-25 14:11 Mauro Aranda
  2019-04-04  2:56 ` Noam Postavsky
  0 siblings, 1 reply; 2+ messages in thread
From: Mauro Aranda @ 2019-03-25 14:11 UTC (permalink / raw)
  To: 34993


[-- Attachment #1.1: Type: text/plain, Size: 267 bytes --]

Tags: patch

esh-mode.el has a repeated call to 'custom-add-option':
(custom-add-option 'eshell-pre-command-hook 'eshell-push-command-mark)

From context, I assume the latter was intended for a different second
argument.  The patch is attached.

Best regards,
Mauro.

[-- Attachment #1.2: Type: text/html, Size: 393 bytes --]

[-- Attachment #2: 0001-Fix-repeated-call-to-custom-add-option-in-esh-mode.e.patch --]
[-- Type: text/x-patch, Size: 894 bytes --]

From d53841aa11da3a98a6ab56e1214dc3ab67f74217 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Mon, 25 Mar 2019 10:38:39 -0300
Subject: [PATCH] Fix repeated call to 'custom-add-option' in esh-mode.el

* lisp/eshell/esh-mode.el: Call 'custom-add-option' with the right
argument.
---
 lisp/eshell/esh-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el
index 3029876..0a160b9 100644
--- a/lisp/eshell/esh-mode.el
+++ b/lisp/eshell/esh-mode.el
@@ -551,7 +551,7 @@ eshell-goto-input-start
 9term behavior."
   (goto-char eshell-last-input-start))
 
-(custom-add-option 'eshell-pre-command-hook 'eshell-push-command-mark)
+(custom-add-option 'eshell-pre-command-hook 'eshell-goto-input-start)
 
 (defsubst eshell-interactive-print (string)
   "Print STRING to the eshell display buffer."
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#34993: 27.0.50; Repeated call to custom-add-option in esh-mode.el
  2019-03-25 14:11 bug#34993: 27.0.50; Repeated call to custom-add-option in esh-mode.el Mauro Aranda
@ 2019-04-04  2:56 ` Noam Postavsky
  0 siblings, 0 replies; 2+ messages in thread
From: Noam Postavsky @ 2019-04-04  2:56 UTC (permalink / raw)
  To: Mauro Aranda; +Cc: 34993

tags 34993 fixed
close 34993 27.1
quit

Mauro Aranda <maurooaranda@gmail.com> writes:

> esh-mode.el has a repeated call to 'custom-add-option':
> (custom-add-option 'eshell-pre-command-hook 'eshell-push-command-mark)
>
> From context, I assume the latter was intended for a different second
> argument.  The patch is attached.

Yep, looks like a copy-pasto, I pushed your patch to master.

[1: 64925714ef]: 2019-04-03 22:41:39 -0400
  Fix repeated 'custom-add-option' in esh-mode.el (Bug#34993)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=64925714ef6b4d7485e5aee7a8ac063c20c07bc5





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-04  2:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-25 14:11 bug#34993: 27.0.50; Repeated call to custom-add-option in esh-mode.el Mauro Aranda
2019-04-04  2:56 ` Noam Postavsky

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).