From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35238: 27.0.50; Clarify eventp behaviour with booleans Date: Sat, 13 Apr 2019 18:53:12 +0100 Message-ID: <87zhothjw7.fsf@tcd.ie> References: <87pnpsp3jd.fsf@tcd.ie> <87y34fscl6.fsf@tcd.ie> <83bm1bmmml.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="142548"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35238@debbugs.gnu.org, monnier@IRO.UMontreal.CA To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 13 19:54:54 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFMrd-000avh-8H for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Apr 2019 19:54:53 +0200 Original-Received: from localhost ([127.0.0.1]:54320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFMrc-00013C-3m for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Apr 2019 13:54:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFMqp-0000hB-OT for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 13:54:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFMqo-0000sD-MF for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 13:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45482) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hFMqo-0000rt-FW for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 13:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hFMqo-0005xa-6R for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 13:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2019 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35238 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35238-submit@debbugs.gnu.org id=B35238.155517800722867 (code B ref 35238); Sat, 13 Apr 2019 17:54:02 +0000 Original-Received: (at 35238) by debbugs.gnu.org; 13 Apr 2019 17:53:27 +0000 Original-Received: from localhost ([127.0.0.1]:59026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFMqF-0005wk-1X for submit@debbugs.gnu.org; Sat, 13 Apr 2019 13:53:27 -0400 Original-Received: from mail-ed1-f49.google.com ([209.85.208.49]:44054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFMqD-0005wX-5F for 35238@debbugs.gnu.org; Sat, 13 Apr 2019 13:53:25 -0400 Original-Received: by mail-ed1-f49.google.com with SMTP id i13so378738edf.11 for <35238@debbugs.gnu.org>; Sat, 13 Apr 2019 10:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=gg5UHCJl8KxZtOnGAN97S6HMxh7jrhtS9ZDXjYtuh9Y=; b=DayDT2E6yvzfkLvqNk6DPoCSWaxBAaCZZSCvOGBJ/H1jb6Nn+eDSyTpqZZTJF+bmZy coeqX2ttpByEgZjMyfBEKema2lfmGOvryLZOU9Yyu2/Ucn33L7Hf5Muy7FK/9FUKru/0 ULJUgbOXiJ0IOEFbsD0gYS77OiM4IBCd2DyCrn9FTnqK/F1wBWotznbmYGCJL8R4naz9 EqVAWzmoD8hRuraVskcsTmO1tUCnbFh/UgNbkcwNRco1CtzHjxJmau1wfu2DcihazjUr T5Xe494hrSyiMsd3GiSyCJMxKOQDspFgbWP6gmZ4NVkkYvTTjMJuGcIU/LUVcbwQt3ps x8VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=gg5UHCJl8KxZtOnGAN97S6HMxh7jrhtS9ZDXjYtuh9Y=; b=ruv6FaVOJzBObWh67PmsJHf43oOwgK9x5iWwYTXrHYy1t3eQw7mZtzo4nJZel20iNB h2i9NzcSBTytSmFkvoihTI1y54d+YLQJXx4AtYGa794t5w7TM62OMOMRNXUjJqEmpk15 PTZ51g00jMzZZZ2eZsDvhc1kx8e2CXcotiQdaAKBCZO0U6pGpdkINDPRqqnAbR5tq+eU 4NVA1GC6Nl9WLnJYrQbK/6FmUuhNsGWTKeFOwcAT1bCjTaOQRmtG60LdfroIzpGulBDd O7DShV3f1pGMMjf+ZW2EaBXFaVBGyVFRKs27Rt6BpEksmepvE/EUOo3J/xkao7KtWnMB 54KA== X-Gm-Message-State: APjAAAWaC9Y53lBv7HZGY+5QFzLETTt8qXLo+7cHOcf5xq+pr5kkobdB NTDul171KKamkVI8ZGAx6rj4Wg== X-Google-Smtp-Source: APXvYqx0wUkaRttq2cqe018npl1M0n5Q7MYHRQMA33n0ZXzYVN9oa94qwenyVL2UglU8P28qRZKybw== X-Received: by 2002:a17:906:a841:: with SMTP id dx1mr33192135ejb.99.1555177999362; Sat, 13 Apr 2019 10:53:19 -0700 (PDT) Original-Received: from localhost ([86.43.103.106]) by smtp.gmail.com with ESMTPSA id c38sm757684ede.61.2019.04.13.10.53.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 13 Apr 2019 10:53:18 -0700 (PDT) In-Reply-To: <83bm1bmmml.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Apr 2019 15:30:42 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157586 Archived-At: Eli Zaretskii writes: > Please make sure the ELisp manual is kept in sync. While skimming the manual, I came across recent-keys in (info "(elisp) Recording Input"). Stefan extended this function in Emacs 25.1[1] with an optional argument INCLUDE-CMDS which causes it to output "events of the form (nil . COMMAND)". (The manual wasn't updated to document this alternative behaviour, but I can do that in addition to / instead of the eventp change if one of ye doesn't beat me to it.) The question is, should eventp continue returning non-nil for these events of the form (nil . COMMAND)? Or should recent-keys be changed to return a different form of event? If my assumption is correct that the former option is preferred, I will check that the manual documents such events consistently instead of changing the behaviour of eventp. Note that (seq-every-p #'eventp (recent-keys t)) is currently non-nil, and the only caller that specifies INCLUDE-CMDS non-nil is view-lossage, which doesn't rely on eventp. [1: eca1ea9655]: * lisp/help.el (view-lossage): ... 2014-11-09 21:58:52 -0500 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=eca1ea96559e04e18a62a61208d501c557dd4cab > Also, does this need to be called out in NEWS? Depends on what actually ends up needing to be changed, I think. My original intention to treat events of the form (nil ...) as nil now seems less plausible, so the only changes I foresee are docfixes. Thanks, -- Basil