From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 35238@debbugs.gnu.org, monnier@IRO.UMontreal.CA
Subject: bug#35238: 27.0.50; Clarify eventp behaviour with booleans
Date: Sat, 13 Apr 2019 18:53:12 +0100 [thread overview]
Message-ID: <87zhothjw7.fsf@tcd.ie> (raw)
In-Reply-To: <83bm1bmmml.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Apr 2019 15:30:42 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Please make sure the ELisp manual is kept in sync.
While skimming the manual, I came across recent-keys in (info "(elisp)
Recording Input"). Stefan extended this function in Emacs 25.1[1] with
an optional argument INCLUDE-CMDS which causes it to output "events of
the form (nil . COMMAND)".
(The manual wasn't updated to document this alternative behaviour, but I
can do that in addition to / instead of the eventp change if one of ye
doesn't beat me to it.)
The question is, should eventp continue returning non-nil for these
events of the form (nil . COMMAND)? Or should recent-keys be changed to
return a different form of event? If my assumption is correct that the
former option is preferred, I will check that the manual documents such
events consistently instead of changing the behaviour of eventp.
Note that (seq-every-p #'eventp (recent-keys t)) is currently non-nil,
and the only caller that specifies INCLUDE-CMDS non-nil is view-lossage,
which doesn't rely on eventp.
[1: eca1ea9655]: * lisp/help.el (view-lossage): ...
2014-11-09 21:58:52 -0500
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=eca1ea96559e04e18a62a61208d501c557dd4cab
> Also, does this need to be called out in NEWS?
Depends on what actually ends up needing to be changed, I think.
My original intention to treat events of the form (nil ...) as nil now
seems less plausible, so the only changes I foresee are docfixes.
Thanks,
--
Basil
next prev parent reply other threads:[~2019-04-13 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 22:42 bug#35238: 27.0.50; Clarify eventp behaviour with booleans Basil L. Contovounesios
2019-04-11 23:42 ` Stefan Monnier
2019-04-12 11:11 ` Basil L. Contovounesios
2019-04-12 12:25 ` Stefan Monnier
2019-04-12 12:30 ` Eli Zaretskii
2019-04-13 17:53 ` Basil L. Contovounesios [this message]
2019-04-14 3:13 ` Stefan Monnier
2019-04-22 23:19 ` Basil L. Contovounesios
2019-04-23 2:06 ` Stefan Monnier
2019-05-07 17:08 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhothjw7.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=35238@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).