From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#33400: [PATCH] Let dir locals for more specific modes override those from less Date: Mon, 29 Apr 2019 14:58:34 +0200 Message-ID: <87zho9vuh1.fsf@gmx.de> References: <87tvkiwk6g.fsf@yahoo.co.uk> <20181115180117.10423-1-bpeeluk@yahoo.co.uk> <87v9yzpbls.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="196946"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Neil Roberts , 33400@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 29 15:00:53 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hL5ts-000p53-09 for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 15:00:52 +0200 Original-Received: from localhost ([127.0.0.1]:57393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL5tr-0004UE-3Y for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 09:00:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL5sB-0003SB-Ec for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 08:59:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hL5s9-0001C0-Ek for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 08:59:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53329) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hL5s6-0001At-Jb for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 08:59:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hL5s6-0001rF-Gp for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 08:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33400 X-GNU-PR-Package: emacs Original-Received: via spool by 33400-submit@debbugs.gnu.org id=B33400.15565427267118 (code B ref 33400); Mon, 29 Apr 2019 12:59:02 +0000 Original-Received: (at 33400) by debbugs.gnu.org; 29 Apr 2019 12:58:46 +0000 Original-Received: from localhost ([127.0.0.1]:38638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL5rq-0001qi-2O for submit@debbugs.gnu.org; Mon, 29 Apr 2019 08:58:46 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:32873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL5rn-0001qS-E2 for 33400@debbugs.gnu.org; Mon, 29 Apr 2019 08:58:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556542716; bh=/P+1eq/02dv731BwN6pjkwOyIJ7eJ2oswugPrwMl1Os=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=jUtddzQ6MoqsbNnGRfRa6d7KbHttxdS4/Un7PbV2BZoHQUL8CsgWvwcC57EfwiWb4 QaNQng80l9nnuYGumfDV3SjESMj8lpW++PcV918wlTjgk1BcuXm2dazSskQHZm+0SQ OxH3j008PAv+DYtsZIZdlPaY5Y8o9sMGOnnQYLPQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([213.220.159.69]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M5QJD-1hKGWE3LiX-001VST; Mon, 29 Apr 2019 14:58:35 +0200 In-Reply-To: <87v9yzpbls.fsf@gmail.com> (Noam Postavsky's message of "Sat, 27 Apr 2019 14:05:51 -0400") X-Provags-ID: V03:K1:KK0DD9pXWn9zql1W7hLO23jfHrTiJF2wHmyc140nW7eHvn2p9pW TRmKpZGOqC9Q8n3HuIrFHwGOY9cITXxgR+lLtiXYyQF0gf0HAcI4Qh5Rqu6RZmITRzIYd1O OIFZeiZAkCvJpZYIgS0ZuOSLiCS7l9eGtOGeo6OaZuwl4MtNTsP7KW8CaN47eBAtCl2x7zx fjDSnU/tXZ3qN8WsGy99Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:O0jcxynKYmo=:mN8WsRAqlUVAZm04/hpxPy nh6+8ZpVUsjt9Kd8OJpdIlEv3ivSieTlqLOO5ztXtJAMiekomDWrJUFUzVa2iWzzIEHDQmeXa 61fKHbUpUlSlOHeIoWOt73nRl3YdbtsO0dDl0pjj5teRbL2UocFw3aVVmrmVh11DPJPnlDYUh 8wUSmgWcU5xGRt/N21WqP39D7Qnat5jRq9JMlKRsmb6irn90bY+hAFamGHBxDNXOXnxNuJ150 CIwOnoN48IBF/BeOo4SuxzhQHFsbYHUXU9vvDdKcPtskk2z694Vlz5ZCDxSKTMcH4obJG3Toa W1qU6IrYVnMs+guULhBqgdCdzKm/H3Sg4UK3jhuOOLLEIuY+4IiSsepsnVRJISJwgQyALnUIf poiVbwl26ZsQv42J3fh50VROmUpbnS5TMcuABE4ivNCYWe7kfSsZ/5Kl3hv7sYCP5bbruw/x0 En5ujf5v4qdo2RyH4uZj/erdRlGqxr/8loMaLxB8+Joke/OWZVpV2etd0E7a/PweXWjJofvay b4ccuDU95ldEeblileCR2YOfJCOjbSXfFAaNX1Vb0hgdLN5uie7BKO0Ptp0VwfOvMQ/fBbBLD mbEMdBqE9ySQBHDys3nyHYAU6u57DVoO5lpIxRrNjypo3fTy6b98mHrThNlIfd+bXDYC05LeP 8KtOrHKec/4lNGyiwiHUx/ZcRLzgQogWH3f0zofW8Xs1fC0UxPs0jlgb8ZzG4A72CMAOlITG6 jRFCmndtIEv8H0LzGMzOhgYc5igIGRgKvMlciYwbZQoOpoMx2+XYfWfcwTBDac+I5nq09JIC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158427 Archived-At: Noam Postavsky writes: >> The list of dir local variables to apply is now sorted by the number >> of parent modes of the mode used as the key in the association >> list. That way when the variables are applied in order the variables >> from more specific modes will override those from less specific modes. >> >> If there are directory entries in the list then they are sorted in >> order of name length. The list of modes for that dir is then >> recursively sorted with the same mechanism. That way variables tied to >> a particular subdirectory override those in in a parent directory. >> >> Previously the behaviour didn=E2=80=99t seem to be well defined anyway a= nd was >> dependent on the order they appeared in the file. However this order >> was changed in version 26.1 and it probably also depended on the >> number of dir-local files that are merged. > > This patch looks basically good to me (some minor formatting: sentences > should end in double space, and the commit message misses a ChangeLog > formatted entry), but it exceeds to copyright exemption limit. Would > you be willing to sign papers? I also believe the patch is worth to be applied, to the emacs-26 branch. It fixes a regression introduced with Emacs 26.1. I'd appreciate if this behavior, priority of .dir-locals entries, is documented in the Emacs manual. Could this be added to the patch? Thanks, and best regards, Michael.