From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#35675: 27.0.50; Is line-number-at-pos unnecessarily slow? Date: Fri, 10 May 2019 15:55:09 -0500 Message-ID: <87zhnuuj0y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="121992"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.2.0; emacs 27.0.50 To: 35675@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 10 22:56:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPCZ0-000VYT-6H for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 May 2019 22:56:18 +0200 Original-Received: from localhost ([127.0.0.1]:49890 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPCYz-0004r4-6f for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 May 2019 16:56:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPCYo-0004pF-Uw for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 16:56:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPCYn-0001xx-0e for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 16:56:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53907) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPCYj-0001uB-W2 for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 16:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hPCYj-0002Mv-Pd for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 16:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2019 20:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35675 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15575217229056 (code B ref -1); Fri, 10 May 2019 20:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 May 2019 20:55:22 +0000 Original-Received: from localhost ([127.0.0.1]:39218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPCY5-0002M0-UH for submit@debbugs.gnu.org; Fri, 10 May 2019 16:55:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPCY4-0002Lo-7k for submit@debbugs.gnu.org; Fri, 10 May 2019 16:55:20 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:41047) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hPCXz-0000Tg-1R for submit@debbugs.gnu.org; Fri, 10 May 2019 16:55:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPCXy-0004Dy-1R for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 16:55:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPCXw-0000L7-WF for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 16:55:13 -0400 Original-Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]:34818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPCXw-0000Hw-RP for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 16:55:12 -0400 Original-Received: by mail-oi1-x232.google.com with SMTP id a132so5527137oib.2 for ; Fri, 10 May 2019 13:55:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=qLceAgnOWyf8ESpqhNogGqkL8/AcRmDJHXHLWxX6DwQ=; b=ZsMdnSDQ9HSgB6qiZHm31FUZMMf7ZPKgPIyB9WRVyWMjgLF9G9bIynoCjUJf4Brucb 7l/JJURvFDyyfDp3rXxvTZBZSZqqFw9eQKjYxLZZsWbZExITMoaOrVsiQqwekWZEIJWJ x5NpNlRN8zTK7rO/VsBNuUoAVESA3Uh9I7fzoHx48/+ogBep5sC/Z7Op3mVqxBYS4GxV apiyGJUqcYQRZd+usYzTvzuksfiJc289PlOLyN45EwqA6bEm7kNS0u5Ek7h+qz8F3hdB Y3O40Do8XHq9TI3Tu1mslhTj1q6jLI7gy61FzmZs/eKN7VjMRkEEio3EwbtptChoAzUt O/tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=qLceAgnOWyf8ESpqhNogGqkL8/AcRmDJHXHLWxX6DwQ=; b=J6VuV9AlKaRve4WBahkqV3LLKICXhoXKKKeX8W014sLGdctXHsOEs7BEexHxWNvioB NqUqUDKXGVCfbXIIXYsLikXf50zABPOPTfyl/rgLE1oLDW1XzoUWbP4zkSKU8sO7e8BZ H+z7PIh2bd5XtcXxRvRYz3154hns/deZ9QObbU2fLeg/nr5ESzDTABtiFdONxNeyJBTn VYrTedHclL7RQm9/XMLO1ZFnDwf8qve3jHf8LEzcAow4ZV8Xih6WHo3xRP4iarA0olw8 bMKJhYqa9RczujCqrrj2Q1I2MB2WfSL3lygD9wOkSD6X/F8N25zWkVJ19ZR2eN3PRxxk D7eA== X-Gm-Message-State: APjAAAUBChQ2DtDXDDkffII0QjrVHk46UPtClgaudD4YFJJZXvsQQ4o7 p31zOWA+qSpUBIQ470tI1yPt2jJ5 X-Google-Smtp-Source: APXvYqxPXTpy8CG4ZwgagKgIfuKfCRgNKnBSMvM4zAtI6R4Lj633jFC7HZiq1jJr/wJWfQc4oRmHIw== X-Received: by 2002:aca:e354:: with SMTP id a81mr6680721oih.56.1557521710770; Fri, 10 May 2019 13:55:10 -0700 (PDT) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id 189sm2466969oih.26.2019.05.10.13.55.10 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 May 2019 13:55:10 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159055 Archived-At: Hi all - I ran into a bottleneck at line-number-at-pos in ESS's indentation engine. line-number-at-pos basically regex searches forward for \n's and counts them up. This can be slow in a large buffer. It looks like someone else has ran into this issue as well.[1] With the advent of display-line-numbers-mode, I imagine there's a C implementation of line-number-at-pos. I imagine the C implementation is faster. Does it make sense for line-number-at-pos to just use the C implementation? Thanks, Alex Footnotes: [1] https://fuco1.github.io/2018-08-12-WAR-STORY:-When-turning-to-the-profiler-turns-out-to-be-a-good-call.html