From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#35781: Discrepancies between xftfont.c and ftcrfont.c Date: Tue, 21 May 2019 21:03:25 +0200 Message-ID: <87zhnfljeq.fsf@gmail.com> References: <878sv5ou9r.fsf@gmail.com> <87pnofze6n.fsf@gmail.com> <87v9y66x9q.fsf@gmail.com> <03f91c3a5f9c7d823e2d6d9c8dfc7b60.squirrel@weber.math.s.chiba-u.ac.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="268298"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35781@debbugs.gnu.org, Alex Gramiak To: mituharu@math.s.chiba-u.ac.jp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 21 21:04:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTA3Z-0017fq-6e for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 May 2019 21:04:13 +0200 Original-Received: from localhost ([127.0.0.1]:58078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTA3Y-00050x-9m for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 May 2019 15:04:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTA3S-0004yt-FR for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 15:04:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTA3Q-0007v2-NX for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 15:04:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55639) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTA3P-0007uE-7y for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 15:04:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hTA3N-0008AS-Mh for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 15:04:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 May 2019 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35781 X-GNU-PR-Package: emacs Original-Received: via spool by 35781-submit@debbugs.gnu.org id=B35781.155846541631359 (code B ref 35781); Tue, 21 May 2019 19:04:01 +0000 Original-Received: (at 35781) by debbugs.gnu.org; 21 May 2019 19:03:36 +0000 Original-Received: from localhost ([127.0.0.1]:40948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTA2y-00089j-Hw for submit@debbugs.gnu.org; Tue, 21 May 2019 15:03:36 -0400 Original-Received: from mail-wm1-f66.google.com ([209.85.128.66]:50633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTA2v-00089T-RR for 35781@debbugs.gnu.org; Tue, 21 May 2019 15:03:34 -0400 Original-Received: by mail-wm1-f66.google.com with SMTP id f204so4063317wme.0 for <35781@debbugs.gnu.org>; Tue, 21 May 2019 12:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=o7QwRy6ZJ18swoRDyifJ7y97gLH9Uy601ewCOVVok5A=; b=NUwqKa1xll35naj3RSIQo4bDGDGGk0Qp7WiEyoO97Hqxg7fqbXVDesF9HblGIdd515 YBV1INCkE03c4WUYUHOR9K9sNc3SwDJ/nsBFwOO1wkaa6mZkgWEc/54y2BUOWSVYGDIV cp6o8N2teAJJt5SaOtsdWkbr7wL2xj55SilhWu24EWQjV9qWh8s5WYEyLoznZelaGkcr TyCG94fIG/f77ul5pbPc0+eFx0TsewwrPjo8TDbn1BQ0loug6CYfLSJ8yjEYLZfEVhr1 CJTRFlJs1B54NJGkSMn8cyUJmVC6Tc/JZeWpfUEO3Esgr1chRAWiAHDlzuL+hUyts0rF PQ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=o7QwRy6ZJ18swoRDyifJ7y97gLH9Uy601ewCOVVok5A=; b=Ak3sMuum9sV1rRnZALw233m2G/lTBwWIZMbWXBmTn0HtABfUm5nI59Kuvt4436Pbtc mNj6E+Esnb8bg0U2PQ2xEU7hQEFlO/D/Wh2IjcX9uNDk3TaclMAkE2zyP5KGchSNxlXl 4Oy6Lqv1MgD/ljx3vR+mjICNnrt3wcEII3z1IGvYwbe+/voiiKSqk1h+rnggZBFyV6uP YjR3sV6/VOiz/XX/A1UZ4i0MEV+0ASlHnku3ZPL2ytY/dgblA9b1fWhaLNdbKI+gKZBD NNvUg+audeL3CfvfOV7oPrM6sWTP3KMbjXZtDTql0FhZhey8UUjywBa1wmMzpj/5TgM9 6ocw== X-Gm-Message-State: APjAAAWdFyhGlg542hxzVB2maexEoT2EmOiEFuYVRPLG98umTGxyE7YU V+oO/12UsufuG5O4BskRjoNQj3RyEoE= X-Google-Smtp-Source: APXvYqz9Hx2q77YL1a1tMYFkn2X4jjoprM6FqcEyKeSeCgudn5/90nSCZerpk8yKU4YXVfLtnhU0Dg== X-Received: by 2002:a1c:d182:: with SMTP id i124mr4699079wmg.102.1558465407570; Tue, 21 May 2019 12:03:27 -0700 (PDT) Original-Received: from my-little-tumbleweed (71.142.13.109.rev.sfr.net. [109.13.142.71]) by smtp.gmail.com with ESMTPSA id j123sm1345712wmb.32.2019.05.21.12.03.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 May 2019 12:03:26 -0700 (PDT) In-Reply-To: <03f91c3a5f9c7d823e2d6d9c8dfc7b60.squirrel@weber.math.s.chiba-u.ac.jp> (mituharu@math.s.chiba-u.ac.jp's message of "Tue, 21 May 2019 19:59:55 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159614 Archived-At: mituharu@math.s.chiba-u.ac.jp writes: > I tried making ftcrfont_open look much like xftfont_open. > Could you try the attached patch? Thank you for this patch! I applied it on top of cb367c8e0d, and AFAICT this fixes the issue: on both setups where I used to see a difference in hint style[1], the fonts now look the same (i.e. with slight hinting). Things haven't deteriorated on the third setup[2]. I glanced at your patch to try and get a sense of how things worked; from what I can tell you moved some logic from xftfont.c to ftfont.c, which is used by ftcrfont.c, so the XFT and Cairo build would use more common code? (Is there a reason why you left xftfont_add_rendering_parameters in xftfont.c despite adding ftfont_add_rendering_parameters in ftfont.c? Should this function be added to ftfont.h so that xftfont.c gets rid of its duplicate implementation?) (Also, I see you removed some code related to the bitmap_strike_index and ft_size_draw members of struct font_info; is it because whatever this code was doing is now handled by=E2=80=A6 something else in ftfont.c?) (Sorry for these Boeotian questions!) Again, thanks a lot for this patch! [1] Debian stretch (cairo 1.14.8) and Xubuntu 16.04 (cairo 1.14.6). [2] OpenSUSE Tumbleweed (cairo 1.16.0).