From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#36159: [PATCH] auto-revert mode doesn't work when changing buffer file name Date: Tue, 11 Jun 2019 20:02:07 +0200 Message-ID: <87zhmo6lwg.fsf@gmx.de> References: <8736kgjmag.fsf@gmx.de> <7390BA99-AA1F-4A87-85A5-FDCCF3E3C125@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="100565"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36159@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 11 20:11:42 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1halFG-000Q3a-Rk for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 20:11:42 +0200 Original-Received: from localhost ([::1]:33600 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1halFF-0005V9-MX for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 14:11:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42541) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hal73-0006Mw-F6 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 14:03:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hal70-0005zR-PH for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 14:03:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46614) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hal6s-0005ue-GM for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 14:03:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hal6s-00031P-AE for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 14:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36159 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36159-submit@debbugs.gnu.org id=B36159.156027614511574 (code B ref 36159); Tue, 11 Jun 2019 18:03:02 +0000 Original-Received: (at 36159) by debbugs.gnu.org; 11 Jun 2019 18:02:25 +0000 Original-Received: from localhost ([127.0.0.1]:60158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hal6G-00030c-R4 for submit@debbugs.gnu.org; Tue, 11 Jun 2019 14:02:25 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:53045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hal6E-00030M-D9 for 36159@debbugs.gnu.org; Tue, 11 Jun 2019 14:02:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1560276129; bh=sdTVhE5XueTozLjbKhn314M21oPzZmdBQfwRgtSLh0s=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=HRovytd0OmcsRYNj4hJ6PpI/4M+RMc0bQKr803WXvw5Q/8dDcLKoN1VQiFtE8CZwA tLGhesXBpheDDKUdx8Z/PQuqjwfL76RNWWeYmmCRGmRRxCytZusbH9UVdquTyBfXj1 OLP4Bec4MRjhAYymOBwNWAmpfsi3dzHxe/KnEc9A= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.38.115]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M1Ycl-1hXjEA2hEB-0035E2; Tue, 11 Jun 2019 20:02:09 +0200 In-Reply-To: <7390BA99-AA1F-4A87-85A5-FDCCF3E3C125@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Tue, 11 Jun 2019 18:55:41 +0200") X-Provags-ID: V03:K1:tejiZDZ+ms/o7vMYJ+BanU8pJn3b9/NjuKBA6mF0XmFYCQsSast 6FAvnGyiepRhShHkvQetWbchxfChjTBAw19Twqs5q4EG8MgsLoTZzEN12errY02yT3cQ5Eg aOAP3DKPbB9Rdjt/RJJJ76dF5my0YFBjvl9ZItawLYwdm6z5TMntMhzuUuaZ8xgtsKYphtN STxky5IfQXdfQTnKlqctA== X-UI-Out-Filterresults: notjunk:1;V03:K0:IU/SDDAxyPc=:q+DXZOH6wxbthtaPexwkdG xWIqEYMN8v6fdUJg/NWXBIMJLriwL1E8UgxOrAAqBZnPE2rOeQvlibnzw0vfRhaNpYnAATDIF jQkgx6kjd+K+3rW6PEBXTObgEySebHEvTzQ94k8oTSVZrZ8frB5XTZcHM/fHVrDzwpJpvpURK laavT6Z4F5KZV4Sa9nRqaDt1HNZk2EsLwj283j42Z4UetfJ6oC/oIrCC9W6figO6eGwOVduMz W/vSjuFMK1m8jTI4XmySWccQtFCCaqvw1PW0qmq5byOwtxJcjIt1Ln89ya9kz6Q/BadvVcV1P UY/vCaTUOBovtMIkc7dfF22BPrWPOs1Tk8QD+zUc2BxO81p5ITnuqtMmEpKzxuNLvfdekceTc 5CqK8WQIU3+FhXuzEem5vjAA6XJiLaGv/hFxAn+wO7r2lzRMvYFBCqvTKsZA9kFgH6v9RFb6M 0RKnLDli1UieVnCYgEz3ll82/1zSCB5d0zhcX9f+txyyfD2fwl8Hvs593UV2x/tl1t3k+Lnt0 upSHCS2acVrUFiFAXhFYSsEoNzqBh1rmoRrvNBP58EhA7hMPUX3AoTNd3lX0JjsrrqXPahdg4 qOZ/tZLI7bpgQgzaEnCMgmDzswwdlpvquhte0/BGIOEN88CBRYoqTWW3SVPFEz876T0zXUaUW G+lA8C9XF+aXnm0KAIaEO4Atj4PgfKy1uTdUYR2DOB+FnwNnz8XR1ufRUDK+AKiVvd297c9Ef s/CWqVH6mxo5kvIUrkctHL4BQIfE/Z48cVxM32Axe0f+XuhspNgQqRPSJot3YNSdRx+7+xZ6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160398 Archived-At: Mattias Engdeg=C3=A5rd writes: Hi Mattias, >> Since we add it to a hook from another package, it shouldn't be marked >> internal. Call it `auto-revert-set-visited-file-name'. > > Done. I actually wanted to add a buffer-local hook, but it turns out > that `after-set-visited-file-name-hook', as written, wouldn't work for > local hooks -- the very action of `set-visited-file-name' wipes out > local hooks, no doubt for good reasons, before they can trigger. > >> In the other tests, we separate the unwindforms from the bodyform (an >> empty line, plus a comment). Maybe you could do it here as well. > > Done. > I also removed the binding of `auto-revert-avoid-polling' in the new > test, since it isn't strictly necessary to exhibit the bug. Thanks, looks OK. You could push to master, from my pov. >> FAILED auto-revert-test05-global-notify-remote >> FAILED auto-revert-test06-write-file-remote >>=20 >> Do you want to check, or shall I do it? > > Oh, would you do that? I feel bad about causing test failures like this! > The first error may be from a recently committed (f2e4c34de6) fix of > an earlier copy-paste mistake; sorry about that. I'm unsure how to > deal with these errors myself; I have no inotifywait equivalent on > this machine (macOS). Sure, will do. I'll start with auto-revert-test05-global-notify-remote. Once you have pushed, I'll check also auto-revert-test06-write-file-remote. > Thanks a lot for your help! Best regards, Michael.