From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling. Date: Mon, 24 Jun 2019 18:50:58 -0400 Message-ID: <87zhm6silp.fsf@gmail.com> References: <86lglj6bkl.fsf@gavenkoa.example.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="109123"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 28434@debbugs.gnu.org, Oleksandr Gavenko To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 00:52:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfXow-000SGr-NO for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 00:52:19 +0200 Original-Received: from localhost ([::1]:55250 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfXov-0005XI-Hw for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 18:52:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40000) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfXoh-0005VQ-MO for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 18:52:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfXog-0002iM-Pl for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 18:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44721) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfXog-0002iE-Lg for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 18:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfXog-00013P-JA for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 18:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2019 22:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28434 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 28434-submit@debbugs.gnu.org id=B28434.15614166663948 (code B ref 28434); Mon, 24 Jun 2019 22:52:02 +0000 Original-Received: (at 28434) by debbugs.gnu.org; 24 Jun 2019 22:51:06 +0000 Original-Received: from localhost ([127.0.0.1]:58261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfXnm-00011c-Gt for submit@debbugs.gnu.org; Mon, 24 Jun 2019 18:51:06 -0400 Original-Received: from mail-io1-f47.google.com ([209.85.166.47]:42675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfXnk-00010y-RE for 28434@debbugs.gnu.org; Mon, 24 Jun 2019 18:51:05 -0400 Original-Received: by mail-io1-f47.google.com with SMTP id u19so366958ior.9 for <28434@debbugs.gnu.org>; Mon, 24 Jun 2019 15:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RPt0C7/9tbX7HF2PVqUYM6m0ZJpg4BB+yu9MPn6kqKM=; b=j5FNHPosc66tinWL25fgRtuqmDpF2rvrp/etMk5pkBGucQQGu+13J+QcQILV1rhITc mvHAQbRMCRfODVJLg5NseJpPsWtxOdNVFOH+OkICtkNdZ9pwbE7dHkCx3JoKZ2TlFcq9 /dzEIWTZUWYPkMMjZEkdg8x2gSjQwlLqjM4ljG80wMQX8Ir/KjK915Gh40COzYussdnp gbXrawXIlzrZFTgeYpvqaZZBLSUm8nJdHTxHj1Km2XB/fpn4tXUEwRqOUAjW6wsGYGBO +YJDAZn/vtKqLRO/W6mjQcVQAnZv0CVBr9605iIWiD6k3etqN+6ULMjRa6vnrbmBdvc4 XY2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RPt0C7/9tbX7HF2PVqUYM6m0ZJpg4BB+yu9MPn6kqKM=; b=KsPW043vXifYpfCyPQpBU/ILQLPw1oFUsLMpzmukQ1zrpK5WjK3mhjoewkiracc8J4 +yuhXSnbEgbIFQJLIbpZVkgcCb8xNphVOyyf5eX+ADRG7IxCJ0Dbmr6/NnLg1PENfH8R 945JBQIqVV39+Wqg1UURVJHNEusPchD7lZzy/jaJLdA8A9drOGUEgvmknyKdHNmAfK+y 4kuYSe+rYD21vUJagT8Gt62Z31kE33Mcz8lTSwzpw2CXf0t5X6po98Au5VpfSAF85rd+ nHUqOyCjulnQQ9hFhUmZx0F1+ePUoDlWDJ5ODHdg+oExMM3/2Wt+DaVAdSd0GOShH8sr clRw== X-Gm-Message-State: APjAAAW+H5Eg61fTLaKtVCk+3+ovZX6yat+wquWVEDY/VpGW/BWiipj5 d38MZoe1x7Yy3MUvZoYGVyA2e3eM X-Google-Smtp-Source: APXvYqzIOV3gd0s8KapyMvNeDYUq/2NuR5ntOcwclUMj3LvKd3/7z/X5MnwwPHv5u3Vd6GXl2ye6bQ== X-Received: by 2002:a6b:3b89:: with SMTP id i131mr110667121ioa.33.1561416659043; Mon, 24 Jun 2019 15:50:59 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id f4sm23166006iok.56.2019.06.24.15.50.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Jun 2019 15:50:58 -0700 (PDT) In-Reply-To: (Lars Ingebrigtsen's message of "Mon, 24 Jun 2019 18:13:48 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161295 Archived-At: Lars Ingebrigtsen writes: > Oleksandr Gavenko writes: > >> It's very annoying as I have no control over file content and sometime can't >> add final new line. > > I think that's kind of unusual -- most text file formats can end in > newlines. > >> Emacs commands in diff mode should tolerate ``\`` message about missing final >> new line. >> >> ediff-diff-ok-lines-regexp is: >> >> "^\\([0-9,]+[acd][0-9,]+?$\\|[<>] \\|---\\|.*Warning *:\\|.*No +newline\\|.*missing +newline\\|^?$\\)" >> >> and match that line. > > I think if you need this, you should add it to that variable, but I > don't think this would be a good default. Hmm, the "\ No newline at end of file" thing is a de facto standard, so shouldn't Emacs recognize it by default?