From: Noam Postavsky <npostavs@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 28434@debbugs.gnu.org, Oleksandr Gavenko <gavenkoa@gmail.com>
Subject: bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling.
Date: Mon, 24 Jun 2019 18:50:58 -0400 [thread overview]
Message-ID: <87zhm6silp.fsf@gmail.com> (raw)
In-Reply-To: <m3zhm7rmf7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 24 Jun 2019 18:13:48 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Oleksandr Gavenko <gavenkoa@gmail.com> writes:
>
>> It's very annoying as I have no control over file content and sometime can't
>> add final new line.
>
> I think that's kind of unusual -- most text file formats can end in
> newlines.
>
>> Emacs commands in diff mode should tolerate ``\`` message about missing final
>> new line.
>>
>> ediff-diff-ok-lines-regexp is:
>>
>> "^\\([0-9,]+[acd][0-9,]+?$\\|[<>] \\|---\\|.*Warning *:\\|.*No +newline\\|.*missing +newline\\|^?$\\)"
>>
>> and match that line.
>
> I think if you need this, you should add it to that variable, but I
> don't think this would be a good default.
Hmm, the "\ No newline at end of file" thing is a de facto standard, so
shouldn't Emacs recognize it by default?
next prev parent reply other threads:[~2019-06-24 22:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 18:01 bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling Oleksandr Gavenko
2019-06-24 16:13 ` Lars Ingebrigtsen
2019-06-24 22:50 ` Noam Postavsky [this message]
2019-06-24 23:09 ` Lars Ingebrigtsen
2019-06-24 23:58 ` Noam Postavsky
2019-06-25 11:16 ` Lars Ingebrigtsen
2019-06-25 2:41 ` Eli Zaretskii
2022-08-23 9:36 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhm6silp.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=28434@debbugs.gnu.org \
--cc=gavenkoa@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).