From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#21112: 25; Patch: show minibuffer messages with a face Date: Thu, 27 Jun 2019 23:28:52 +0300 Organization: LINKOV.NET Message-ID: <87zhm39bu3.fsf@mail.linkov.net> References: <55AF90B9.5040401@gmail.com> <87si0jvkgv.fsf@gnus.org> <87pnn11nm5.fsf@mail.linkov.net> <87y31orqm1.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="252651"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 21112@debbugs.gnu.org, Raffaele Ricciardi To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 27 23:03:46 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgbYX-0013US-JU for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 23:03:46 +0200 Original-Received: from localhost ([::1]:54500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgbYW-0003E7-Jd for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 17:03:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48150) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgb8i-0001S1-4v for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 16:37:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgb8g-0001Ow-HM for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 16:37:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgb8g-0001OT-79 for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 16:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hgb8g-0006Ox-1h for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 16:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2019 20:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21112 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix patch Original-Received: via spool by 21112-submit@debbugs.gnu.org id=B21112.156166776224474 (code B ref 21112); Thu, 27 Jun 2019 20:37:01 +0000 Original-Received: (at 21112) by debbugs.gnu.org; 27 Jun 2019 20:36:02 +0000 Original-Received: from localhost ([127.0.0.1]:39832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgb7h-0006MU-Qp for submit@debbugs.gnu.org; Thu, 27 Jun 2019 16:36:02 -0400 Original-Received: from bonobo.elm.relay.mailchannels.net ([23.83.212.22]:37987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgb7f-0006MD-Pw for 21112@debbugs.gnu.org; Thu, 27 Jun 2019 16:36:00 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 53406502407; Thu, 27 Jun 2019 20:35:58 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a2.g.dreamhost.com (100-96-11-129.trex.outbound.svc.cluster.local [100.96.11.129]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 82AA6501781; Thu, 27 Jun 2019 20:35:57 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a2.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Thu, 27 Jun 2019 20:35:58 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Hysterical-Hook: 5be485bc6059b485_1561667758146_1734331426 X-MC-Loop-Signature: 1561667758146:847413227 X-MC-Ingress-Time: 1561667758146 Original-Received: from pdx1-sub0-mail-a2.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTP id CE50683DA9; Thu, 27 Jun 2019 13:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=mWKli1lGhjfMWAZh/Rd4/fFAACg=; b= j7gnyFTKojdaG9OQzyYOBYUjAYMHJxcbvcMwMIKvapLT8/Oz8knH96YvZAgTIRnU 80r10Qncs0pyOaqMhZqtD4T5085u9BbQExsjFpA2qaD/BFx9wUAlx3p0yoXztQwB vrSpb+x7NX+hyG0XUfweQABrIgIJWrPuTQsxzmH1l2s= Original-Received: from mail.jurta.org (m91-129-109-60.cust.tele2.ee [91.129.109.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTPSA id DC90883DA7; Thu, 27 Jun 2019 13:35:51 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a2 In-Reply-To: (Lars Ingebrigtsen's message of "Thu, 27 Jun 2019 12:28:35 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudekgdduheefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdelrdeitdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdelrdeitddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehlrghrshhisehgnhhushdrohhrghenucevlhhushhtvghrufhiiigvpedt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161654 Archived-At: >> This patch checks for existing face properties to not overwrite them: > > I'm not really convinced that there should be any face properties on the > minibuffer messages at all, though. :-) Without highlighting of minibuffer messages there is a danger that the message will remain unnoticed, especially in the multiline minibuffer. So minibuffer messages need to be highlighted for the same reason why the minibuffer prompt is already highlighted: 1. to designate non-editable read-only parts of the minibuffer; 2. to help the users to turn attention to the active part of the minibuffer. Thus all informational text in the minibuffer should be highlighted consistently in one color to help not to miss important message. Isn't it so already that elsewhere in Emacs font-lock is used to highlight more important parts of the buffer? PS: I already added configurability in the previous patch, so now we are discussing the default value.