bug#36694: 27.0.50; Test secrets-test03-items is failing

bug#36694: 27.0.50; Test secrets-test03-items is failing

[Basil L. Contovounesios]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

X-Debbugs-Cc: Michael Albinus <michael.albinus@gmx.de>
Severity: minor

On current master on my machine, 'make check' reports one file
containing unexpected results:


[-- Attachment #2: secrets-tests.log --]
[-- Type: text/plain, Size: 1868 bytes --]

Running 5 tests (2019-07-16 18:13:46+0100, selector `(not (or (tag :expensive-test) (tag :unstable)))')
   passed  1/5  secrets-test00-availability (0.007341 sec)
   passed  2/5  secrets-test01-sessions (0.011786 sec)
   passed  3/5  secrets-test02-collections (0.007273 sec)
Test secrets-test03-items backtrace:
  signal(ert-test-failed (((should (equal (secrets-get-attributes "ses
  ert-fail(((should (equal (secrets-get-attributes "session" item) '((
  #f(compiled-function () #<bytecode 0x1573ace03b1d>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name secrets-test03-items :documentation "
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ...)) :te
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/secrets-tests" "
  command-line()
  normal-top-level()
Test secrets-test03-items condition:
    (ert-test-failed
     ((should
       (equal
	(secrets-get-attributes "session" item)
	'...))
      :form
      (equal
       ((:host . "remote-host")
	(:method . "sudo")
	(:user . "joe")
	(:xdg:schema . "org.freedesktop.Secret.Generic"))
       ((:xdg:schema . "org.freedesktop.Secret.Generic")
	(:host . "remote-host")
	(:user . "joe")
	(:method . "sudo")))
      :value nil :explanation
      (list-elt 0
		(car
		 (different-atoms :host :xdg:schema)))))
   FAILED  4/5  secrets-test03-items (0.080947 sec)
   passed  5/5  secrets-test04-search (0.075937 sec)

Ran 5 tests, 4 results as expected, 1 unexpected (2019-07-16 18:13:46+0100, 0.423667 sec)

1 unexpected results:
   FAILED  secrets-test03-items


[-- Attachment #3: Type: text/plain, Size: 1324 bytes --]


For some reason, the test secrets-test03-items expects
secrets-get-attributes to silently put the attribute :xdg:schema at the
beginning of the returned alist, but on my system that attribute is
placed at the end.

Is the precise ordering of attributes significant?  If so, why?  If not,
the test should stop assuming any particular ordering and use
seq-set-equal-p in place of equal.  Patch to this effect to follow.

Thanks,

-- 
Basil

In GNU Emacs 27.0.50 (build 3, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2019-07-16 built on thunk
Repository revision: a87840fffbf471d53eba17ea683728125d2d4767
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux bullseye/sid

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
 --prefix=/home/blc/.local --with-mailutils --with-x-toolkit=lucid
 --with-modules --with-file-notification=yes --with-x'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF
XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS
LIBSYSTEMD JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: en_IE.UTF-8
  locale-coding-system: utf-8-unix

bug#36694: 27.0.50; Test secrets-test03-items is failing

[Basil L. Contovounesios]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> For some reason, the test secrets-test03-items expects
> secrets-get-attributes to silently put the attribute :xdg:schema at the
> beginning of the returned alist, but on my system that attribute is
> placed at the end.
>
> Is the precise ordering of attributes significant?  If so, why?  If not,
> the test should stop assuming any particular ordering and use
> seq-set-equal-p in place of equal.  Patch to this effect to follow.

Here it is:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-failing-secrets-test03-items.patch --]
[-- Type: text/x-diff, Size: 2561 bytes --]

From d2758820cd45733570c704431da3f3e91dbb8605 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Tue, 16 Jul 2019 17:41:18 +0100
Subject: [PATCH] Fix failing secrets-test03-items

* test/lisp/net/secrets-tests.el: Use lexical-binding.
(secrets-test03-items): Do not assume :xdg:schema attribute is
silently added to the front of the collection (bug#36694).
(secrets-test04-search, secrets-test-all): Quote function symbols as
such.
---
 test/lisp/net/secrets-tests.el | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/test/lisp/net/secrets-tests.el b/test/lisp/net/secrets-tests.el
index c565eba567..bab8eb5d18 100644
--- a/test/lisp/net/secrets-tests.el
+++ b/test/lisp/net/secrets-tests.el
@@ -1,4 +1,4 @@
-;;; secrets-tests.el --- Tests of Secret Service API
+;;; secrets-tests.el --- Tests of Secret Service API -*- lexical-binding: t -*-
 
 ;; Copyright (C) 2018-2019 Free Software Foundation, Inc.
 
@@ -21,6 +21,7 @@
 
 (require 'ert)
 (require 'secrets)
+(require 'seq)
 (require 'notifications)
 
 ;; We do not want chatty messages.
@@ -175,10 +176,9 @@ secrets-test03-items
         (dolist (item `("bar" ,item-path))
 	  (should
 	   (string-equal (secrets-get-attribute "session" item :method) "sudo"))
-	  ;; The attributes are collected in reverse order.
-	  ;; :xdg:schema is added silently.
+          ;; The attribute :xdg:schema is added silently.
 	  (should
-	   (equal
+           (seq-set-equal-p
 	    (secrets-get-attributes "session" item)
 	    '((:xdg:schema . "org.freedesktop.Secret.Generic")
               (:host . "remote-host") (:user . "joe") (:method . "sudo")))))
@@ -242,14 +242,14 @@ secrets-test04-search
          (secrets-search-items "session" :xdg:schema "org.gnu.Emacs.foo"))
 	(should
 	 (equal
-	  (sort (secrets-search-items "session" :user "joe") 'string-lessp)
+          (sort (secrets-search-items "session" :user "joe") #'string-lessp)
 	  '("baz" "foo")))
 	(should
 	 (equal
 	  (secrets-search-items "session":method "sudo" :user "joe") '("foo")))
 	(should
 	 (equal
-	  (sort (secrets-search-items "session") 'string-lessp)
+          (sort (secrets-search-items "session") #'string-lessp)
 	  '("bar" "baz" "foo"))))
 
     ;; Exit.
@@ -261,7 +261,7 @@ secrets-test-all
   "Run all tests for \\[secrets]."
   (interactive "p")
   (funcall
-   (if interactive 'ert-run-tests-interactively 'ert-run-tests-batch)
+   (if interactive #'ert-run-tests-interactively #'ert-run-tests-batch)
    "^secrets"))
 
 (provide 'secrets-tests)
-- 
2.20.1


[-- Attachment #3: Type: text/plain, Size: 27 bytes --]


WDYT?

Thanks,

-- 
Basil

bug#36694: 27.0.50; Test secrets-test03-items is failing

[Michael Albinus]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

Hi Basil,

>> For some reason, the test secrets-test03-items expects
>> secrets-get-attributes to silently put the attribute :xdg:schema at the
>> beginning of the returned alist, but on my system that attribute is
>> placed at the end.
>>
>> Is the precise ordering of attributes significant?  If so, why?  If not,
>> the test should stop assuming any particular ordering and use
>> seq-set-equal-p in place of equal.  Patch to this effect to follow.
>
> Here it is:

The order is not relevant. Pls apply your patch.

> Thanks,

Best regards, Michael.

bug#36694: 27.0.50; Test secrets-test03-items is failing

[Basil L. Contovounesios]

tags 36694 fixed
close 36694 27.1
quit

Michael Albinus <michael.albinus@gmx.de> writes:

> The order is not relevant. Pls apply your patch.

Thanks, done:

Fix failing secrets-test03-items
d2758820cd 2019-07-16 18:29:52 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d2758820cd45733570c704431da3f3e91dbb8605

-- 
Basil