bug#18079: Remove redundant spaces in `mode-line-buffer-identification' for `calc-mode'

bug#18079: Remove redundant spaces in `mode-line-buffer-identification' for `calc-mode'

[Oleh]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

Hi,

For some reason there are 14 extra spaces added to
`mode-line-buffer-identification' for `calc-mode'.
Which makes it look weird compared to other buffers, such as *scratch*.
This is especially apparent with a custom mode-line, e.g. powerline package.
I attach a patch.

regards,
Oleh

[-- Attachment #2: 0001-lisp-calc-calc.el-calc-set-mode-line-remove-redundan.patch --]
[-- Type: text/x-patch, Size: 830 bytes --]

From da50e4b19ee8265c164ef79866a8af7f8dc15781 Mon Sep 17 00:00:00 2001
From: Oleh Krehel <ohwoeowho@gmail.com>
Date: Tue, 22 Jul 2014 14:58:06 +0200
Subject: [PATCH] lisp/calc/calc.el (calc-set-mode-line): remove redundant
 spaces

---
 lisp/calc/calc.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/calc/calc.el b/lisp/calc/calc.el
index 04d852e..aa2646e 100644
--- a/lisp/calc/calc.el
+++ b/lisp/calc/calc.el
@@ -1701,7 +1701,7 @@ See calc-keypad for details."
     (let* ((fmt (car calc-float-format))
 	   (figs (nth 1 calc-float-format))
 	   (new-mode-string
-	    (format "Calc%s%s: %d %s %-14s"
+	    (format "Calc%s%s: %d %s %s"
 		    (if (and calc-embedded-info
                              (eq (aref calc-embedded-info 1) (current-buffer)))
                         "Embed" "")
-- 
1.8.4

bug#18079: Remove redundant spaces in `mode-line-buffer-identification' for `calc-mode'

[Lars Ingebrigtsen]

Oleh <ohwoeowho@gmail.com> writes:

> For some reason there are 14 extra spaces added to
> `mode-line-buffer-identification' for `calc-mode'.
> Which makes it look weird compared to other buffers, such as *scratch*.
> This is especially apparent with a custom mode-line, e.g. powerline package.
> I attach a patch.

[...]

> -	    (format "Calc%s%s: %d %s %-14s"
> +	    (format "Calc%s%s: %d %s %s"

That is indeed pretty odd.  Perhaps they wanted to have it equally wide
no matter what settings that are enabled?

Anyway, I think it's a positive change to make this more regular, so
I've applied your patch to Emacs 27.

If there's calc users that somehow found that space useful, then
reverting the commit would be fine, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no