From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#17052: substitute-command-keys strips text properties Date: Sun, 18 Aug 2019 15:43:35 -0700 Message-ID: <87zhk63xig.fsf@mouse.gnus.org> References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> <83sgq2peb5.fsf@gnu.org> <87h86iuk39.fsf@mouse.gnus.org> <83d0h2mlwh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="237100"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: lekktu@gmail.com, Stefan Kangas , 8951@debbugs.gnu.org, 17052@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 19 00:44:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzTuE-000zZX-JU for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Aug 2019 00:44:10 +0200 Original-Received: from localhost ([::1]:43242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzTuD-00060d-Dh for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 18:44:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47295) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzTu7-0005zB-P5 for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 18:44:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzTu6-000414-Ju for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 18:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50068) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzTu6-00040z-Gj for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 18:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hzTu6-00063l-D6 for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 18:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Aug 2019 22:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17052 X-GNU-PR-Package: emacs Original-Received: via spool by 17052-submit@debbugs.gnu.org id=B17052.156616822923268 (code B ref 17052); Sun, 18 Aug 2019 22:44:02 +0000 Original-Received: (at 17052) by debbugs.gnu.org; 18 Aug 2019 22:43:49 +0000 Original-Received: from localhost ([127.0.0.1]:58889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzTts-00063D-S2 for submit@debbugs.gnu.org; Sun, 18 Aug 2019 18:43:49 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:46530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzTto-00062r-3x; Sun, 18 Aug 2019 18:43:44 -0400 Original-Received: from [12.144.191.101] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzTti-0003B2-I4; Mon, 19 Aug 2019 00:43:41 +0200 In-Reply-To: <83d0h2mlwh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 18 Aug 2019 20:19:26 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165358 Archived-At: Eli Zaretskii writes: > Maybe we should first talk a bit about why Lars you think it would be > "pretty trivial" to keep properties in Lisp, but not in C. I'm > probably missing something very basic here, because I don't see why > it would be easier in Lisp. Anything is easier in Lisp, surely. But if you look at that function in particular, it's written in a very C-ey fashion, what with copying over characters one by one etc. It could be rewritten (in C) to use the proper primitives we have that preserve text properties (Fsubstring etc), but then you'd just end up with a more long-winded version that would be Lisp-in-C, so we might as well just rewrite it in Lisp. It'll probably be a fraction of the code length. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no