* bug#37515: 27.0.50; button.el doesn't support help-echo function
@ 2019-09-26 1:14 Katsumi Yamaoka
2019-09-26 1:26 ` Katsumi Yamaoka
0 siblings, 1 reply; 11+ messages in thread
From: Katsumi Yamaoka @ 2019-09-26 1:14 UTC (permalink / raw)
To: 37515; +Cc: Jose A. Ortega Ruiz
Hi,
I found the `forward-button' command shows a Lisp function object
if the value of the `help-echo' text property at the destination
point is a function. But is should be its return value.
,---- (info "(elisp) Special Properties")
| `help-echo'
| If text has a string as its `help-echo' property, then when you
| move the mouse onto that text, Emacs displays that string in the
| echo area, or in the tooltip window (*note Tooltips::).
|
| If the value of the `help-echo' property is a function, that
| function is called with three arguments, WINDOW, OBJECT and POS and
| should return a help string or `nil for none.
`----
So, `forward-button' should be fixed to something like this:
--8<---------------cut here---------------start------------->8---
--- button.el~ 2019-07-30 21:20:12.288879200 +0000
+++ button.el 2019-09-26 01:12:28.492808400 +0000
@@ -513,8 +513,11 @@
nil
(user-error (if wrap "No buttons!" "No more buttons")))
(let ((msg (and display-message (button-get button 'help-echo))))
- (when msg
- (message "%s" msg)))
+ (cond ((functionp msg)
+ (message
+ "%s" (funcall msg (selected-window) (current-buffer) (point))))
+ (msg
+ (message "%s" msg))))
button)))
(defun backward-button (n &optional wrap display-message no-error)
--8<---------------cut here---------------end--------------->8---
Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread* bug#37515: 27.0.50; button.el doesn't support help-echo function 2019-09-26 1:14 bug#37515: 27.0.50; button.el doesn't support help-echo function Katsumi Yamaoka @ 2019-09-26 1:26 ` Katsumi Yamaoka 2019-09-26 13:49 ` Lars Ingebrigtsen 0 siblings, 1 reply; 11+ messages in thread From: Katsumi Yamaoka @ 2019-09-26 1:26 UTC (permalink / raw) To: 37515; +Cc: Jose A. Ortega Ruiz On Thu, 26 Sep 2019 10:14:52 +0900, Katsumi Yamaoka wrote: > So, `forward-button' should be fixed to something like this: The patch I posted last was incomplete. Please replace it with: --8<---------------cut here---------------start------------->8--- --- button.el~ 2019-07-30 21:20:12.288879200 +0000 +++ button.el 2019-09-26 01:26:25.210300000 +0000 @@ -513,6 +513,9 @@ nil (user-error (if wrap "No buttons!" "No more buttons"))) (let ((msg (and display-message (button-get button 'help-echo)))) + (when (functionp msg) + (setq msg (funcall msg (selected-window) (current-buffer) + (button-start button)))) (when msg (message "%s" msg))) button))) --8<---------------cut here---------------end--------------->8--- Thanks. ^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#37515: 27.0.50; button.el doesn't support help-echo function 2019-09-26 1:26 ` Katsumi Yamaoka @ 2019-09-26 13:49 ` Lars Ingebrigtsen [not found] ` <esr-pdhHsyCqhSoZbW_3iLp4UdujyDpcbOuBdPROA9aG3j9CO0niyrK5O_Tf33N-le-e5hmaqbYZLyuNc6kd3A==@protonmail.internalid> 2019-09-26 21:44 ` Katsumi Yamaoka 0 siblings, 2 replies; 11+ messages in thread From: Lars Ingebrigtsen @ 2019-09-26 13:49 UTC (permalink / raw) To: Katsumi Yamaoka; +Cc: Jose A. Ortega Ruiz, 37515 Katsumi Yamaoka <yamaoka@jpl.org> writes: > + (when (functionp msg) > + (setq msg (funcall msg (selected-window) (current-buffer) > + (button-start button)))) Looks good to me; please push. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <esr-pdhHsyCqhSoZbW_3iLp4UdujyDpcbOuBdPROA9aG3j9CO0niyrK5O_Tf33N-le-e5hmaqbYZLyuNc6kd3A==@protonmail.internalid>]
* bug#37515: 27.0.50; button.el doesn't support help-echo function 2019-09-26 13:49 ` Lars Ingebrigtsen [not found] ` <esr-pdhHsyCqhSoZbW_3iLp4UdujyDpcbOuBdPROA9aG3j9CO0niyrK5O_Tf33N-le-e5hmaqbYZLyuNc6kd3A==@protonmail.internalid> @ 2019-09-26 21:44 ` Katsumi Yamaoka 2019-09-26 22:56 ` Jose A. Ortega Ruiz 1 sibling, 1 reply; 11+ messages in thread From: Katsumi Yamaoka @ 2019-09-26 21:44 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: Jose A. Ortega Ruiz, 37515-done On Thu, 26 Sep 2019 15:49:02 +0200, Lars Ingebrigtsen wrote: > Looks good to me; please push. Done. Thanks. ^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#37515: 27.0.50; button.el doesn't support help-echo function 2019-09-26 21:44 ` Katsumi Yamaoka @ 2019-09-26 22:56 ` Jose A. Ortega Ruiz 2019-09-30 19:47 ` Basil L. Contovounesios 0 siblings, 1 reply; 11+ messages in thread From: Jose A. Ortega Ruiz @ 2019-09-26 22:56 UTC (permalink / raw) To: Katsumi Yamaoka; +Cc: Lars Ingebrigtsen, 37515-done On Fri, Sep 27 2019, Katsumi Yamaoka wrote: > On Thu, 26 Sep 2019 15:49:02 +0200, Lars Ingebrigtsen wrote: >> Looks good to me; please push. > > Done. Thanks. Just confirming that i've tried with a freshly compiled emacs and it's working for me too as expected. Thanks! ^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#37515: 27.0.50; button.el doesn't support help-echo function 2019-09-26 22:56 ` Jose A. Ortega Ruiz @ 2019-09-30 19:47 ` Basil L. Contovounesios 2019-09-30 19:53 ` Basil L. Contovounesios 2019-10-01 12:28 ` Lars Ingebrigtsen 0 siblings, 2 replies; 11+ messages in thread From: Basil L. Contovounesios @ 2019-09-30 19:47 UTC (permalink / raw) To: Jose A. Ortega Ruiz; +Cc: Katsumi Yamaoka, Lars Ingebrigtsen, 37515 [-- Attachment #1: Type: text/plain, Size: 569 bytes --] Thank you for working on this, Yamaoka-san. Some further changes are needed to fully support the help-echo property. Firstly, help-echo functions expect an overlay as their second argument when the object that had the property is an overlay (button). Secondly, help-echo values can be forms in addition to strings and functions. Lastly, (info "(elisp) Button Properties") needs updating to reflect the supported values of the help-echo button property. The following patch should do all this. I will push it in the next few days if there are no objections. WDYT? [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-Further-improve-button.el-support-for-help-echo.patch --] [-- Type: text/x-diff, Size: 6823 bytes --] From e91c4b5f6710565344e419b25be496316a1f3e71 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" <contovob@tcd.ie> Date: Fri, 27 Sep 2019 00:04:33 +0100 Subject: [PATCH] Further improve button.el support for help-echo The last change to forward-button added support for help-echo values that are functions. This patch fixes the arguments passed to such functions and further adds support for help-echo values that are forms (bug#37515). * doc/lispref/display.texi (Button Properties): Fix description of help-echo button property. * lisp/button.el (button--help-echo): New function. (forward-button): Use it. (backward-button): Clarify help-echo reference in docstring. * test/lisp/button-tests.el (button--help-echo): New test. --- doc/lispref/display.texi | 19 ++++++++++++++----- lisp/button.el | 26 ++++++++++++++++---------- test/lisp/button-tests.el | 37 +++++++++++++++++++++++++++++++++++++ 3 files changed, 67 insertions(+), 15 deletions(-) diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi index 64b24f712a..d2074aa60c 100644 --- a/doc/lispref/display.texi +++ b/doc/lispref/display.texi @@ -6606,14 +6606,23 @@ Button Properties The button type. @xref{Button Types}. @item help-echo -@kindex help-index @r{(button property)} -A string displayed by the Emacs tool-tip help system; by default, -@code{"mouse-2, RET: Push this button"}. +@kindex help-echo @r{(button property)} +A string displayed by the Emacs tooltip help system; by default, +@code{"mouse-2, RET: Push this button"}. Alternatively, a function +that returns, or a form that evaluates to, a string to be displayed or +@code{nil}. For details see @ref{Text help-echo}. + +The function is called with three arguments, @var{window}, +@var{object}, and @var{pos}. The second argument, @var{object}, is +either the overlay that had the property (for overlay buttons), or the +buffer containing the button (for text property buttons). The other +arguments have the same meaning as for the special text property +@code{help-echo}. @item follow-link @kindex follow-link @r{(button property)} -The follow-link property, defining how a @key{mouse-1} click behaves -on this button, @xref{Clickable Text}. +The @code{follow-link} property, defining how a @key{mouse-1} click +behaves on this button, @xref{Clickable Text}. @item button @kindex button @r{(button property)} diff --git a/lisp/button.el b/lisp/button.el index 9112e518b0..ae2488bac6 100644 --- a/lisp/button.el +++ b/lisp/button.el @@ -470,13 +470,22 @@ push-button (button-activate button use-mouse-action) t)))) +(defun button--help-echo (button) + "Evaluate BUTTON's `help-echo' property and return its value." + (let ((help (button-get button 'help-echo))) + (if (functionp help) + (let ((obj (if (overlayp button) button (current-buffer)))) + (funcall help (selected-window) obj (button-start button))) + (eval help lexical-binding)))) + (defun forward-button (n &optional wrap display-message no-error) "Move to the Nth next button, or Nth previous button if N is negative. If N is 0, move to the start of any button at point. If WRAP is non-nil, moving past either end of the buffer continues from the other end. -If DISPLAY-MESSAGE is non-nil, the button's help-echo string is displayed. -Any button with a non-nil `skip' property is skipped over. +If DISPLAY-MESSAGE is non-nil, the button's `help-echo' property +is displayed. Any button with a non-nil `skip' property is +skipped over. If NO-ERROR, return nil if no further buttons could be found instead of erroring out. @@ -509,13 +518,9 @@ forward-button (unless (button-get button 'skip) (setq n (1- n))))))) (if (null button) - (if no-error - nil + (unless no-error (user-error (if wrap "No buttons!" "No more buttons"))) - (let ((msg (and display-message (button-get button 'help-echo)))) - (when (functionp msg) - (setq msg (funcall msg (selected-window) (current-buffer) - (button-start button)))) + (let ((msg (and display-message (button--help-echo button)))) (when msg (message "%s" msg))) button))) @@ -525,8 +530,9 @@ backward-button If N is 0, move to the start of any button at point. If WRAP is non-nil, moving past either end of the buffer continues from the other end. -If DISPLAY-MESSAGE is non-nil, the button's help-echo string is displayed. -Any button with a non-nil `skip' property is skipped over. +If DISPLAY-MESSAGE is non-nil, the button's `help-echo' property +is displayed. Any button with a non-nil `skip' property is +skipped over. If NO-ERROR, return nil if no further buttons could be found instead of erroring out. diff --git a/test/lisp/button-tests.el b/test/lisp/button-tests.el index d54a992ab8..052306f791 100644 --- a/test/lisp/button-tests.el +++ b/test/lisp/button-tests.el @@ -37,4 +37,41 @@ button-at (widget-create 'link "link widget") (should-not (button-at (1- (point)))))) +(ert-deftest button--help-echo () + "Test `button--help-echo' behavior." + (with-temp-buffer + ;; Text property buttons. + (let ((button (insert-text-button "text" 'help-echo "string"))) + (should (equal (button--help-echo button) "string"))) + (let ((button (insert-text-button "text" 'help-echo '(concat "form")))) + (should (equal (button--help-echo button) "form"))) + (let* ((owin (selected-window)) + (obuf (current-buffer)) + (opos (point)) + (help (lambda (win obj pos) + (should (eq win owin)) + (should (eq obj obuf)) + (should (= pos opos)) + "function")) + (button (insert-text-button "text" 'help-echo help))) + (should (equal (button--help-echo button) "function"))) + ;; Overlay buttons. + (let ((button (insert-button "overlay" 'help-echo "string"))) + (should (equal (button--help-echo button) "string"))) + (let ((button (insert-button "overlay" 'help-echo '(concat "form")))) + (should (equal (button--help-echo button) "form"))) + (letrec ((owin (selected-window)) + (obuf (current-buffer)) + (opos (point)) + (help (lambda (win obj pos) + (should (eq win owin)) + (should (overlayp obj)) + (should (eq obj button)) + (should (eq (overlay-buffer obj) obuf)) + (should (= (overlay-start obj) opos)) + (should (= pos opos)) + "function")) + (button (insert-button "overlay" 'help-echo help))) + (should (equal (button--help-echo button) "function"))))) + ;;; button-tests.el ends here -- 2.23.0 [-- Attachment #3: Type: text/plain, Size: 20 bytes --] Thanks, -- Basil ^ permalink raw reply related [flat|nested] 11+ messages in thread
* bug#37515: 27.0.50; button.el doesn't support help-echo function 2019-09-30 19:47 ` Basil L. Contovounesios @ 2019-09-30 19:53 ` Basil L. Contovounesios 2019-10-01 12:29 ` Basil L. Contovounesios 2019-10-01 12:28 ` Lars Ingebrigtsen 1 sibling, 1 reply; 11+ messages in thread From: Basil L. Contovounesios @ 2019-09-30 19:53 UTC (permalink / raw) To: Jose A. Ortega Ruiz; +Cc: Katsumi Yamaoka, Lars Ingebrigtsen, 37515 "Basil L. Contovounesios" <contovob@tcd.ie> writes: > diff --git a/lisp/button.el b/lisp/button.el > index 9112e518b0..ae2488bac6 100644 > --- a/lisp/button.el > +++ b/lisp/button.el > @@ -470,13 +470,22 @@ push-button > (button-activate button use-mouse-action) > t)))) > > +(defun button--help-echo (button) > + "Evaluate BUTTON's `help-echo' property and return its value." > + (let ((help (button-get button 'help-echo))) > + (if (functionp help) > + (let ((obj (if (overlayp button) button (current-buffer)))) > + (funcall help (selected-window) obj (button-start button))) > + (eval help lexical-binding)))) Note that I intend to enable lexical-binding in button.el in a future patch, in which case this call to eval will not need changing. -- Basil ^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#37515: 27.0.50; button.el doesn't support help-echo function 2019-09-30 19:53 ` Basil L. Contovounesios @ 2019-10-01 12:29 ` Basil L. Contovounesios 0 siblings, 0 replies; 11+ messages in thread From: Basil L. Contovounesios @ 2019-10-01 12:29 UTC (permalink / raw) To: Jose A. Ortega Ruiz; +Cc: Katsumi Yamaoka, Lars Ingebrigtsen, 37515 [-- Attachment #1: Type: text/plain, Size: 1151 bytes --] "Basil L. Contovounesios" <contovob@tcd.ie> writes: > "Basil L. Contovounesios" <contovob@tcd.ie> writes: > >> diff --git a/lisp/button.el b/lisp/button.el >> index 9112e518b0..ae2488bac6 100644 >> --- a/lisp/button.el >> +++ b/lisp/button.el >> @@ -470,13 +470,22 @@ push-button >> (button-activate button use-mouse-action) >> t)))) >> >> +(defun button--help-echo (button) >> + "Evaluate BUTTON's `help-echo' property and return its value." >> + (let ((help (button-get button 'help-echo))) >> + (if (functionp help) >> + (let ((obj (if (overlayp button) button (current-buffer)))) >> + (funcall help (selected-window) obj (button-start button))) >> + (eval help lexical-binding)))) > > Note that I intend to enable lexical-binding in button.el in a future > patch, in which case this call to eval will not need changing. Er, I was confused when I wrote this - whether button.el uses lexical-binding is irrelevant to the lexical evaluation of forms. The following is an updated patch which tests form evaluation under both dynamic and lexical scoping. I still intend to push it soon, if there are no objections. [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-Further-improve-button.el-support-for-help-echo.patch --] [-- Type: text/x-diff, Size: 7594 bytes --] From bb58dc2ab253b92b4e5683136d12eb86a3473410 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" <contovob@tcd.ie> Date: Fri, 27 Sep 2019 00:04:33 +0100 Subject: [PATCH] Further improve button.el support for help-echo The last change to forward-button added support for help-echo values that are functions. This patch fixes the arguments passed to such functions and further adds support for help-echo values that are forms (bug#37515). * doc/lispref/display.texi (Button Properties): Fix description of help-echo button property. * lisp/button.el (button--help-echo): New function. (forward-button): Use it. (backward-button): Clarify help-echo reference in docstring. * test/lisp/button-tests.el (button--help-echo-string) (button--help-echo-form, button--help-echo-function): New tests. --- doc/lispref/display.texi | 19 +++++++++---- lisp/button.el | 26 +++++++++++------- test/lisp/button-tests.el | 56 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 86 insertions(+), 15 deletions(-) diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi index 64b24f712a..d2074aa60c 100644 --- a/doc/lispref/display.texi +++ b/doc/lispref/display.texi @@ -6606,14 +6606,23 @@ Button Properties The button type. @xref{Button Types}. @item help-echo -@kindex help-index @r{(button property)} -A string displayed by the Emacs tool-tip help system; by default, -@code{"mouse-2, RET: Push this button"}. +@kindex help-echo @r{(button property)} +A string displayed by the Emacs tooltip help system; by default, +@code{"mouse-2, RET: Push this button"}. Alternatively, a function +that returns, or a form that evaluates to, a string to be displayed or +@code{nil}. For details see @ref{Text help-echo}. + +The function is called with three arguments, @var{window}, +@var{object}, and @var{pos}. The second argument, @var{object}, is +either the overlay that had the property (for overlay buttons), or the +buffer containing the button (for text property buttons). The other +arguments have the same meaning as for the special text property +@code{help-echo}. @item follow-link @kindex follow-link @r{(button property)} -The follow-link property, defining how a @key{mouse-1} click behaves -on this button, @xref{Clickable Text}. +The @code{follow-link} property, defining how a @key{mouse-1} click +behaves on this button, @xref{Clickable Text}. @item button @kindex button @r{(button property)} diff --git a/lisp/button.el b/lisp/button.el index 9112e518b0..ae2488bac6 100644 --- a/lisp/button.el +++ b/lisp/button.el @@ -470,13 +470,22 @@ push-button (button-activate button use-mouse-action) t)))) +(defun button--help-echo (button) + "Evaluate BUTTON's `help-echo' property and return its value." + (let ((help (button-get button 'help-echo))) + (if (functionp help) + (let ((obj (if (overlayp button) button (current-buffer)))) + (funcall help (selected-window) obj (button-start button))) + (eval help lexical-binding)))) + (defun forward-button (n &optional wrap display-message no-error) "Move to the Nth next button, or Nth previous button if N is negative. If N is 0, move to the start of any button at point. If WRAP is non-nil, moving past either end of the buffer continues from the other end. -If DISPLAY-MESSAGE is non-nil, the button's help-echo string is displayed. -Any button with a non-nil `skip' property is skipped over. +If DISPLAY-MESSAGE is non-nil, the button's `help-echo' property +is displayed. Any button with a non-nil `skip' property is +skipped over. If NO-ERROR, return nil if no further buttons could be found instead of erroring out. @@ -509,13 +518,9 @@ forward-button (unless (button-get button 'skip) (setq n (1- n))))))) (if (null button) - (if no-error - nil + (unless no-error (user-error (if wrap "No buttons!" "No more buttons"))) - (let ((msg (and display-message (button-get button 'help-echo)))) - (when (functionp msg) - (setq msg (funcall msg (selected-window) (current-buffer) - (button-start button)))) + (let ((msg (and display-message (button--help-echo button)))) (when msg (message "%s" msg))) button))) @@ -525,8 +530,9 @@ backward-button If N is 0, move to the start of any button at point. If WRAP is non-nil, moving past either end of the buffer continues from the other end. -If DISPLAY-MESSAGE is non-nil, the button's help-echo string is displayed. -Any button with a non-nil `skip' property is skipped over. +If DISPLAY-MESSAGE is non-nil, the button's `help-echo' property +is displayed. Any button with a non-nil `skip' property is +skipped over. If NO-ERROR, return nil if no further buttons could be found instead of erroring out. diff --git a/test/lisp/button-tests.el b/test/lisp/button-tests.el index d54a992ab8..44a7ea6f6e 100644 --- a/test/lisp/button-tests.el +++ b/test/lisp/button-tests.el @@ -37,4 +37,60 @@ button-at (widget-create 'link "link widget") (should-not (button-at (1- (point)))))) +(ert-deftest button--help-echo-string () + "Test `button--help-echo' with strings." + (with-temp-buffer + ;; Text property buttons. + (let ((button (insert-text-button "text" 'help-echo "text help"))) + (should (equal (button--help-echo button) "text help"))) + ;; Overlay buttons. + (let ((button (insert-button "overlay" 'help-echo "overlay help"))) + (should (equal (button--help-echo button) "overlay help"))))) + +(ert-deftest button--help-echo-form () + "Test `button--help-echo' with forms." + (with-temp-buffer + ;; Test text property buttons with dynamic scoping. + (let* ((help (make-symbol "help")) + (form `(funcall (let ((,help "lexical form")) + (lambda () ,help)))) + (button (insert-text-button "text" 'help-echo form))) + (set help "dynamic form") + (should (equal (button--help-echo button) "dynamic form"))) + ;; Test overlay buttons with lexical scoping. + (setq lexical-binding t) + (let* ((help (make-symbol "help")) + (form `(funcall (let ((,help "lexical form")) + (lambda () ,help)))) + (button (insert-button "overlay" 'help-echo form))) + (set help "dynamic form") + (should (equal (button--help-echo button) "lexical form"))))) + +(ert-deftest button--help-echo-function () + "Test `button--help-echo' with functions." + (with-temp-buffer + ;; Text property buttons. + (let* ((owin (selected-window)) + (obuf (current-buffer)) + (opos (point)) + (help (lambda (win obj pos) + (should (eq win owin)) + (should (eq obj obuf)) + (should (= pos opos)) + "text function")) + (button (insert-text-button "text" 'help-echo help))) + (should (equal (button--help-echo button) "text function")) + ;; Overlay buttons. + (setq help (lambda (win obj pos) + (should (eq win owin)) + (should (overlayp obj)) + (should (eq obj button)) + (should (eq (overlay-buffer obj) obuf)) + (should (= (overlay-start obj) opos)) + (should (= pos opos)) + "overlay function")) + (setq opos (point)) + (setq button (insert-button "overlay" 'help-echo help)) + (should (equal (button--help-echo button) "overlay function"))))) + ;;; button-tests.el ends here -- 2.23.0 [-- Attachment #3: Type: text/plain, Size: 20 bytes --] Thanks, -- Basil ^ permalink raw reply related [flat|nested] 11+ messages in thread
* bug#37515: 27.0.50; button.el doesn't support help-echo function 2019-09-30 19:47 ` Basil L. Contovounesios 2019-09-30 19:53 ` Basil L. Contovounesios @ 2019-10-01 12:28 ` Lars Ingebrigtsen 2019-10-01 12:32 ` Basil L. Contovounesios 1 sibling, 1 reply; 11+ messages in thread From: Lars Ingebrigtsen @ 2019-10-01 12:28 UTC (permalink / raw) To: Basil L. Contovounesios; +Cc: Katsumi Yamaoka, Jose A. Ortega Ruiz, 37515 "Basil L. Contovounesios" <contovob@tcd.ie> writes: > Some further changes are needed to fully support the help-echo property. > Firstly, help-echo functions expect an overlay as their second argument > when the object that had the property is an overlay (button). Secondly, > help-echo values can be forms in addition to strings and functions. > Lastly, (info "(elisp) Button Properties") needs updating to reflect the > supported values of the help-echo button property. > > The following patch should do all this. I will push it in the next few > days if there are no objections. WDYT? Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#37515: 27.0.50; button.el doesn't support help-echo function 2019-10-01 12:28 ` Lars Ingebrigtsen @ 2019-10-01 12:32 ` Basil L. Contovounesios 2019-10-03 23:00 ` Basil L. Contovounesios 0 siblings, 1 reply; 11+ messages in thread From: Basil L. Contovounesios @ 2019-10-01 12:32 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: Katsumi Yamaoka, Jose A. Ortega Ruiz, 37515 Lars Ingebrigtsen <larsi@gnus.org> writes: > "Basil L. Contovounesios" <contovob@tcd.ie> writes: > >> Some further changes are needed to fully support the help-echo property. >> Firstly, help-echo functions expect an overlay as their second argument >> when the object that had the property is an overlay (button). Secondly, >> help-echo values can be forms in addition to strings and functions. >> Lastly, (info "(elisp) Button Properties") needs updating to reflect the >> supported values of the help-echo button property. >> >> The following patch should do all this. I will push it in the next few >> days if there are no objections. WDYT? > > Looks good to me. Thanks! (The updated patch I just sent merely extends the tests.) -- Basil ^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#37515: 27.0.50; button.el doesn't support help-echo function 2019-10-01 12:32 ` Basil L. Contovounesios @ 2019-10-03 23:00 ` Basil L. Contovounesios 0 siblings, 0 replies; 11+ messages in thread From: Basil L. Contovounesios @ 2019-10-03 23:00 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: Katsumi Yamaoka, Jose A. Ortega Ruiz, 37515 "Basil L. Contovounesios" <contovob@tcd.ie> writes: > Lars Ingebrigtsen <larsi@gnus.org> writes: > >> "Basil L. Contovounesios" <contovob@tcd.ie> writes: >> >>> Some further changes are needed to fully support the help-echo property. >>> Firstly, help-echo functions expect an overlay as their second argument >>> when the object that had the property is an overlay (button). Secondly, >>> help-echo values can be forms in addition to strings and functions. >>> Lastly, (info "(elisp) Button Properties") needs updating to reflect the >>> supported values of the help-echo button property. >>> >>> The following patch should do all this. I will push it in the next few >>> days if there are no objections. WDYT? >> >> Looks good to me. > > Thanks! (The updated patch I just sent merely extends the tests.) Now pushed to master: Further improve button.el support for help-echo 0fc8177414 2019-10-03 23:05:14 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0fc8177414801e428ca184e8a9ba8b79a291c15a Thanks, -- Basil ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-10-03 23:00 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-26 1:14 bug#37515: 27.0.50; button.el doesn't support help-echo function Katsumi Yamaoka
2019-09-26 1:26 ` Katsumi Yamaoka
2019-09-26 13:49 ` Lars Ingebrigtsen
[not found] ` <esr-pdhHsyCqhSoZbW_3iLp4UdujyDpcbOuBdPROA9aG3j9CO0niyrK5O_Tf33N-le-e5hmaqbYZLyuNc6kd3A==@protonmail.internalid>
2019-09-26 21:44 ` Katsumi Yamaoka
2019-09-26 22:56 ` Jose A. Ortega Ruiz
2019-09-30 19:47 ` Basil L. Contovounesios
2019-09-30 19:53 ` Basil L. Contovounesios
2019-10-01 12:29 ` Basil L. Contovounesios
2019-10-01 12:28 ` Lars Ingebrigtsen
2019-10-01 12:32 ` Basil L. Contovounesios
2019-10-03 23:00 ` Basil L. Contovounesios
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).