From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stefan@marxist.se, 19565@debbugs.gnu.org
Subject: bug#19565: Emacs vulnerable to endless-data attack (minor)
Date: Tue, 08 Oct 2019 18:27:15 +0200 [thread overview]
Message-ID: <87zhibyzh8.fsf@gnus.org> (raw)
In-Reply-To: <831rvo1qlk.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Oct 2019 19:13:11 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> I think this must be in terms of bytes/sec, not just bytes. E.g., I
> have a spell-checker active during my entire Emacs session (which
> could go on for weeks and months on end), and I don't want to get a
> prompt just because the number of bytes that went in that pipe becomes
> above the threshold. We may also need to measure the growth of the
> Emacs memory footprint during that time, because if Emacs reads bytes
> and discards them, it isn't going to be a problem, right?
Yeah, that's true -- a counter wouldn't help at all here.
Would checking the size of the `process-buffer' of the process be more
helpful? It might be a somewhat unnatural thing to do -- Emacs doesn't
give you a warning if you say
(dotimes (i 100000000) (insert (make-string 80 ?a)))
so perhaps that's not a good heuristic, either.
So bytes/sec, as you suggest, may be the best heuristic. But it should
only kick in after having received a large number of bytes, probably.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-10-08 16:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-11 11:12 bug#19565: Emacs vulnerable to endless-data attack (minor) Kelly Dean
2015-01-11 18:33 ` Richard Stallman
2015-01-11 21:18 ` Kelly Dean
2019-10-06 3:13 ` Stefan Kangas
2019-10-06 17:32 ` Eli Zaretskii
2019-10-07 1:51 ` Lars Ingebrigtsen
2019-10-07 12:50 ` Stefan Kangas
2019-10-07 16:13 ` Eli Zaretskii
2019-10-08 16:27 ` Lars Ingebrigtsen [this message]
2019-10-08 16:47 ` Eli Zaretskii
2019-10-08 16:50 ` Stefan Kangas
2019-10-08 17:22 ` Eli Zaretskii
2019-10-08 17:38 ` Stefan Kangas
2019-10-08 18:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhibyzh8.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=19565@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).