From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 37771@debbugs.gnu.org
Subject: bug#37771: 26.3; doc for `dired-auto-revert-buffer'
Date: Thu, 17 Oct 2019 04:57:46 +0200 [thread overview]
Message-ID: <87zhi0krit.fsf@gnus.org> (raw)
In-Reply-To: <60cfbdb5-8f92-4af6-bf5a-f1f7f05bd1c6@default> (Drew Adams's message of "Tue, 15 Oct 2019 15:35:05 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
> Please consider improving the doc so that it does the following:
>
> * Explains what is meant by "visiting" a Dired buffer. The Emacs
> manuals and other doc only speak about visiting a file in a buffer.
> Just what constitutes "visiting" a Dired buffer? It seems like it's
> sufficient to display the buffer and select its window. Is that it?
It means whatever Emacs means by "visiting" a file. I don't see what's
there to explain.
> * Explains the Value Menu items in Customize - in particular, item
> `Revert changed Dired buffer'.
Explaining what "revert" means in this context seems a bit odd. There's
a manual for that.
> * Explains that the option has no effect on Dired buffers containing
> arbitrary file lists (i.e., whose DIRNAME is a cons). It is relevant
> only for actual directory listings.
You mean that switching it off doesn't stop reverting in that case?
;; Always revert when `dir-or-list' is a cons. Also revert
;; if `dired-directory' is a cons but `dir-or-list' is not.
((or (consp dir-or-list) (consp dired-directory))
(setq dired-directory dir-or-list)
(revert-buffer))
;; Always revert regardless of whether it has changed or not.
((eq dired-auto-revert-buffer t)
(revert-buffer))
As far as I can tell, this is only reached when you call `dired'
explicitly with a list of file names? That dired updates the buffer
when you call it with a bunch of file names, without consulting
dired-auto-revert-buffer, seems pretty self-evident.
> * Lists the Lisp values that correspond to the Value Menu items.
They all seem documented?
(const :tag "Revert changed Dired buffer" dired-directory-changed-p)
is just a predicate function.
Didn't see anything that needed fixing here, and I'm closing this bug
report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-10-17 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 22:35 bug#37771: 26.3; doc for `dired-auto-revert-buffer' Drew Adams
2019-10-17 2:57 ` Lars Ingebrigtsen [this message]
2019-10-17 15:34 ` Drew Adams
2019-10-17 17:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhi0krit.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=37771@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).